Skip to content

[Feature](recycler) Add recycler metrics for recycler layer #51409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 18, 2025
Merged

[Feature](recycler) Add recycler metrics for recycler layer #51409

dataroaring merged 1 commit into from
Jun 18, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Jun 3, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat changed the title [Feature](recycler) Add recycler metrics for recycle layer [Feature](recycler) Add recycler metrics for recycler layer Jun 3, 2025
@wyxxxcat wyxxxcat force-pushed the recycler_recycle branch from b29951a to 29b0610 Compare June 4, 2025 09:52
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jun 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 4, 2025

Cloud UT Coverage Report

Increment line coverage 91.67% (33/36) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.28% (1121/1346)
Line Coverage 66.81% (19216/28761)
Region Coverage 66.41% (9504/14311)
Branch Coverage 56.36% (5149/9136)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit af5fd36 into apache:master Jun 18, 2025
30 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 18, 2025
@wyxxxcat
[Feature](recycler) Add recycler metrics for recycler layer (#51409)
50f861f
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 20, 2025
@wyxxxcat @dataroaring
[Feature](recycler) Add recycler metrics for recycler layer (#51409)
b6ad72f
dataroaring pushed a commit that referenced this pull request Jun 23, 2025
@github-actions @wyxxxcat
branch-3.0: [Feature](recycler) Add recycler metrics for recycler layer
7eceebb 
#51409 (#51884)

Cherry-picked from #51409

Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
@wyxxxcat
[Feature](recycler) Add recycler metrics for recycler layer (#51409)
ee769bb
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 24, 2025
@github-actions @wyxxxcat
branch-3.1: [Feature](recycler) Add recycler metrics for recycler layer
bd33a79 
#51409 (#52176)

Cherry-picked from #51409

Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat @hello-stephen @gavinchou @Yukang-Lian @dataroaring @morrySnow