Skip to content

branch-3.0: [fix](inverted index) fix error when open empty index file #51393 #51438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 11, 2025
Merged

branch-3.0: [fix](inverted index) fix error when open empty index file #51393 #51438

dataroaring merged 1 commit into from
Jun 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 3, 2025

Cherry-picked from #51393

@airborne12
[fix](inverted index) fix error when open empty index file (#51393)
ee9fc1b 
Related PR: #50937 

Problem Summary:
This PR fixes the error that occurs when attempting to open an empty
inverted index file by adding a proper empty file check and error
reporting.

Added a condition to verify if the file size is zero.
Sets an error message and returns false to prevent CLucene errors.
@github-actions github-actions bot requested a review from dataroaring as a code owner June 3, 2025 09:06
@Thearas
Copy link
Contributor

Thearas commented Jun 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jun 3, 2025
@dataroaring dataroaring reopened this Jun 3, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 3, 2025

BE UT Coverage Report

Increment line coverage 16.67% (1/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.08% (10864/26445)
Line Coverage 31.92% (92902/291002)
Region Coverage 31.00% (47917/154570)
Branch Coverage 27.49% (24550/89308)

dataroaring
dataroaring approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f23dae0 into branch-3.0 Jun 11, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-51393-branch-3.0 branch June 11, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @hello-stephen @dataroaring @airborne12