-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](topn)fix external table topn lazy materialize cause be core. #51442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33830 ms |
TPC-DS: Total hot run time: 185920 ms |
ClickBench: Total hot run time: 29.28 s |
|
run buildall |
1 similar comment
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
TPC-H: Total hot run time: 34596 ms |
TPC-DS: Total hot run time: 193393 ms |
ClickBench: Total hot run time: 28.85 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Related PR: #51329
Problem Summary:
In the previous PR #51329, global lazy materialization was implemented.
However, since RPC requests will be sent to other BE nodes during the materialization phase, the external node needs to rely on
query ctxwhen reading the corresponding file after receiving the RPC request, but thequery ctxon the BE may have been released, resulting in BE core.Solution:
By caching some information in
query ctx, RPC does not need to rely onquery ctx.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)