Skip to content

(#5151) An already merged rowset should skip window check #5152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kangkaisen merged 1 commit into from
Dec 26, 2020
Merged

(#5151) An already merged rowset should skip window check #5152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions be/src/olap/cumulative_compaction_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,10 @@ void CumulativeCompactionPolicy::pick_candidate_rowsets(
int64_t now = UnixSeconds();
for (auto& it : rs_version_map) {
// find all rowset version greater than cumulative_point and skip the create time in skip_window_sec
if (it.first.first >= cumulative_point &&
(it.second->creation_time() + skip_window_sec < now)) {
if (it.first.first >= cumulative_point
&& ((it.second->creation_time() + skip_window_sec < now)
// this case means a rowset has been compacted before which is not a new published rowset, so it should participate compaction
|| (it.first.first != it.first.second))) {
candidate_rowsets->push_back(it.second);
}
}
Expand Down