Skip to content

Conversation

@liaoxin01
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #51246
#51246 did not completely fix the issue.

Problem Summary:

  • DefaultRemote's S3Client is hardcoded to use HTTP protocol
  • Protocol inconsistency between S3Client and S3AFileSystem:
    • S3AFileSystem defaults to HTTPS internally
    • S3Client forces HTTP
    • This can cause protocol mismatch issues

Solution

  • Fix S3Client to support both HTTP and HTTPS protocols
  • When users don't specify protocol in endpoint:
    • Add HTTP protocol prefix by default in LoadStmt
    • This maintains consistency with existing behavior
    • Prevents protocol mismatch between components

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@liaoxin01 liaoxin01 requested a review from dataroaring as a code owner June 5, 2025 10:09
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1879f87 into apache:branch-3.0 Jun 5, 2025
20 of 24 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by anyone and no changes requested.

@gavinchou gavinchou mentioned this pull request Jun 11, 2025
liaoxin01 pushed a commit that referenced this pull request Jul 21, 2025
…_load (#53525)

Related PR: #51529

Problem Summary:

PR #51529 introduced a change that adds `http://` to S3 endpoints if no
protocol is specified.
For example, `cluster:${s3Endpoint}` could become
`cluster:http://${s3Endpoint}`.
This PR updates the test logic to accept S3 endpoints with extra
protocol prefix .
github-actions bot pushed a commit that referenced this pull request Jul 21, 2025
…_load (#53525)

Related PR: #51529

Problem Summary:

PR #51529 introduced a change that adds `http://` to S3 endpoints if no
protocol is specified.
For example, `cluster:${s3Endpoint}` could become
`cluster:http://${s3Endpoint}`.
This PR updates the test logic to accept S3 endpoints with extra
protocol prefix .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants