Skip to content

branch-3.0: [Fix](cloud-mow) Remove potential existing split delete bitmap KVs before update them in schema change (#51353) #51531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jun 18, 2025
Merged

branch-3.0: [Fix](cloud-mow) Remove potential existing split delete bitmap KVs before update them in schema change (#51353) #51531

dataroaring merged 2 commits into from
Jun 18, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jun 5, 2025

pick #51353

@bobhan1
[Fix](cloud-mow) Remove potential existing split delete bitmap KVs be…
f77a277 
…fore update them in schema change (apache#51353)

If a schema change job failed and retry on BE, the previous failed sc
job will not clear its delete bitmap KVs written in MS. So later retry
may update existing delete bitmap KVs on new tablet. Considering that
delete bitmap KVs will be split into multiple KVs when too large, we may
get wrong delete bitmaps if we don't remove the previous KVs before put
them.
This PR use pending delete bitmaps to avoid this situation for SC.
@bobhan1 bobhan1 requested a review from dataroaring as a code owner June 5, 2025 10:34
@Thearas
Copy link
Contributor

Thearas commented Jun 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 5, 2025

run buildall

dataroaring
dataroaring previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jun 12, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 12, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 12, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.14% (1095/1317)
Line Coverage 66.35% (18288/27561)
Region Coverage 66.15% (9060/13696)
Branch Coverage 55.96% (4902/8760)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 13, 2025

run nonConcurrent

dataroaring
dataroaring approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2025
@dataroaring dataroaring merged commit d199e24 into apache:branch-3.0 Jun 18, 2025
24 of 25 checks passed
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jun 20, 2025
@bobhan1
branch-3.0: [Fix](cloud-mow) Remove potential existing split delete b…
ad4ea7a 
…itmap KVs before update them in schema change (apache#51353) (apache#51531)

pick apache#51353
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@bobhan1
branch-3.1: [Fix](cloud-mow) Remove potential existing split delete b…
a294c52 
…itmap KVs before update them in schema change #51353 #51531 (#51999)

pick from master #51353
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1 @Thearas @hello-stephen @dataroaring @morrySnow