Skip to content

[BUG] Follower shouldn't forward non-query statement to master repeatedly #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caiconghui merged 1 commit into from
Dec 29, 2020
Merged

[BUG] Follower shouldn't forward non-query statement to master repeatedly #5160

caiconghui merged 1 commit into from
Dec 29, 2020

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Dec 28, 2020 •
edited
Loading

Proposed changes

Follower shouldn't forward non-query statement to master repeatedly

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

None

@924060929 924060929 changed the title [BUG] Follower should forward non-query statement to master repeatedly [BUG] Follower shouldn't forward non-query statement to master repeatedly Dec 28, 2020
@caiconghui caiconghui added api-review Categorizes an issue or PR as actively needing an API review. kind/fix Categorizes issue or PR as related to a bug. and removed api-review Categorizes an issue or PR as actively needing an API review. labels Dec 28, 2020
@caiconghui
Copy link
Contributor

caiconghui commented Dec 28, 2020

plz add an issue related to this PR

@924060929
Copy link
Contributor Author

924060929 commented Dec 28, 2020

plz add an issue related to this PR

done, see #5161

@caiconghui
Copy link
Contributor

caiconghui commented Dec 28, 2020 •
edited
Loading

plz add an issue related to this PR

done, see #5161

what exception will transfer operation throw, when network problem occur and it it not a timeout exception?

@924060929
Copy link
Contributor Author

924060929 commented Dec 28, 2020

plz add an issue related to this PR

done, see #5161
what exception will transfer operation throw, when network problem occur and it it not a timeout exception?

TTransportException.UNKNOWN

caiconghui
caiconghui approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiconghui caiconghui added the approved Indicates a PR has been approved by one committer. label Dec 28, 2020
@caiconghui caiconghui merged commit cd865c9 into apache:master Dec 29, 2020
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
@924060929 @morningman-cmy
Follower don't forward non-query statement to master repeatedly (apac…
d85b58f 
…he#5160)

Co-authored-by: lanhuajian <lanhuajian@sankuai.com>
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caiconghui caiconghui caiconghui approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@924060929 @caiconghui