Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51463

TTL is first-class citizen in Doris FileCache. But the original order
make TTL override by INDEX if the context happens to be index of TTL
data. We ensure it will be TTL in this PR.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot requested a review from dataroaring as a code owner June 10, 2025 03:01
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 10, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39879 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c94d75254ad6f57bd3af649b9a77f299989e506, data reload: false

------ Round 1 ----------------------------------
q1	17575	6810	6608	6608
q2	2067	175	193	175
q3	10564	1083	1136	1083
q4	10570	731	734	731
q5	7774	2925	2863	2863
q6	218	136	140	136
q7	995	612	613	612
q8	9381	2013	2063	2013
q9	7034	6409	6449	6409
q10	6961	2257	2312	2257
q11	472	268	259	259
q12	413	225	211	211
q13	17768	2981	2997	2981
q14	231	208	208	208
q15	499	472	470	470
q16	503	397	378	378
q17	994	535	555	535
q18	7366	6633	6658	6633
q19	1389	1008	1070	1008
q20	495	208	203	203
q21	3994	3118	3230	3118
q22	1089	991	988	988
Total cold run time: 108352 ms
Total hot run time: 39879 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6640	6552	6518	6518
q2	331	231	230	230
q3	2927	2786	2920	2786
q4	2032	1824	1802	1802
q5	5822	5776	5716	5716
q6	224	133	138	133
q7	2206	1765	1862	1765
q8	3415	3631	3573	3573
q9	8963	8852	8989	8852
q10	3595	3522	3528	3522
q11	592	489	486	486
q12	839	583	604	583
q13	10087	3192	3131	3131
q14	311	285	273	273
q15	508	480	470	470
q16	502	449	453	449
q17	1850	1646	1648	1646
q18	8297	7873	7715	7715
q19	1727	1687	1532	1532
q20	2039	1828	1882	1828
q21	5533	5316	5242	5242
q22	1137	1073	1040	1040
Total cold run time: 69577 ms
Total hot run time: 59292 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196850 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c94d75254ad6f57bd3af649b9a77f299989e506, data reload: false

query1	1305	906	903	903
query2	6296	1929	1867	1867
query3	10840	4396	4138	4138
query4	61227	29382	23611	23611
query5	5180	468	454	454
query6	396	169	168	168
query7	5442	317	314	314
query8	303	229	232	229
query9	8411	2589	2549	2549
query10	456	269	262	262
query11	18088	15216	15705	15216
query12	164	108	106	106
query13	1491	450	424	424
query14	9907	6900	7391	6900
query15	201	193	177	177
query16	7055	513	455	455
query17	1206	596	600	596
query18	1882	329	319	319
query19	228	160	167	160
query20	118	120	119	119
query21	203	105	104	104
query22	4638	4427	4740	4427
query23	34834	33864	34059	33864
query24	6341	2890	2929	2890
query25	526	395	408	395
query26	656	163	163	163
query27	1899	368	359	359
query28	4169	2146	2184	2146
query29	688	460	433	433
query30	248	159	155	155
query31	1001	829	797	797
query32	68	58	57	57
query33	415	276	285	276
query34	932	509	497	497
query35	874	711	734	711
query36	1080	958	968	958
query37	109	67	67	67
query38	4121	4023	3988	3988
query39	1533	1473	1462	1462
query40	201	100	99	99
query41	52	48	49	48
query42	118	104	102	102
query43	513	474	479	474
query44	1228	817	822	817
query45	194	171	171	171
query46	1152	753	727	727
query47	2001	1910	1919	1910
query48	474	384	391	384
query49	728	391	402	391
query50	844	430	430	430
query51	7387	7312	7183	7183
query52	104	90	92	90
query53	274	181	189	181
query54	580	465	466	465
query55	78	78	80	78
query56	287	267	261	261
query57	1253	1174	1164	1164
query58	223	236	253	236
query59	3197	2937	2990	2937
query60	288	263	260	260
query61	116	112	107	107
query62	813	717	680	680
query63	229	186	187	186
query64	1423	683	645	645
query65	3349	3364	3274	3274
query66	709	331	315	315
query67	15829	15730	15581	15581
query68	4280	570	564	564
query69	430	272	279	272
query70	1170	1091	1114	1091
query71	339	264	259	259
query72	6528	4177	4197	4177
query73	741	349	366	349
query74	10442	9281	9220	9220
query75	3375	2627	2672	2627
query76	1958	1105	1113	1105
query77	470	277	268	268
query78	10837	9680	9636	9636
query79	2449	607	618	607
query80	1063	422	444	422
query81	526	225	224	224
query82	184	87	90	87
query83	174	145	140	140
query84	284	83	84	83
query85	1084	305	291	291
query86	397	300	276	276
query87	4427	4254	4257	4254
query88	4644	2346	2337	2337
query89	406	297	293	293
query90	1988	181	182	181
query91	189	153	146	146
query92	62	50	53	50
query93	2401	555	548	548
query94	829	288	309	288
query95	364	273	253	253
query96	617	279	288	279
query97	3404	3153	3137	3137
query98	220	192	195	192
query99	1645	1282	1300	1282
Total cold run time: 316102 ms
Total hot run time: 196850 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0c94d75254ad6f57bd3af649b9a77f299989e506, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.61	0.10	0.10
query5	0.54	0.53	0.53
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.49	0.49
query10	0.57	0.55	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.60	0.59	0.60
query14	0.76	0.82	0.82
query15	0.85	0.84	0.84
query16	0.38	0.41	0.40
query17	1.07	1.05	1.07
query18	0.23	0.22	0.22
query19	1.95	1.86	1.82
query20	0.01	0.01	0.01
query21	15.42	0.58	0.57
query22	2.53	2.28	1.92
query23	17.04	1.08	0.73
query24	3.11	1.04	1.19
query25	0.21	0.13	0.08
query26	0.56	0.15	0.15
query27	0.04	0.04	0.03
query28	10.41	0.51	0.46
query29	12.60	3.21	3.19
query30	0.24	0.06	0.06
query31	2.86	0.38	0.39
query32	3.25	0.48	0.46
query33	2.97	3.04	3.00
query34	17.13	4.45	4.48
query35	4.56	4.51	4.50
query36	0.69	0.48	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 105.06 s
Total hot run time: 30.31 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.10% (10871/26450)
Line Coverage 31.94% (92960/291083)
Region Coverage 31.02% (47968/154621)
Branch Coverage 27.51% (24577/89342)

@freemandealer
Copy link
Contributor

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bee8e3e into branch-3.0 Jun 11, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-51463-branch-3.0 branch June 11, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants