Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Dec 28, 2020

Proposed changes

In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a dependent segment writer.

This is 2nd part of improving load performance.

#5281

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@morningman morningman closed this Dec 28, 2020
@morningman morningman reopened this Dec 28, 2020
@morningman morningman marked this pull request as draft December 28, 2020 12:02
In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a different segment writer.
@morningman morningman marked this pull request as ready for review January 21, 2021 15:27
@morningman morningman changed the title [Refactor] Support parallel flushing memtable during load [Load Parallel][1/3] Support parallel flushing memtable during load Jan 21, 2021
@morningman morningman changed the title [Load Parallel][1/3] Support parallel flushing memtable during load [Load Parallel][2/3] Support parallel flushing memtable during load Jan 21, 2021
@morningman morningman self-assigned this Jan 21, 2021
@morningman morningman added area/load Issues or PRs related to all kinds of load kind/improvement labels Jan 21, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Jan 23, 2021
@morningman morningman merged commit ab06e92 into apache:master Jan 24, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
…pache#5163)

In the previous implementation, in an load job,
multiple memtables of the same tablet are written to disk sequentially.
In fact, multiple memtables can be written out of order in parallel,
only need to ensure that each memtable uses a different segment writer.
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants