Skip to content

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Jun 12, 2025

the pr is the manual partitial pick #51573

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@swjtu-zhanglei
Copy link
Contributor Author

the pr is the manual partitial pick #51573

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40858 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 35fb27f25723398c713760d8f456dcf8df736a9e, data reload: false

------ Round 1 ----------------------------------
q1	17571	6714	6553	6553
q2	2096	199	182	182
q3	10576	1133	1234	1133
q4	10565	782	805	782
q5	7768	2919	2909	2909
q6	220	142	136	136
q7	1013	657	639	639
q8	9391	1994	2058	1994
q9	6722	6416	6487	6416
q10	7086	2327	2306	2306
q11	486	298	295	295
q12	427	242	234	234
q13	17802	3103	3077	3077
q14	250	226	231	226
q15	520	467	468	467
q16	547	420	410	410
q17	1009	627	610	610
q18	7526	6804	6902	6804
q19	1423	1130	1048	1048
q20	504	238	241	238
q21	4088	3465	3364	3364
q22	1173	1064	1035	1035
Total cold run time: 108763 ms
Total hot run time: 40858 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6577	6527	6518	6518
q2	336	238	248	238
q3	2979	3040	3054	3040
q4	2103	1921	1941	1921
q5	5733	5803	5768	5768
q6	209	138	134	134
q7	2308	1817	1908	1817
q8	3406	3574	3578	3574
q9	8872	8947	8957	8947
q10	3634	3588	3580	3580
q11	596	524	526	524
q12	840	674	639	639
q13	8197	3295	3266	3266
q14	308	282	273	273
q15	535	495	471	471
q16	523	494	473	473
q17	1869	1664	1642	1642
q18	8313	8081	7941	7941
q19	1730	1644	1429	1429
q20	2148	1884	1915	1884
q21	5629	5236	5445	5236
q22	1215	1141	1109	1109
Total cold run time: 68060 ms
Total hot run time: 60424 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/61) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10894/26468)
Line Coverage 31.97% (93168/291386)
Region Coverage 31.06% (48065/154741)
Branch Coverage 27.54% (24626/89418)

@swjtu-zhanglei
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 40198 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 35fb27f25723398c713760d8f456dcf8df736a9e, data reload: false

------ Round 1 ----------------------------------
q1	17583	6693	6562	6562
q2	2042	177	182	177
q3	10635	1120	1169	1120
q4	10548	783	754	754
q5	7771	2875	2785	2785
q6	223	139	134	134
q7	975	617	619	617
q8	9361	1895	1997	1895
q9	6625	6440	6436	6436
q10	7028	2288	2335	2288
q11	472	277	275	275
q12	421	229	221	221
q13	17909	3157	3119	3119
q14	243	209	227	209
q15	521	487	476	476
q16	543	415	397	397
q17	1009	586	563	563
q18	7450	6928	6756	6756
q19	1397	1121	1085	1085
q20	492	215	218	215
q21	3930	3109	3268	3109
q22	1136	1060	1005	1005
Total cold run time: 108314 ms
Total hot run time: 40198 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6588	6542	6495	6495
q2	330	238	239	238
q3	2936	2801	2967	2801
q4	2059	1789	1772	1772
q5	5722	5786	5769	5769
q6	206	125	131	125
q7	2209	1832	1802	1802
q8	3365	3583	3512	3512
q9	9016	8811	8995	8811
q10	3594	3516	3555	3516
q11	593	510	490	490
q12	799	652	646	646
q13	8939	3120	3225	3120
q14	300	266	268	266
q15	523	466	465	465
q16	507	450	432	432
q17	1836	1625	1592	1592
q18	8300	7803	7893	7803
q19	1699	1522	1588	1522
q20	2143	1818	1883	1818
q21	5180	5190	4963	4963
q22	1176	1106	1078	1078
Total cold run time: 68020 ms
Total hot run time: 59036 ms

Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 029197d into apache:branch-3.0 Jun 18, 2025
22 of 25 checks passed
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jun 20, 2025
morrySnow pushed a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants