[enhancement](filecache) fix default capacity and add reset_capacity validation #51711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation originall default capacity is total disk size * ratio we user set zero or extrem large space than acutal disk. I found the ratio part make no sense. we just use total disk size in this case. I alse add validation for reset_capacity http action rather than set the raw capacity. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
reviewed
Jun 13, 2025
gavinchou
reviewed
Jun 13, 2025
| ss << cache->reset_capacity(new_capacity); | ||
| for (auto& [p, cache] : _path_to_cache) { | ||
| int64_t valid_capacity; | ||
| ss << validate_capacity(p, new_capacity, valid_capacity); |
Contributor
There was a problem hiding this comment.
if validate_capacity return error like "statfs error", we should not proceed.
Contributor
There was a problem hiding this comment.
calling to reset_capacity() should fail
Contributor
Author
There was a problem hiding this comment.
not exactly. the operation will never fail. target capacity larger than the max disk capacity will be regulated to max disk capacity.
gavinchou
reviewed
Jun 13, 2025
| if (auto iter = _path_to_cache.find(path); iter != _path_to_cache.end()) { | ||
| return iter->second->reset_capacity(new_capacity); | ||
| int64_t valid_capacity; | ||
| ss << validate_capacity(path, new_capacity, valid_capacity); |
Contributor
Author
There was a problem hiding this comment.
explained above
gavinchou
reviewed
Jun 13, 2025
TPC-H: Total hot run time: 34902 ms |
TPC-DS: Total hot run time: 197480 ms |
ClickBench: Total hot run time: 29.02 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33997 ms |
TPC-DS: Total hot run time: 186359 ms |
ClickBench: Total hot run time: 29.86 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Jun 20, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Jun 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
…validation (#51711) originall default capacity is total disk size * ratio we user set zero or extrem large space than acutal disk. I found the ratio part make no sense. we just use total disk size in this case. I alse add validation for reset_capacity http action rather than set the raw capacity. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…validation (#51711) originall default capacity is total disk size * ratio we user set zero or extrem large space than acutal disk. I found the ratio part make no sense. we just use total disk size in this case. I alse add validation for reset_capacity http action rather than set the raw capacity. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originall default capacity is total disk size * ratio we user set zero or extrem large space than acutal disk. I found the ratio part make no sense. we just use total disk size in this case.
I alse add validation for reset_capacity http action rather than set the raw capacity.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)