Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jun 16, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

when compcation for mow table with sequence column, if the output rowset version is [start_version, end_version], it may generate delete bitmap between [start_version, end_version], this pr modify the delete bitmap checker to skip this situation

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi mymeiyi force-pushed the check-seq-delete-bitmap branch from ea7163e to 8d1f0e9 Compare July 8, 2025 06:31
@dataroaring
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 92.86% (26/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.46% (1248/1551)
Line Coverage 67.59% (21268/31464)
Region Coverage 67.11% (10556/15730)
Branch Coverage 56.61% (5536/9780)

@doris-robot
Copy link

TPC-H: Total hot run time: 32853 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d1f0e9b5480af339dd7183ffcbff1553b2ae873, data reload: false

------ Round 1 ----------------------------------
q1	17612	5217	5050	5050
q2	1925	275	185	185
q3	10330	1225	704	704
q4	10213	1006	499	499
q5	7496	2355	2285	2285
q6	174	157	128	128
q7	897	733	602	602
q8	9309	1224	1050	1050
q9	6766	5024	5079	5024
q10	6881	2359	1957	1957
q11	483	285	280	280
q12	341	345	212	212
q13	17773	3723	3100	3100
q14	217	220	210	210
q15	550	468	478	468
q16	419	424	372	372
q17	584	863	356	356
q18	7735	7052	6963	6963
q19	1216	924	569	569
q20	329	341	220	220
q21	3842	3128	2334	2334
q22	355	313	285	285
Total cold run time: 105447 ms
Total hot run time: 32853 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5081	5053	5247	5053
q2	237	334	224	224
q3	2168	2667	2268	2268
q4	1378	1751	1307	1307
q5	4188	4087	4471	4087
q6	210	165	125	125
q7	2027	1926	1822	1822
q8	2654	2616	2513	2513
q9	7251	7277	7183	7183
q10	3157	3288	2846	2846
q11	553	502	523	502
q12	722	789	628	628
q13	3557	3967	3406	3406
q14	272	298	275	275
q15	523	477	487	477
q16	464	508	489	489
q17	1234	1537	1381	1381
q18	7806	7629	7311	7311
q19	752	793	825	793
q20	1944	1932	1794	1794
q21	4713	4355	4257	4257
q22	614	540	530	530
Total cold run time: 51505 ms
Total hot run time: 49271 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185815 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d1f0e9b5480af339dd7183ffcbff1553b2ae873, data reload: false

query1	978	411	406	406
query2	6495	1788	1724	1724
query3	6742	211	224	211
query4	26714	23673	23086	23086
query5	4337	564	457	457
query6	300	212	203	203
query7	4636	505	292	292
query8	277	225	217	217
query9	8631	2610	2620	2610
query10	457	306	272	272
query11	15892	15192	14777	14777
query12	149	103	100	100
query13	1638	516	388	388
query14	9085	5952	5909	5909
query15	220	192	167	167
query16	7286	427	279	279
query17	1317	682	571	571
query18	1976	387	303	303
query19	183	183	151	151
query20	122	117	127	117
query21	209	120	104	104
query22	4020	4108	4154	4108
query23	33806	33164	33178	33164
query24	8469	2351	2373	2351
query25	529	475	384	384
query26	1243	297	144	144
query27	2728	493	339	339
query28	4343	2108	2078	2078
query29	742	547	451	451
query30	283	227	192	192
query31	920	873	739	739
query32	72	62	59	59
query33	545	336	274	274
query34	787	834	537	537
query35	596	657	551	551
query36	954	968	868	868
query37	114	108	76	76
query38	4180	4191	4058	4058
query39	1507	1428	1413	1413
query40	221	121	107	107
query41	62	59	59	59
query42	125	110	109	109
query43	518	523	500	500
query44	1358	859	844	844
query45	179	172	167	167
query46	860	1011	630	630
query47	1736	1764	1729	1729
query48	384	425	298	298
query49	736	472	406	406
query50	632	707	423	423
query51	4127	4151	4107	4107
query52	108	106	94	94
query53	225	248	188	188
query54	561	563	494	494
query55	87	80	82	80
query56	301	301	321	301
query57	1183	1177	1117	1117
query58	254	252	277	252
query59	2674	2685	2598	2598
query60	331	305	304	304
query61	125	120	116	116
query62	795	700	655	655
query63	221	180	190	180
query64	4368	1153	982	982
query65	4254	4168	4177	4168
query66	1146	420	334	334
query67	15709	15808	15260	15260
query68	7859	889	529	529
query69	512	314	274	274
query70	1229	1142	1140	1140
query71	419	321	306	306
query72	5643	4638	4800	4638
query73	641	615	350	350
query74	9074	9133	8967	8967
query75	3488	3286	2751	2751
query76	3388	1140	721	721
query77	770	389	293	293
query78	10754	11178	10254	10254
query79	2041	821	583	583
query80	599	508	444	444
query81	463	260	224	224
query82	423	122	99	99
query83	299	251	236	236
query84	235	117	82	82
query85	810	376	314	314
query86	330	297	270	270
query87	4421	4443	4295	4295
query88	3551	2291	2290	2290
query89	383	327	281	281
query90	1935	207	211	207
query91	136	137	107	107
query92	80	56	56	56
query93	1474	945	592	592
query94	688	314	205	205
query95	371	288	289	288
query96	477	569	281	281
query97	2665	2733	2634	2634
query98	240	211	202	202
query99	1533	1368	1270	1270
Total cold run time: 273693 ms
Total hot run time: 185815 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.45 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d1f0e9b5480af339dd7183ffcbff1553b2ae873, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.61	0.12	0.11
query5	0.43	0.44	0.43
query6	1.17	0.67	0.67
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.61	0.51	0.53
query10	0.57	0.57	0.57
query11	0.15	0.11	0.12
query12	0.15	0.12	0.11
query13	0.63	0.61	0.62
query14	0.79	0.83	0.84
query15	0.92	0.88	0.89
query16	0.39	0.39	0.39
query17	1.06	1.08	1.07
query18	0.23	0.22	0.21
query19	1.94	1.88	1.86
query20	0.02	0.01	0.02
query21	15.39	0.91	0.55
query22	0.74	1.15	0.80
query23	14.84	1.39	0.63
query24	6.70	2.12	0.39
query25	0.35	0.25	0.08
query26	0.72	0.18	0.13
query27	0.05	0.05	0.05
query28	9.30	0.90	0.46
query29	12.68	4.05	3.33
query30	0.25	0.08	0.07
query31	2.84	0.58	0.40
query32	3.25	0.57	0.48
query33	3.04	3.08	3.26
query34	16.10	5.38	4.78
query35	4.80	4.85	4.90
query36	0.71	0.51	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.37 s
Total hot run time: 29.45 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.01% (15504/27194)
Line Coverage 45.86% (138288/301517)
Region Coverage 35.30% (103355/292783)
Branch Coverage 37.77% (45498/120450)

@mymeiyi mymeiyi force-pushed the check-seq-delete-bitmap branch from 8d1f0e9 to 1ce2c49 Compare July 11, 2025 03:55
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 11, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.07% (1268/1545)
Line Coverage 67.77% (21614/31894)
Region Coverage 67.42% (10738/15928)
Branch Coverage 56.93% (5658/9938)

@doris-robot
Copy link

TPC-H: Total hot run time: 33417 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ce2c49409555c5f2b1bcb49c0119c1232b857c4, data reload: false

------ Round 1 ----------------------------------
q1	17612	5229	5115	5115
q2	1923	294	183	183
q3	10351	1336	717	717
q4	10293	1002	541	541
q5	8499	2433	2314	2314
q6	189	157	128	128
q7	923	747	601	601
q8	9323	1309	1086	1086
q9	6963	5174	5148	5148
q10	6885	2406	1998	1998
q11	477	281	272	272
q12	334	344	211	211
q13	17774	3668	3085	3085
q14	223	228	213	213
q15	548	476	476	476
q16	459	418	367	367
q17	623	893	354	354
q18	7669	7268	7171	7171
q19	1282	942	548	548
q20	339	337	216	216
q21	3994	2632	2366	2366
q22	360	320	307	307
Total cold run time: 107043 ms
Total hot run time: 33417 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5076	5131	5081	5081
q2	227	319	215	215
q3	2169	2671	2348	2348
q4	1367	1791	1333	1333
q5	4254	4354	4538	4354
q6	209	159	120	120
q7	2020	1956	1858	1858
q8	2625	2602	2472	2472
q9	7423	7369	7363	7363
q10	3122	3249	2884	2884
q11	582	551	493	493
q12	740	820	756	756
q13	3665	3963	3327	3327
q14	292	316	289	289
q15	511	473	521	473
q16	446	510	464	464
q17	1208	1544	1383	1383
q18	8018	7671	7152	7152
q19	776	789	933	789
q20	1933	1977	1820	1820
q21	4656	4288	4337	4288
q22	676	546	547	546
Total cold run time: 51995 ms
Total hot run time: 49808 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184938 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ce2c49409555c5f2b1bcb49c0119c1232b857c4, data reload: false

query1	1013	371	379	371
query2	6505	1801	1733	1733
query3	6744	223	221	221
query4	26206	23188	23388	23188
query5	4346	560	419	419
query6	288	195	199	195
query7	4629	489	282	282
query8	252	209	214	209
query9	8638	2613	2617	2613
query10	470	332	278	278
query11	15302	15105	14798	14798
query12	151	110	109	109
query13	1656	522	392	392
query14	9155	6079	6065	6065
query15	214	180	174	174
query16	7711	444	266	266
query17	1455	738	593	593
query18	2016	414	312	312
query19	199	191	164	164
query20	118	118	119	118
query21	215	135	117	117
query22	3995	4182	3989	3989
query23	34054	33103	33221	33103
query24	8481	2354	2336	2336
query25	509	469	379	379
query26	1222	265	145	145
query27	2715	498	336	336
query28	4354	2121	2150	2121
query29	724	557	445	445
query30	284	229	190	190
query31	915	838	747	747
query32	76	63	61	61
query33	549	364	295	295
query34	784	822	518	518
query35	596	624	549	549
query36	925	965	907	907
query37	112	96	84	84
query38	4143	4157	4126	4126
query39	1504	1436	1441	1436
query40	206	117	106	106
query41	55	66	51	51
query42	128	111	108	108
query43	508	496	495	495
query44	1295	822	824	822
query45	176	169	171	169
query46	842	1021	616	616
query47	1763	1801	1722	1722
query48	378	409	304	304
query49	743	477	375	375
query50	628	699	406	406
query51	5531	5532	5460	5460
query52	112	107	99	99
query53	223	246	191	191
query54	568	573	499	499
query55	86	80	80	80
query56	287	288	290	288
query57	1164	1202	1172	1172
query58	257	249	252	249
query59	2693	2751	2610	2610
query60	322	319	299	299
query61	124	122	158	122
query62	791	716	671	671
query63	227	186	185	185
query64	4375	1126	807	807
query65	4276	4163	4188	4163
query66	1062	417	312	312
query67	15663	15680	15438	15438
query68	8150	871	531	531
query69	497	312	274	274
query70	1199	1142	1124	1124
query71	473	307	317	307
query72	5695	4775	2370	2370
query73	705	709	352	352
query74	8799	8847	8994	8847
query75	3764	3174	2683	2683
query76	3612	1137	719	719
query77	775	391	293	293
query78	11064	11247	10348	10348
query79	2842	813	587	587
query80	646	501	439	439
query81	478	257	221	221
query82	468	127	95	95
query83	280	245	243	243
query84	300	108	84	84
query85	782	363	316	316
query86	392	290	277	277
query87	4350	4474	4257	4257
query88	3418	2270	2277	2270
query89	385	321	298	298
query90	1843	212	210	210
query91	139	144	109	109
query92	67	58	60	58
query93	1958	944	592	592
query94	679	328	196	196
query95	374	289	283	283
query96	486	582	282	282
query97	2726	2751	2629	2629
query98	230	202	198	198
query99	1448	1409	1243	1243
Total cold run time: 276732 ms
Total hot run time: 184938 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1ce2c49409555c5f2b1bcb49c0119c1232b857c4, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.25	0.08	0.09
query4	1.61	0.10	0.11
query5	0.45	0.41	0.43
query6	1.15	0.68	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.52	0.53
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	0.79	0.80	0.84
query15	0.89	0.88	0.88
query16	0.39	0.39	0.41
query17	1.07	1.07	1.09
query18	0.22	0.21	0.21
query19	1.91	1.91	1.86
query20	0.01	0.02	0.01
query21	15.39	0.90	0.54
query22	0.76	1.25	0.77
query23	14.77	1.37	0.65
query24	7.19	1.26	0.27
query25	0.29	0.13	0.22
query26	0.50	0.17	0.13
query27	0.06	0.05	0.05
query28	9.38	0.94	0.44
query29	12.54	4.08	3.42
query30	0.26	0.09	0.06
query31	2.83	0.59	0.39
query32	3.25	0.55	0.48
query33	3.15	3.05	3.09
query34	16.06	5.36	4.73
query35	4.80	4.84	4.80
query36	0.70	0.51	0.49
query37	0.09	0.07	0.07
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.46 s
Total hot run time: 29.25 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.13% (15525/27175)
Line Coverage 45.96% (138666/301724)
Region Coverage 35.37% (103734/293316)
Branch Coverage 37.86% (45704/120728)

@dataroaring dataroaring force-pushed the check-seq-delete-bitmap branch from 1ce2c49 to 40c98c7 Compare July 14, 2025 10:00
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.71% (1269/1592)
Line Coverage 65.56% (21421/32674)
Region Coverage 66.98% (10800/16125)
Branch Coverage 56.65% (5694/10052)

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.65% (15694/27223)
Line Coverage 46.34% (139986/302074)
Region Coverage 35.58% (104507/293692)
Branch Coverage 38.15% (46087/120802)

@doris-robot
Copy link

TPC-H: Total hot run time: 33247 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40c98c7521bb462532be884c29281c84fa454e1d, data reload: false

------ Round 1 ----------------------------------
q1	17552	5262	5050	5050
q2	1925	276	197	197
q3	10362	1314	732	732
q4	10247	1025	514	514
q5	7979	2431	2344	2344
q6	184	170	134	134
q7	936	732	598	598
q8	9326	1376	1063	1063
q9	6948	5149	5174	5149
q10	6900	2400	1981	1981
q11	492	289	274	274
q12	347	352	216	216
q13	17754	3699	3038	3038
q14	232	222	220	220
q15	550	487	487	487
q16	418	443	367	367
q17	607	885	353	353
q18	7632	7253	7085	7085
q19	1212	966	560	560
q20	346	340	220	220
q21	3879	3164	2352	2352
q22	357	325	313	313
Total cold run time: 106185 ms
Total hot run time: 33247 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5103	5089	5093	5089
q2	237	317	215	215
q3	2183	2657	2300	2300
q4	1388	1751	1312	1312
q5	4231	4243	4514	4243
q6	220	173	126	126
q7	2059	1992	1741	1741
q8	2772	2690	2558	2558
q9	7200	7254	7215	7215
q10	3120	3254	2883	2883
q11	590	519	539	519
q12	679	789	667	667
q13	3548	3891	3287	3287
q14	282	298	273	273
q15	537	488	468	468
q16	447	493	438	438
q17	1178	1648	1365	1365
q18	7904	7912	7503	7503
q19	800	860	935	860
q20	2211	2029	1924	1924
q21	4994	4376	4293	4293
q22	634	574	544	544
Total cold run time: 52317 ms
Total hot run time: 49823 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187291 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 40c98c7521bb462532be884c29281c84fa454e1d, data reload: false

query1	1013	398	423	398
query2	6543	1642	1684	1642
query3	6744	207	212	207
query4	26151	23766	23394	23394
query5	4363	582	436	436
query6	300	212	204	204
query7	4623	501	288	288
query8	282	217	222	217
query9	8592	2584	2582	2582
query10	463	311	265	265
query11	16133	15173	14795	14795
query12	147	104	103	103
query13	1636	517	392	392
query14	8790	5884	5991	5884
query15	210	196	166	166
query16	7203	436	271	271
query17	1324	734	593	593
query18	1981	399	314	314
query19	206	197	162	162
query20	119	125	118	118
query21	216	126	110	110
query22	4132	4296	4144	4144
query23	34143	33461	33138	33138
query24	8485	2391	2376	2376
query25	570	494	427	427
query26	1245	272	146	146
query27	2761	528	341	341
query28	4323	2126	2124	2124
query29	774	580	467	467
query30	344	227	192	192
query31	942	832	754	754
query32	74	63	63	63
query33	555	322	269	269
query34	790	837	519	519
query35	608	608	556	556
query36	964	1006	939	939
query37	113	96	81	81
query38	4177	4129	4184	4129
query39	1474	1414	1603	1414
query40	209	113	102	102
query41	54	53	52	52
query42	120	114	108	108
query43	508	502	471	471
query44	1298	806	808	806
query45	174	175	163	163
query46	835	1027	621	621
query47	1779	1824	1776	1776
query48	376	403	303	303
query49	732	486	398	398
query50	635	691	410	410
query51	5475	5497	5381	5381
query52	108	102	98	98
query53	220	256	182	182
query54	573	575	506	506
query55	82	77	78	77
query56	312	282	273	273
query57	1186	1203	1135	1135
query58	259	252	260	252
query59	2642	2667	2535	2535
query60	334	332	313	313
query61	125	121	123	121
query62	801	748	649	649
query63	219	185	187	185
query64	4409	1189	802	802
query65	4270	4133	4194	4133
query66	1128	412	311	311
query67	15876	15843	15735	15735
query68	8658	871	525	525
query69	498	309	273	273
query70	1263	1076	1094	1076
query71	450	320	310	310
query72	5414	4648	4761	4648
query73	718	640	350	350
query74	9106	9238	8780	8780
query75	3999	3194	2654	2654
query76	3639	1166	720	720
query77	787	380	288	288
query78	10782	11215	10247	10247
query79	1495	825	587	587
query80	578	529	517	517
query81	452	261	216	216
query82	224	121	101	101
query83	299	248	237	237
query84	296	99	87	87
query85	750	371	313	313
query86	342	299	298	298
query87	4429	4398	4220	4220
query88	2831	2284	2226	2226
query89	386	310	290	290
query90	2054	204	199	199
query91	135	138	111	111
query92	77	59	55	55
query93	1096	947	589	589
query94	684	310	194	194
query95	373	288	276	276
query96	492	576	279	279
query97	2684	2812	2624	2624
query98	226	204	206	204
query99	1398	1410	1279	1279
Total cold run time: 274867 ms
Total hot run time: 187291 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 40c98c7521bb462532be884c29281c84fa454e1d, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.07	0.08
query4	1.64	0.10	0.10
query5	0.43	0.42	0.43
query6	1.16	0.67	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.51	0.52
query10	0.56	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.81	0.81	0.80
query15	0.90	0.88	0.86
query16	0.38	0.38	0.41
query17	1.05	1.07	1.08
query18	0.23	0.21	0.21
query19	1.96	1.82	1.86
query20	0.02	0.01	0.02
query21	15.40	0.91	0.54
query22	0.76	1.17	0.66
query23	14.94	1.39	0.61
query24	6.63	1.72	0.67
query25	0.48	0.22	0.11
query26	0.59	0.16	0.13
query27	0.07	0.06	0.04
query28	9.42	0.91	0.44
query29	12.55	3.92	3.30
query30	0.26	0.08	0.07
query31	2.85	0.59	0.39
query32	3.29	0.56	0.47
query33	3.11	3.07	3.12
query34	15.97	5.37	4.81
query35	4.82	4.83	4.79
query36	0.70	0.50	0.50
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.42 s
Total hot run time: 29.35 s

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring force-pushed the check-seq-delete-bitmap branch from 40c98c7 to bcd996e Compare July 24, 2025 12:25
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.42% (1302/1619)
Line Coverage 65.81% (21814/33147)
Region Coverage 67.09% (10961/16337)
Branch Coverage 56.72% (5778/10186)

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.55% (15935/27689)
Line Coverage 46.34% (143263/309132)
Region Coverage 35.80% (108004/301721)
Branch Coverage 38.30% (47645/124386)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.05% (22033/27183)
Line Coverage 73.70% (227504/308708)
Region Coverage 61.30% (189716/309473)
Branch Coverage 65.07% (81849/125794)

@doris-robot
Copy link

TPC-H: Total hot run time: 33791 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bcd996e5478d40d0dcf4f380a94b8d1354244048, data reload: false

------ Round 1 ----------------------------------
q1	17586	5311	5246	5246
q2	1932	305	181	181
q3	10291	1381	696	696
q4	10215	1004	537	537
q5	7507	2304	2428	2304
q6	183	169	131	131
q7	872	741	627	627
q8	9289	1303	1065	1065
q9	6632	5051	4984	4984
q10	6921	2385	1965	1965
q11	458	268	260	260
q12	345	374	229	229
q13	17792	3543	3016	3016
q14	234	239	213	213
q15	519	481	466	466
q16	430	423	364	364
q17	547	805	347	347
q18	7461	7089	7045	7045
q19	1783	981	542	542
q20	326	328	213	213
q21	2741	3010	2373	2373
q22	1027	1058	987	987
Total cold run time: 105091 ms
Total hot run time: 33791 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5422	5336	5296	5296
q2	232	306	219	219
q3	2095	2577	2169	2169
q4	1321	1744	1329	1329
q5	4106	4286	4446	4286
q6	216	181	133	133
q7	1993	1918	1816	1816
q8	2709	2649	2507	2507
q9	7331	7110	7376	7110
q10	3090	3362	2956	2956
q11	527	526	477	477
q12	696	749	642	642
q13	3347	3759	3318	3318
q14	315	316	301	301
q15	517	493	473	473
q16	489	512	445	445
q17	1192	1521	1423	1423
q18	8115	7910	8076	7910
q19	12278	1025	1036	1025
q20	3824	1997	1935	1935
q21	15211	4397	4430	4397
q22	1150	998	1004	998
Total cold run time: 76176 ms
Total hot run time: 51165 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169619 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bcd996e5478d40d0dcf4f380a94b8d1354244048, data reload: false

============================================
query1	983	385	445	385
query2	6513	1944	1667	1667
query3	6738	221	224	221
query4	27277	23308	22923	22923
query5	4365	635	510	510
query6	329	235	224	224
query7	4637	521	294	294
query8	293	228	222	222
query9	8586	2957	2916	2916
query10	486	335	283	283
query11	16002	14862	14795	14795
query12	185	139	132	132
query13	1662	550	410	410
query14	8619	5804	5811	5804
query15	225	204	164	164
query16	7156	680	454	454
query17	968	768	650	650
query18	2010	452	331	331
query19	224	214	195	195
query20	147	147	140	140
query21	226	130	107	107
query22	3993	4146	4046	4046
query23	34770	34122	34229	34122
query24	8050	2361	2424	2361
query25	572	503	442	442
query26	1118	285	157	157
query27	2709	502	349	349
query28	4370	2336	2321	2321
query29	785	591	485	485
query30	301	239	209	209
query31	881	826	713	713
query32	87	78	76	76
query33	563	446	354	354
query34	807	824	515	515
query35	848	847	780	780
query36	1095	1026	965	965
query37	131	111	96	96
query38	4001	3970	3930	3930
query39	1441	1413	1348	1348
query40	243	145	135	135
query41	66	58	52	52
query42	139	121	130	121
query43	533	520	477	477
query44	1407	872	850	850
query45	201	186	184	184
query46	944	1046	670	670
query47	1805	1832	1751	1751
query48	417	413	307	307
query49	718	495	423	423
query50	637	697	413	413
query51	4203	4261	4191	4191
query52	126	131	114	114
query53	258	291	212	212
query54	640	640	549	549
query55	92	91	87	87
query56	344	350	378	350
query57	1216	1229	1153	1153
query58	334	341	332	332
query59	2617	2611	2530	2530
query60	431	402	374	374
query61	133	127	120	120
query62	820	742	651	651
query63	247	213	212	212
query64	4241	1088	772	772
query65	4289	4079	4111	4079
query66	1126	438	333	333
query67	query68	18802	984	1011	984
query69	1099	271	303	271
query70	1403	1110	1053	1053
query71	678	326	322	322
query72	9112	2321	4778	2321
query73	4045	764	352	352
query74	9002	8752	8492	8492
query75	7231	3105	2690	2690
query76	8468	1211	777	777
query77	1287	411	330	330
query78	9556	11449	9436	9436
query79	15294	605	582	582
query80	1649	544	498	498
query81	572	260	232	232
query82	554	149	110	110
query83	372	284	272	272
query84	301	94	78	78
query85	885	362	335	335
query86	384	352	303	303
query87	4121	4132	4034	4034
query88	5452	2219	2229	2219
query89	480	351	312	312
query90	2554	233	223	223
query91	141	146	120	120
query92	88	70	67	67
query93	6632	975	671	671
query94	1128	391	282	282
query95	427	337	320	320
query96	498	582	278	278
query97	2693	2778	2617	2617
query98	274	226	231	226
query99	1434	1370	1274	1274
Total cold run time: 308996 ms
Total hot run time: 169619 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bcd996e5478d40d0dcf4f380a94b8d1354244048, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.05	0.04
query3	0.24	0.07	0.07
query4	1.64	0.11	0.11
query5	0.40	0.40	0.42
query6	1.18	0.66	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.48	0.46
query10	0.53	0.53	0.54
query11	0.16	0.10	0.11
query12	0.14	0.11	0.11
query13	0.64	0.66	0.64
query14	0.89	1.08	1.14
query15	0.90	0.86	0.88
query16	0.41	0.40	0.38
query17	1.02	1.06	1.04
query18	0.22	0.20	0.20
query19	1.92	1.81	1.90
query20	0.02	0.01	0.01
query21	15.38	0.83	0.55
query22	0.76	1.20	0.78
query23	14.83	1.19	0.66
query24	6.64	1.34	0.60
query25	0.52	0.31	0.08
query26	0.53	0.15	0.13
query27	0.06	0.06	0.05
query28	9.46	0.83	0.45
query29	12.56	3.79	3.27
query30	3.06	2.98	2.94
query31	2.84	0.56	0.39
query32	3.24	0.57	0.49
query33	3.00	3.19	3.20
query34	16.01	5.31	4.95
query35	4.87	4.98	4.97
query36	0.70	0.51	0.51
query37	0.10	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.04 s
Total hot run time: 32.93 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b0faa60 into apache:master Aug 7, 2025
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2025
…1763)

### What problem does this PR solve?

when compcation for mow table with sequence column, if the output rowset
version is [start_version, end_version], it may generate delete bitmap
between [start_version, end_version], this pr modify the delete bitmap
checker to skip this situation
morrySnow pushed a commit that referenced this pull request Aug 7, 2025
…q column #51763 (#54417)

Cherry-picked from #51763

Co-authored-by: meiyi <meiyi@selectdb.com>
freemandealer pushed a commit to freemandealer/doris that referenced this pull request Aug 7, 2025
…ache#51763)

### What problem does this PR solve?

when compcation for mow table with sequence column, if the output rowset
version is [start_version, end_version], it may generate delete bitmap
between [start_version, end_version], this pr modify the delete bitmap
checker to skip this situation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants