-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[optimization](filecache) speed up filecache warm up #51776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 34199 ms |
TPC-DS: Total hot run time: 193271 ms |
ClickBench: Total hot run time: 29.78 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 35140 ms |
TPC-DS: Total hot run time: 189771 ms |
ClickBench: Total hot run time: 29.6 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
df25e35 to
838c1ef
Compare
|
run buildall |
TPC-H: Total hot run time: 33906 ms |
TPC-DS: Total hot run time: 189082 ms |
ClickBench: Total hot run time: 29.05 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pick apache#51776 pick apache#51776 pick apache#51776 this pr does the following: make file cache downloader worker pool thread num configurable make warm up job split batch size configurable split large file downloading task to smaller ones to maintain load balance between threads, thus improve concurrency use meta info to deduce size of inverted idx file size to reduce S3 HEAD ops some log print optimization in our test, this opt can improve more than 3x file cache warm up performance Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
pick #51776 pick #51776 pick #51776 this pr does the following: make file cache downloader worker pool thread num configurable make warm up job split batch size configurable split large file downloading task to smaller ones to maintain load balance between threads, thus improve concurrency use meta info to deduce size of inverted idx file size to reduce S3 HEAD ops some log print optimization in our test, this opt can improve more than 3x file cache warm up performance Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
pick apache#51776 pick apache#51776 pick apache#51776 this pr does the following: make file cache downloader worker pool thread num configurable make warm up job split batch size configurable split large file downloading task to smaller ones to maintain load balance between threads, thus improve concurrency use meta info to deduce size of inverted idx file size to reduce S3 HEAD ops some log print optimization in our test, this opt can improve more than 3x file cache warm up performance Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
…ache#52556) pick apache#51776 pick apache#51776 pick apache#51776 this pr does the following: make file cache downloader worker pool thread num configurable make warm up job split batch size configurable split large file downloading task to smaller ones to maintain load balance between threads, thus improve concurrency use meta info to deduce size of inverted idx file size to reduce S3 HEAD ops some log print optimization in our test, this opt can improve more than 3x file cache warm up performance Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
…he#51776 (apache#52626) Cherry-picked from apache#51776 Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
this pr does the following:
in our test, this opt can improve more than 3x file cache warm up performance
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)