Skip to content

branch-3.0: [Bug](function) fix wrong result of hll_to_base64 #51831 #51849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jun 18, 2025
Merged

branch-3.0: [Bug](function) fix wrong result of hll_to_base64 #51831 #51849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/vec/functions/function_hll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ struct HllToBase64 {
last_ser_size = cur_ser_size;
ser_buff.resize(cur_ser_size);
}
hll_val.serialize(reinterpret_cast<uint8_t*>(ser_buff.data()));
auto outlen = base64_encode((const unsigned char*)ser_buff.data(), cur_ser_size,
size_t real_size = hll_val.serialize(reinterpret_cast<uint8_t*>(ser_buff.data()));
auto outlen = base64_encode((const unsigned char*)ser_buff.data(), real_size,
chars_data + encoded_offset);
DCHECK(outlen > 0);

Expand Down
3 changes: 3 additions & 0 deletions regression-test/data/load_p0/http_stream/test_http_stream_compress.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,3 +2504,6 @@
-- !sql2 --
1 2 1025 1028

-- !test --
1028

1 change: 1 addition & 0 deletions regression-test/suites/load_p0/http_stream/test_http_stream_compress.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ suite("test_http_stream_compress", "p0") {
}
sql "sync"
qt_sql2 "select k1, k2, bitmap_union_count(v1), HLL_UNION_AGG(v2) from ${tableName2} group by k1, k2 order by k1"
qt_test "select HLL_CARDINALITY(hll_from_base64(hll_to_base64(v2))) from test_http_stream_bz4;"
} finally {
try_sq2 "DROP TABLE IF EXISTS ${tableName2}"
}
Expand Down
Loading