Skip to content

Conversation

@zhangstar333
Copy link
Contributor

Problem Summary:
cherry-pick from master #51293

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…pache#51293)

when pattern is empty, it's should split all alone , not return error
msg
`mysql> select id,name,score, k,v from table_test lateral view
posexplode(split_by_regexp(name,'')) tmp as k,v order by id;
ERROR 1105 (HY000): errCode = 2, detailMessage =
(10.16.10.2)[RUNTIME_ERROR]Invalid pattern:`
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39689 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73e88e505b06b5d793b957ecfb6037a8911733b3, data reload: false

------ Round 1 ----------------------------------
q1	17578	6776	6520	6520
q2	2059	177	172	172
q3	10824	1061	1147	1061
q4	10565	762	775	762
q5	7721	2829	2876	2829
q6	210	129	130	129
q7	960	616	612	612
q8	9352	1980	2011	1980
q9	6501	6336	6375	6336
q10	7014	2236	2303	2236
q11	463	274	261	261
q12	402	215	210	210
q13	17797	2995	3017	2995
q14	235	201	221	201
q15	504	466	461	461
q16	511	390	385	385
q17	976	674	625	625
q18	7378	6731	6598	6598
q19	1383	1042	1101	1042
q20	501	204	198	198
q21	3928	3096	3178	3096
q22	1077	1012	980	980
Total cold run time: 107939 ms
Total hot run time: 39689 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6542	6512	6477	6477
q2	325	236	239	236
q3	2890	2742	2759	2742
q4	2015	1760	1792	1760
q5	5795	5753	5734	5734
q6	207	129	126	126
q7	2184	1780	1774	1774
q8	3360	3553	3522	3522
q9	8965	8815	9155	8815
q10	3627	3559	3560	3559
q11	589	504	513	504
q12	817	629	611	611
q13	8345	3149	3193	3149
q14	290	263	259	259
q15	515	453	450	450
q16	481	433	446	433
q17	1815	1641	1598	1598
q18	8341	7756	7733	7733
q19	1674	1679	1522	1522
q20	2152	1827	1803	1803
q21	5069	5035	5053	5035
q22	1081	1011	1053	1011
Total cold run time: 67079 ms
Total hot run time: 58853 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195626 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73e88e505b06b5d793b957ecfb6037a8911733b3, data reload: false

query1	1289	879	904	879
query2	6389	1864	1829	1829
query3	10804	4298	4195	4195
query4	62056	28855	23459	23459
query5	5209	473	476	473
query6	409	184	177	177
query7	5450	320	306	306
query8	310	224	228	224
query9	8304	2535	2544	2535
query10	454	263	258	258
query11	17565	15102	15655	15102
query12	162	100	111	100
query13	1412	449	419	419
query14	10831	6620	7203	6620
query15	190	184	176	176
query16	7114	489	455	455
query17	1129	580	593	580
query18	1864	334	318	318
query19	211	162	152	152
query20	119	113	113	113
query21	208	104	109	104
query22	4675	4411	4701	4411
query23	34899	34278	34076	34076
query24	6247	2931	3004	2931
query25	549	421	473	421
query26	653	169	179	169
query27	1940	356	352	352
query28	4072	2098	2096	2096
query29	708	449	429	429
query30	231	152	151	151
query31	988	805	812	805
query32	62	62	56	56
query33	403	292	292	292
query34	920	503	523	503
query35	825	738	733	733
query36	1081	926	909	909
query37	110	65	70	65
query38	4120	3949	3917	3917
query39	1583	1451	1468	1451
query40	194	100	100	100
query41	50	47	60	47
query42	116	102	104	102
query43	521	460	480	460
query44	1166	804	829	804
query45	197	166	172	166
query46	1167	728	718	718
query47	2018	1935	1955	1935
query48	466	376	407	376
query49	729	416	388	388
query50	833	424	420	420
query51	7425	7141	7340	7141
query52	101	86	89	86
query53	262	185	184	184
query54	576	441	456	441
query55	79	74	75	74
query56	256	251	236	236
query57	1315	1240	1210	1210
query58	221	203	215	203
query59	3217	3046	2843	2843
query60	286	254	256	254
query61	116	110	113	110
query62	793	669	689	669
query63	216	193	191	191
query64	1819	655	627	627
query65	3238	3184	3152	3152
query66	708	293	295	293
query67	16262	15739	15527	15527
query68	4090	588	567	567
query69	427	260	277	260
query70	1198	1127	1116	1116
query71	342	268	252	252
query72	6368	4024	4002	4002
query73	752	342	358	342
query74	10666	9214	9218	9214
query75	3372	2649	2671	2649
query76	2025	1006	1186	1006
query77	471	282	268	268
query78	10594	9676	9583	9583
query79	2443	607	593	593
query80	1150	414	417	414
query81	515	225	216	216
query82	328	90	87	87
query83	177	144	142	142
query84	282	84	77	77
query85	1007	313	298	298
query86	377	306	289	289
query87	4405	4261	4299	4261
query88	4536	2352	2339	2339
query89	414	289	301	289
query90	1986	183	185	183
query91	182	146	147	146
query92	66	48	49	48
query93	2332	551	550	550
query94	806	294	291	291
query95	359	256	258	256
query96	625	278	278	278
query97	3310	3140	3161	3140
query98	222	215	210	210
query99	1593	1296	1262	1262
Total cold run time: 317312 ms
Total hot run time: 195626 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.01 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 73e88e505b06b5d793b957ecfb6037a8911733b3, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.06
query4	1.62	0.11	0.11
query5	0.53	0.49	0.52
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.50	0.51
query10	0.56	0.55	0.57
query11	0.15	0.11	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	0.77	0.79	0.80
query15	0.84	0.83	0.82
query16	0.39	0.38	0.37
query17	1.09	0.98	1.05
query18	0.24	0.21	0.21
query19	1.92	1.84	1.87
query20	0.01	0.02	0.01
query21	15.40	0.58	0.59
query22	3.37	2.33	1.07
query23	17.23	0.98	0.83
query24	3.27	0.64	1.19
query25	0.18	0.14	0.06
query26	0.47	0.13	0.14
query27	0.04	0.04	0.05
query28	10.43	0.54	0.46
query29	12.60	3.24	3.22
query30	0.24	0.06	0.06
query31	2.87	0.38	0.37
query32	3.26	0.47	0.46
query33	2.96	2.99	3.03
query34	17.07	4.47	4.47
query35	4.53	4.48	4.50
query36	0.68	0.49	0.51
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.03	0.03	0.04
Total cold run time: 106.05 s
Total hot run time: 29.01 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10901/26487)
Line Coverage 31.98% (93260/291657)
Region Coverage 31.05% (48092/154880)
Branch Coverage 27.52% (24634/89518)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 945f776 into apache:branch-3.0 Jun 19, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants