-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](compaction) Prune rows with delete sign=1 in full compaction #51874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Opt](compaction) Prune rows with delete sign=1 in full compaction #51874
Conversation
…_when_base_compaction==false
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33752 ms |
TPC-DS: Total hot run time: 186119 ms |
ClickBench: Total hot run time: 29.9 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33995 ms |
TPC-DS: Total hot run time: 192734 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run performance |
1 similar comment
|
run performance |
|
run vault_p0 |
TPC-H: Total hot run time: 34026 ms |
TPC-DS: Total hot run time: 186443 ms |
ClickBench: Total hot run time: 29.88 s |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…51874) ### What problem does this PR solve? 1. Prune rows with delete sign=1 in full compaction 2. also check duplicate key in base compaction when `enable_prune_delete_sign_when_base_compaction=false`
…51874) ### What problem does this PR solve? 1. Prune rows with delete sign=1 in full compaction 2. also check duplicate key in base compaction when `enable_prune_delete_sign_when_base_compaction=false`
…51874) ### What problem does this PR solve? 1. Prune rows with delete sign=1 in full compaction 2. also check duplicate key in base compaction when `enable_prune_delete_sign_when_base_compaction=false`
…ompaction apache#51874 (apache#52256) Cherry-picked from apache#51874 Co-authored-by: bobhan1 <baohan@selectdb.com>
What problem does this PR solve?
enable_prune_delete_sign_when_base_compaction=falseRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)