Skip to content

[bugfix](memleak) fix memory leak for tabletschema and result cache #51931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 19, 2025
Merged

[bugfix](memleak) fix memory leak for tabletschema and result cache #51931

yiguolei merged 1 commit into from
Jun 19, 2025

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Jun 19, 2025 •
edited
Loading

What problem does this PR solve?

pick #51786

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

yiguolei commented Jun 19, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 19, 2025

BE UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.05% (10335/26468)
Line Coverage 30.04% (85838/285748)
Region Coverage 28.71% (44297/154297)
Branch Coverage 25.43% (22670/89136)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 19, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 46.08% (12014/26073)
Line Coverage 36.68% (104148/283922)
Region Coverage 33.63% (60395/179597)
Branch Coverage 29.01% (29231/100774)

HappenLee
HappenLee approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit aa562b3 into apache:branch-2.1 Jun 19, 2025
22 of 24 checks passed
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Jun 19, 2025
@yiguolei
[bugfix](memleak) fix memory leak for tabletschema and result cache (a…
b3a1c06 
…pache#51931)

pick apache#51786

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
dataroaring pushed a commit that referenced this pull request Jun 20, 2025
@yiguolei
[bugfix](memleak) fix memory leak for tabletschema and result cache (#…
e757432 
…51931) (#51952)

pick #51786
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Jun 20, 2025
@yiguolei
[bugfix](memleak) fix memory leak for tabletschema and result cache (a…
515f695 
…pache#51931) (apache#51952)

pick apache#51786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@jacktengg jacktengg jacktengg approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yiguolei @Thearas @hello-stephen @HappenLee @jacktengg @Gabriel39