Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #49954

#49954)

### What problem does this PR solve?

will cast string to double

### Release note

aggregate function sum and avg support string type as parameter
@github-actions github-actions bot requested a review from morrySnow as a code owner June 19, 2025 12:08
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 19, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39672 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91290c4fa19db3f0004df65fc1952f2d4c48d181, data reload: false

------ Round 1 ----------------------------------
q1	17580	6725	6603	6603
q2	2052	165	188	165
q3	10661	1067	1243	1067
q4	10541	742	777	742
q5	7754	2825	2780	2780
q6	215	132	130	130
q7	958	604	601	601
q8	9354	1973	2021	1973
q9	6608	6400	6396	6396
q10	7024	2272	2319	2272
q11	462	294	257	257
q12	392	222	217	217
q13	17812	2991	3016	2991
q14	231	216	208	208
q15	529	457	474	457
q16	499	386	382	382
q17	979	556	554	554
q18	7252	6752	6523	6523
q19	1373	1155	1058	1058
q20	472	206	204	204
q21	3884	3093	3164	3093
q22	1119	1001	999	999
Total cold run time: 107751 ms
Total hot run time: 39672 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6593	6556	7174	6556
q2	322	231	229	229
q3	2892	2725	2813	2725
q4	2034	1730	1810	1730
q5	5729	5683	5752	5683
q6	214	130	128	128
q7	2229	1800	1781	1781
q8	3354	3557	3513	3513
q9	8922	8709	8895	8709
q10	3575	3513	3583	3513
q11	580	503	475	475
q12	843	574	608	574
q13	10712	3163	3216	3163
q14	294	268	272	268
q15	517	462	466	462
q16	476	443	433	433
q17	1851	1642	1608	1608
q18	8156	7841	7741	7741
q19	1718	1620	1596	1596
q20	2119	1844	1824	1824
q21	5184	4990	4917	4917
q22	1161	1055	1075	1055
Total cold run time: 69475 ms
Total hot run time: 58683 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198488 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91290c4fa19db3f0004df65fc1952f2d4c48d181, data reload: false

query1	1315	900	934	900
query2	6350	1935	1885	1885
query3	10932	4470	4413	4413
query4	62280	29550	23582	23582
query5	5153	486	518	486
query6	411	185	190	185
query7	5529	329	328	328
query8	339	254	254	254
query9	8877	2650	2718	2650
query10	471	291	281	281
query11	17665	15166	15733	15166
query12	166	108	115	108
query13	1489	477	467	467
query14	11122	7096	7220	7096
query15	199	195	180	180
query16	7142	550	507	507
query17	1163	601	630	601
query18	1876	337	334	334
query19	215	171	168	168
query20	117	112	108	108
query21	209	105	105	105
query22	4706	4476	4520	4476
query23	34457	34437	33849	33849
query24	6247	3012	3018	3012
query25	568	429	432	429
query26	655	176	179	176
query27	1754	364	363	363
query28	4447	2214	2138	2138
query29	738	483	494	483
query30	251	164	161	161
query31	983	817	818	817
query32	76	60	67	60
query33	433	307	315	307
query34	930	553	541	541
query35	858	733	749	733
query36	1103	963	960	960
query37	113	68	68	68
query38	4025	3993	3933	3933
query39	1516	1515	1479	1479
query40	215	107	108	107
query41	55	56	52	52
query42	120	104	105	104
query43	547	498	472	472
query44	1192	807	838	807
query45	193	176	178	176
query46	1163	766	740	740
query47	2002	1924	1915	1915
query48	496	405	421	405
query49	760	435	439	435
query50	831	439	430	430
query51	7395	7374	7317	7317
query52	106	92	92	92
query53	284	195	193	193
query54	592	487	479	479
query55	82	84	81	81
query56	291	283	279	279
query57	1294	1196	1212	1196
query58	259	229	230	229
query59	3178	3047	3034	3034
query60	295	277	290	277
query61	139	132	130	130
query62	790	665	692	665
query63	216	197	190	190
query64	1524	818	762	762
query65	3279	3225	3196	3196
query66	722	319	325	319
query67	15775	15691	15588	15588
query68	3821	607	579	579
query69	447	283	287	283
query70	1169	1125	1104	1104
query71	364	275	281	275
query72	6674	4284	4261	4261
query73	767	352	357	352
query74	10257	8967	8999	8967
query75	3415	2643	2715	2643
query76	1919	1031	1198	1031
query77	548	285	282	282
query78	10464	9704	9569	9569
query79	1376	613	600	600
query80	874	468	459	459
query81	499	224	225	224
query82	1291	94	91	91
query83	257	161	158	158
query84	283	90	91	90
query85	924	368	358	358
query86	337	301	306	301
query87	4400	4244	4234	4234
query88	3647	2474	2425	2425
query89	417	302	300	300
query90	2012	193	194	193
query91	196	169	188	169
query92	73	54	55	54
query93	1285	552	553	552
query94	777	306	299	299
query95	370	273	269	269
query96	607	283	289	283
query97	3308	3158	3150	3150
query98	211	201	196	196
query99	1532	1278	1289	1278
Total cold run time: 315196 ms
Total hot run time: 198488 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91290c4fa19db3f0004df65fc1952f2d4c48d181, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.11
query5	0.52	0.50	0.50
query6	1.14	0.73	0.75
query7	0.02	0.01	0.01
query8	0.06	0.03	0.03
query9	0.56	0.49	0.49
query10	0.55	0.54	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.59	0.59
query14	0.78	0.80	0.81
query15	0.85	0.83	0.83
query16	0.41	0.38	0.40
query17	1.03	1.05	1.05
query18	0.24	0.22	0.23
query19	1.88	1.87	1.83
query20	0.01	0.01	0.01
query21	15.42	0.58	0.55
query22	2.14	2.35	2.02
query23	17.00	0.97	0.78
query24	3.09	1.73	0.95
query25	0.23	0.11	0.06
query26	0.49	0.15	0.14
query27	0.04	0.04	0.04
query28	9.84	0.50	0.46
query29	12.57	3.25	3.27
query30	0.24	0.07	0.06
query31	2.84	0.38	0.37
query32	3.26	0.46	0.45
query33	3.00	2.99	3.02
query34	17.11	4.47	4.58
query35	4.55	4.60	4.53
query36	0.67	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.09	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.88 s
Total hot run time: 30.35 s

@morrySnow morrySnow merged commit e29aeb5 into branch-3.1 Jun 20, 2025
22 of 25 checks passed
@morrySnow morrySnow deleted the auto-pick-49954-branch-3.1 branch June 20, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants