Skip to content

Conversation

@zhangstar333
Copy link
Contributor

Problem Summary:
pick from (#49381)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…arams (apache#49381)

support lead/lag function could input column
eg: lead(col,1,col)/lag(col,1,col)
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40040 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01b59066e7582f5d657bbbe4cb8fe22a8b66df58, data reload: false

------ Round 1 ----------------------------------
q1	17567	6857	6616	6616
q2	2071	167	158	158
q3	10569	1186	1092	1092
q4	10955	819	731	731
q5	8132	2956	2953	2953
q6	225	136	134	134
q7	979	628	600	600
q8	9491	1978	2056	1978
q9	6701	6480	6456	6456
q10	6997	2298	2275	2275
q11	460	265	256	256
q12	390	210	207	207
q13	17796	2973	2980	2973
q14	248	206	211	206
q15	505	474	459	459
q16	493	381	365	365
q17	996	566	561	561
q18	7341	6682	6744	6682
q19	1393	1088	1154	1088
q20	478	197	206	197
q21	3916	3138	3063	3063
q22	1095	990	992	990
Total cold run time: 108798 ms
Total hot run time: 40040 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6629	6738	6625	6625
q2	334	232	233	232
q3	2917	2785	2988	2785
q4	2103	1811	1765	1765
q5	5711	5797	5777	5777
q6	203	124	125	124
q7	2201	1730	1746	1730
q8	3395	3534	3526	3526
q9	8949	8965	8942	8942
q10	3613	3582	3520	3520
q11	610	496	487	487
q12	805	585	626	585
q13	7681	3159	3167	3159
q14	291	266	287	266
q15	503	473	463	463
q16	479	453	435	435
q17	1861	1605	1612	1605
q18	8228	7696	7640	7640
q19	1731	1705	1654	1654
q20	2089	1811	1886	1811
q21	5208	4897	4997	4897
q22	1138	1035	1040	1035
Total cold run time: 66679 ms
Total hot run time: 59063 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190202 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01b59066e7582f5d657bbbe4cb8fe22a8b66df58, data reload: false

query1	946	366	373	366
query2	6513	1932	1833	1833
query3	6708	216	214	214
query4	33989	23885	23682	23682
query5	4417	457	435	435
query6	284	183	192	183
query7	4623	319	310	310
query8	288	221	231	221
query9	9388	2560	2528	2528
query10	488	265	268	265
query11	18111	15292	15164	15164
query12	153	104	103	103
query13	1644	428	414	414
query14	9762	7377	7151	7151
query15	258	171	178	171
query16	8133	459	474	459
query17	1612	575	565	565
query18	2174	314	319	314
query19	381	152	154	152
query20	117	109	112	109
query21	204	104	105	104
query22	4479	4193	4280	4193
query23	33925	33319	33376	33319
query24	11286	2769	2830	2769
query25	692	417	408	408
query26	1440	168	168	168
query27	2859	350	355	350
query28	7766	2100	2109	2100
query29	895	465	451	451
query30	316	160	162	160
query31	1010	796	822	796
query32	100	60	60	60
query33	800	305	321	305
query34	918	500	517	500
query35	864	721	712	712
query36	1109	943	916	916
query37	126	69	72	69
query38	3876	3896	3810	3810
query39	1473	1410	1435	1410
query40	295	105	105	105
query41	54	51	52	51
query42	119	101	102	101
query43	514	461	467	461
query44	1246	803	788	788
query45	187	170	171	170
query46	1148	724	696	696
query47	1907	1837	1810	1810
query48	467	382	380	380
query49	1207	407	396	396
query50	824	415	404	404
query51	7277	7210	7103	7103
query52	105	94	93	93
query53	257	188	184	184
query54	1296	466	463	463
query55	79	82	82	82
query56	281	288	237	237
query57	1289	1164	1149	1149
query58	230	205	211	205
query59	3082	2857	2855	2855
query60	281	271	257	257
query61	125	113	125	113
query62	884	664	663	663
query63	222	189	193	189
query64	5295	659	656	656
query65	3298	3187	3187	3187
query66	1447	304	312	304
query67	15866	15696	15575	15575
query68	5070	601	578	578
query69	438	264	299	264
query70	1113	1050	1082	1050
query71	347	253	252	252
query72	6437	4057	4038	4038
query73	751	353	347	347
query74	10148	8995	9117	8995
query75	3371	2623	2665	2623
query76	3191	1027	1103	1027
query77	440	275	270	270
query78	10484	9709	9545	9545
query79	1508	600	579	579
query80	1168	437	428	428
query81	538	219	216	216
query82	912	90	87	87
query83	225	149	138	138
query84	238	83	80	80
query85	1302	317	295	295
query86	355	288	281	281
query87	4328	4183	4182	4182
query88	3537	2396	2350	2350
query89	406	294	296	294
query90	1956	181	182	181
query91	181	149	148	148
query92	64	52	51	51
query93	1078	556	546	546
query94	874	289	293	289
query95	354	251	248	248
query96	598	272	281	272
query97	3336	3126	3122	3122
query98	214	198	198	198
query99	1534	1327	1312	1312
Total cold run time: 299905 ms
Total hot run time: 190202 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.15 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01b59066e7582f5d657bbbe4cb8fe22a8b66df58, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.52	0.52	0.52
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.05
query9	0.55	0.49	0.51
query10	0.55	0.55	0.55
query11	0.14	0.10	0.09
query12	0.14	0.12	0.10
query13	0.61	0.59	0.60
query14	0.77	0.79	0.80
query15	0.84	0.82	0.81
query16	0.38	0.37	0.39
query17	1.00	1.06	1.06
query18	0.24	0.22	0.22
query19	1.95	1.89	1.76
query20	0.01	0.00	0.01
query21	15.40	0.56	0.56
query22	2.32	2.38	1.54
query23	17.06	0.95	1.01
query24	3.68	1.32	1.78
query25	0.28	0.10	0.06
query26	0.54	0.13	0.13
query27	0.05	0.04	0.04
query28	9.06	0.51	0.44
query29	12.59	3.22	3.18
query30	0.24	0.05	0.06
query31	2.86	0.40	0.38
query32	3.24	0.47	0.45
query33	2.96	2.98	2.97
query34	16.96	4.48	4.49
query35	4.50	4.52	4.47
query36	0.68	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.76 s
Total hot run time: 30.15 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/24) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10906/26493)
Line Coverage 31.98% (93341/291915)
Region Coverage 31.05% (48118/154985)
Branch Coverage 27.51% (24650/89606)

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Dec 18, 2025
@github-actions github-actions bot closed this Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants