Skip to content

Conversation

@yiguolei
Copy link
Contributor

What problem does this PR solve?

pick #51929

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yiguolei yiguolei requested a review from dataroaring as a code owner June 20, 2025 06:10
@yiguolei
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 39663 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 31cd5f67b6a5107cc75d0911e9c16279e45630eb, data reload: false

------ Round 1 ----------------------------------
q1	17668	7056	6570	6570
q2	2071	165	164	164
q3	10840	1118	1208	1118
q4	10510	710	747	710
q5	7758	2849	2793	2793
q6	213	133	128	128
q7	950	630	600	600
q8	9356	1959	1997	1959
q9	6606	6376	6414	6376
q10	6980	2258	2264	2258
q11	449	254	266	254
q12	394	214	203	203
q13	17776	2988	2981	2981
q14	226	204	207	204
q15	498	464	462	462
q16	451	385	383	383
q17	965	513	539	513
q18	7488	6607	6716	6607
q19	1397	1074	1129	1074
q20	481	205	196	196
q21	3891	3244	3137	3137
q22	1101	986	973	973
Total cold run time: 108069 ms
Total hot run time: 39663 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6588	6545	6522	6522
q2	326	231	228	228
q3	2917	2682	2823	2682
q4	2028	1799	1808	1799
q5	5777	5727	5714	5714
q6	211	127	127	127
q7	2230	1743	1761	1743
q8	3362	3587	3502	3502
q9	8902	8701	8846	8701
q10	3582	3520	3492	3492
q11	602	495	486	486
q12	807	595	594	594
q13	9071	3132	3192	3132
q14	308	278	264	264
q15	521	471	464	464
q16	478	436	442	436
q17	1830	1599	1590	1590
q18	8263	7886	7844	7844
q19	1697	1496	1593	1496
q20	2156	1814	1804	1804
q21	5073	4908	5068	4908
q22	1120	1056	1011	1011
Total cold run time: 67849 ms
Total hot run time: 58539 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196425 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 31cd5f67b6a5107cc75d0911e9c16279e45630eb, data reload: false

query1	1257	908	925	908
query2	6185	1964	1963	1963
query3	10794	4420	4157	4157
query4	61431	30064	23705	23705
query5	5237	491	460	460
query6	410	197	185	185
query7	5441	321	327	321
query8	314	224	228	224
query9	8635	2593	2581	2581
query10	444	267	270	267
query11	17617	15114	16127	15114
query12	165	101	104	101
query13	1453	436	426	426
query14	10030	6935	7561	6935
query15	207	177	179	177
query16	7195	491	522	491
query17	1145	584	573	573
query18	1861	310	321	310
query19	213	159	160	159
query20	120	110	109	109
query21	208	106	106	106
query22	4708	4427	4867	4427
query23	34096	33885	34352	33885
query24	6173	2940	2965	2940
query25	558	425	422	422
query26	690	178	202	178
query27	1965	361	362	361
query28	4049	2153	2146	2146
query29	665	438	419	419
query30	232	157	154	154
query31	996	808	812	808
query32	63	53	55	53
query33	421	298	302	298
query34	917	507	532	507
query35	853	722	717	717
query36	1051	935	947	935
query37	109	67	64	64
query38	4050	3961	4028	3961
query39	1521	1447	1478	1447
query40	211	111	99	99
query41	52	49	60	49
query42	112	100	104	100
query43	532	507	504	504
query44	1188	829	818	818
query45	187	165	167	165
query46	1126	746	754	746
query47	2043	1914	1949	1914
query48	474	381	392	381
query49	729	408	398	398
query50	853	437	424	424
query51	7619	7272	7253	7253
query52	100	91	90	90
query53	263	191	186	186
query54	587	487	472	472
query55	83	78	79	78
query56	276	253	257	253
query57	1325	1175	1197	1175
query58	225	205	215	205
query59	3429	3141	3047	3047
query60	286	254	258	254
query61	109	134	107	107
query62	756	659	664	659
query63	220	189	182	182
query64	1739	662	621	621
query65	3268	3175	3196	3175
query66	723	297	293	293
query67	15831	15465	15667	15465
query68	4152	599	621	599
query69	422	263	268	263
query70	1142	1135	1087	1087
query71	344	273	246	246
query72	6456	4173	3993	3993
query73	740	351	367	351
query74	10009	8887	8983	8887
query75	3371	2598	2663	2598
query76	2039	1063	1141	1063
query77	483	290	272	272
query78	10652	9604	9616	9604
query79	1401	597	603	597
query80	877	443	422	422
query81	492	222	218	218
query82	1241	87	88	87
query83	253	149	140	140
query84	288	81	79	79
query85	879	302	285	285
query86	321	290	299	290
query87	4391	4236	4278	4236
query88	3885	2418	2385	2385
query89	416	298	285	285
query90	2011	188	188	188
query91	185	150	153	150
query92	64	49	52	49
query93	1964	562	553	553
query94	743	301	283	283
query95	378	263	260	260
query96	625	281	281	281
query97	3298	3146	3103	3103
query98	211	201	210	201
query99	2059	1304	1263	1263
Total cold run time: 313617 ms
Total hot run time: 196425 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 31cd5f67b6a5107cc75d0911e9c16279e45630eb, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.54	0.50	0.52
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.05	0.02
query9	0.55	0.51	0.50
query10	0.55	0.56	0.54
query11	0.14	0.11	0.11
query12	0.14	0.12	0.11
query13	0.60	0.60	0.59
query14	0.76	0.79	0.81
query15	0.85	0.81	0.81
query16	0.38	0.38	0.39
query17	1.03	1.03	1.00
query18	0.23	0.22	0.21
query19	1.96	1.77	1.90
query20	0.01	0.01	0.02
query21	15.40	0.58	0.60
query22	2.15	1.69	1.44
query23	16.91	0.93	0.89
query24	2.88	0.87	1.51
query25	0.23	0.08	0.10
query26	0.52	0.14	0.13
query27	0.04	0.05	0.04
query28	10.39	0.45	0.48
query29	12.71	3.20	3.19
query30	0.25	0.06	0.06
query31	2.85	0.39	0.39
query32	3.23	0.46	0.45
query33	2.96	3.01	3.02
query34	17.14	4.45	4.44
query35	4.51	4.50	4.49
query36	0.68	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 104.21 s
Total hot run time: 29.6 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10904/26493)
Line Coverage 31.96% (93300/291910)
Region Coverage 31.04% (48114/154990)
Branch Coverage 27.50% (24641/89608)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 2d1de55 into apache:branch-3.0 Jun 20, 2025
21 of 25 checks passed
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants