[Feature] Support Create Dynamic Partition Immediately FirstTime Without Wating Schedule. #5209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Jan 8, 2021
|
|
||
| package org.apache.doris.clone; | ||
|
|
||
| import com.google.common.collect.Lists; |
Contributor
There was a problem hiding this comment.
please attention import order
pengxiangyu
approved these changes
Jan 8, 2021
pengxiangyu
previously approved these changes
Jan 8, 2021
yangzhg
reviewed
Jan 8, 2021
| Iterator<Pair<Long, Long>> iterator = dynamicPartitionTableInfo.iterator(); | ||
| while (iterator.hasNext()) { | ||
| Pair<Long, Long> tableInfo = iterator.next(); | ||
| private void executeDynamicPartition(Iterator<Pair<Long, Long>> tableInfoIterator) { |
…out Wating Schedule. issue:apache#5208
HappenLee
force-pushed
the
dynam_partition
branch
from
de5be00 to
54babc0
Compare
morningman
requested changes
Jan 10, 2021
| if (olapTable.getTableProperty() != null | ||
| && olapTable.getTableProperty().getDynamicPartitionProperty() != null) { | ||
| if (olapTable.getTableProperty().getDynamicPartitionProperty().getEnable()) { | ||
| Catalog.getCurrentCatalog().getDynamicPartitionScheduler().executeDynamicPartitionFirstTime(dbId, olapTable.getId()); |
Contributor
There was a problem hiding this comment.
registerOrRemoveDynamicPartitionTable() is also called in replayCreateTable().
And in "replay" process, we should not call executeDynamicPartition()
morningman
added
area/catalog
Contributor
|
Fix ut |
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
…out Wating Schedule. (apache#5209)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
issue:#5208
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...