[opt](topn)Optimize the time for topn to lazy materialized reading of external tables #52114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35153 ms |
TPC-DS: Total hot run time: 186100 ms |
ClickBench: Total hot run time: 29.16 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33815 ms |
TPC-DS: Total hot run time: 184906 ms |
ClickBench: Total hot run time: 29.38 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33885 ms |
TPC-DS: Total hot run time: 184507 ms |
ClickBench: Total hot run time: 30.09 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34244 ms |
TPC-DS: Total hot run time: 184964 ms |
ClickBench: Total hot run time: 29.91 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
HappenLee
reviewed
Jul 7, 2025
be/src/exec/rowid_fetcher.cpp
Outdated
| } | ||
|
|
||
| { | ||
| stringstream ss; |
Contributor
There was a problem hiding this comment.
not use stringstream use fmt to get better performance
HappenLee
reviewed
Jul 7, 2025
be/src/exec/rowid_fetcher.cpp
Outdated
| RETURN_IF_ERROR(vfile_scanner_ptr->read_one_line_from_range( | ||
| scan_range_desc, request_block_desc.row_id(j), &result_block, external_info, | ||
| init_reader_ms, get_block_ms)); | ||
| dst_col->insert_range_from(src_col, block_idx, 1); |
Contributor
There was a problem hiding this comment.
length 1, can use insert_from to do the work。
if want speed up the call， also can call insert_from_multi_column
HappenLee
reviewed
Jul 7, 2025
be/src/pipeline/dependency.cpp
Outdated
| .request = multi_get_request, | ||
| .callback = nullptr, | ||
| .rpc_timer = MonotonicStopWatch()}); | ||
| // if (profile != nullptr) { |
HappenLee
reviewed
Jul 7, 2025
be/src/pipeline/dependency.cpp
Outdated
| return Status::OK(); | ||
| } | ||
|
|
||
| Status MaterializationSharedState::_update_profile_info(int64_t backend_id, |
Contributor
There was a problem hiding this comment.
the func only return OK, should be void
HappenLee
reviewed
Jul 7, 2025
be/src/pipeline/dependency.cpp
Outdated
| } | ||
| auto& info_map = backend_profile_info_string[backend_id]; | ||
|
|
||
| auto func = [&](const std::string& info_key) -> Status { |
HappenLee
reviewed
Jul 7, 2025
| child.to_proto(proto_counters, child_counter_map); | ||
| } | ||
|
|
||
| // Recurse into children |
HappenLee
reviewed
Jul 7, 2025
be/src/util/runtime_profile.h
Outdated
| } | ||
|
|
||
| PProfileCounter to_proto_peak(const std::string& name) const { | ||
| PProfileCounter counter; |
Contributor
There was a problem hiding this comment.
same code like to_proto just call to_proto
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 32929 ms |
TPC-DS: Total hot run time: 186311 ms |
ClickBench: Total hot run time: 29.31 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Jul 12, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #51329
Problem Summary:
Topn lazy materialize was introduced in pr#51329 , but the implementation had performance issues when reading external tables. This pr is used for optimization.
RowIDFetchertoMATERIALIZATION_OPERATOR.The example is as follows:
1FE 2BE
sql :select * from ali_hive.tpch100_orc.lineitem order by l_partkey limit 10;
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)