-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](txn load) fix delete in txn load #52133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33889 ms |
TPC-DS: Total hot run time: 186267 ms |
ClickBench: Total hot run time: 29.57 s |
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneEmptyPartition.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
say about this statement: insert into target_table select * from big_table where partition_column='empty_partition_key'
can this pr skip to scan big_table?
|
run buildall |
TPC-H: Total hot run time: 33829 ms |
TPC-DS: Total hot run time: 186043 ms |
ClickBench: Total hot run time: 29.49 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 33908 ms |
TPC-DS: Total hot run time: 185440 ms |
ClickBench: Total hot run time: 29.17 s |
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…he#52637) Cherry-picked from apache#52133
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
if do txn load to a empty table, should not prune empty because there are insible versions.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)