Add some consistency check in image put api #5219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 20, 2020 18:29
morningman
reviewed
Jan 17, 2021
| if (Catalog.getCurrentCatalog().isMaster()) { | ||
| response.appendContent("this node is master, reject image put"); | ||
| writeResponse(request, response, HttpResponseStatus.BAD_REQUEST); | ||
| LOG.error("this node is master, but receive image put from host{}, reject it", machine); |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG.error("this node is master, but receive image put from host{}, reject it", machine); | |
| LOG.error("this node is master, but receive image put from host {}, reject it", machine); |
| // if accepted, newly added log will not be replayed when restart | ||
| long maxJournalId = Catalog.getCurrentCatalog().getMaxJournalId(); | ||
| if (version > maxJournalId) { | ||
| response.appendContent("image version is bigger than local max journal id, reject image put"); |
Contributor
There was a problem hiding this comment.
better to add the value of max journal id and image id in response msg for easy debugging.
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #5218
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...