Skip to content

[fix](paimon) fix test_paimon_count case #52263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-stephen merged 2 commits into from
Jun 25, 2025
Merged

[fix](paimon) fix test_paimon_count case #52263

hello-stephen merged 2 commits into from
Jun 25, 2025

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Jun 25, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #51834

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Jun 25, 2025

run external

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Jun 25, 2025

run external

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

skip buildall

hello-stephen
hello-stephen approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

PR approved by at least one committer and no changes requested.

MoanasDaddyXu
MoanasDaddyXu approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@MoanasDaddyXu MoanasDaddyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 834fdb3 into apache:master Jun 25, 2025
31 checks passed
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Jun 25, 2025
@suxiaogang223
[fix](paimon) fix test_paimon_count case (apache#52263)
661dd6f 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: apache#51834
@suxiaogang223 suxiaogang223 mentioned this pull request Jun 25, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 26, 2025
@suxiaogang223
branch-3.1: [fix](paimon) fix select count(*) from paimon table #51834 …
dbf0a55 
…#52263 (#52301)

main pick: #51834 
fix case: #52263
@suxiaogang223 suxiaogang223 deleted the fix_paimon_case branch June 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

+1 more reviewer

@MoanasDaddyXu MoanasDaddyXu MoanasDaddyXu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@suxiaogang223 @Thearas @hello-stephen @englefly @MoanasDaddyXu @morningman @morrySnow