Skip to content

branch-3.1: [fix](auth)Only treat admin@% and root@% as system users. #50904 #52281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jun 26, 2025
Merged

branch-3.1: [fix](auth)Only treat admin@% and root@% as system users. #50904 #52281

morrySnow merged 1 commit into from
Jun 26, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 25, 2025

Cherry-picked from #50904

@zddr
[fix](auth)Only treat admin@% and root@% as system users. (#50904)
aa75a16 
### What problem does this PR solve?

not allow drop user `admin@%`

but should allow drop user `admin@'xxx.xxx.xxx'`

### Release note
Only treat admin@% and root@% as system users.
@github-actions github-actions bot requested a review from morrySnow as a code owner June 25, 2025 06:23
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 25, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-H: Total hot run time: 39495 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aa75a16f8449422dc5bf4a4255f0281a2657259f, data reload: false

------ Round 1 ----------------------------------
q1	17607	6777	6615	6615
q2	2073	167	161	161
q3	10570	1096	1231	1096
q4	10564	729	760	729
q5	7736	2850	2770	2770
q6	215	137	139	137
q7	970	621	608	608
q8	9354	1915	2024	1915
q9	6583	6383	6395	6383
q10	7005	2283	2307	2283
q11	465	259	254	254
q12	392	216	210	210
q13	17780	3006	3006	3006
q14	230	199	200	199
q15	505	454	466	454
q16	460	367	377	367
q17	976	553	578	553
q18	7296	6816	6613	6613
q19	1317	1032	930	930
q20	453	202	197	197
q21	3878	3153	3018	3018
q22	1134	1008	997	997
Total cold run time: 107563 ms
Total hot run time: 39495 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6602	6558	6542	6542
q2	322	232	230	230
q3	2848	2726	2771	2726
q4	2050	1797	1778	1778
q5	5732	5770	5725	5725
q6	208	125	129	125
q7	2187	1816	1737	1737
q8	3374	3541	3527	3527
q9	8892	8800	8945	8800
q10	3547	3533	3516	3516
q11	614	487	486	486
q12	783	591	614	591
q13	8501	3146	3163	3146
q14	311	259	262	259
q15	518	461	463	461
q16	475	435	440	435
q17	1828	1596	1570	1570
q18	8177	7784	7849	7784
q19	1693	1529	1633	1529
q20	2151	1838	1802	1802
q21	4973	5002	4968	4968
q22	1138	1012	1043	1012
Total cold run time: 66924 ms
Total hot run time: 58749 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-DS: Total hot run time: 196688 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aa75a16f8449422dc5bf4a4255f0281a2657259f, data reload: false

query1	1271	918	921	918
query2	6262	1963	1935	1935
query3	10803	4310	4161	4161
query4	61384	30016	23669	23669
query5	5247	475	446	446
query6	405	194	189	189
query7	5455	318	320	318
query8	323	233	236	233
query9	8536	2588	2581	2581
query10	474	271	260	260
query11	17950	15170	15848	15170
query12	162	104	116	104
query13	1449	441	439	439
query14	9889	6906	6723	6723
query15	210	185	190	185
query16	7320	468	438	438
query17	1241	570	596	570
query18	1918	326	317	317
query19	241	179	160	160
query20	115	113	111	111
query21	213	107	108	107
query22	4493	4797	4492	4492
query23	34617	34141	34563	34141
query24	6979	2903	3024	2903
query25	587	420	410	410
query26	661	171	176	171
query27	2332	400	350	350
query28	4202	2170	2149	2149
query29	697	450	435	435
query30	240	153	154	153
query31	973	820	803	803
query32	67	55	62	55
query33	408	306	298	298
query34	919	499	523	499
query35	827	718	736	718
query36	1048	954	919	919
query37	109	67	67	67
query38	4020	4020	3998	3998
query39	1650	1482	1442	1442
query40	198	103	99	99
query41	48	50	45	45
query42	114	100	99	99
query43	535	501	493	493
query44	1215	848	829	829
query45	196	169	172	169
query46	1168	741	762	741
query47	2030	1908	1956	1908
query48	444	347	363	347
query49	745	404	402	402
query50	878	453	437	437
query51	7415	7270	7226	7226
query52	98	99	93	93
query53	273	185	184	184
query54	565	472	463	463
query55	87	80	79	79
query56	280	241	256	241
query57	1289	1185	1193	1185
query58	236	205	223	205
query59	3212	3034	3161	3034
query60	291	258	262	258
query61	111	110	114	110
query62	781	692	692	692
query63	225	199	188	188
query64	1365	632	622	622
query65	3252	3219	3205	3205
query66	711	288	327	288
query67	16022	15482	15563	15482
query68	4152	568	582	568
query69	446	269	267	267
query70	1136	1091	1066	1066
query71	359	265	260	260
query72	6316	4069	4076	4069
query73	784	351	361	351
query74	10564	8996	8978	8978
query75	3353	2640	2683	2640
query76	2086	1112	1132	1112
query77	492	273	275	273
query78	10474	9598	9641	9598
query79	1349	607	598	598
query80	857	467	426	426
query81	485	218	221	218
query82	1296	91	90	90
query83	250	145	138	138
query84	283	79	77	77
query85	882	297	293	293
query86	323	295	296	295
query87	4405	4254	4279	4254
query88	3484	2390	2376	2376
query89	421	292	291	291
query90	1991	186	189	186
query91	141	107	108	107
query92	65	51	53	51
query93	1643	545	542	542
query94	736	302	261	261
query95	362	261	261	261
query96	629	277	284	277
query97	3340	3107	3125	3107
query98	216	198	194	194
query99	1563	1303	1317	1303
Total cold run time: 314364 ms
Total hot run time: 196688 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

ClickBench: Total hot run time: 29.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aa75a16f8449422dc5bf4a4255f0281a2657259f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.53	0.53	0.52
query6	1.13	0.75	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.57	0.55
query11	0.14	0.11	0.11
query12	0.13	0.11	0.10
query13	0.61	0.60	0.59
query14	0.77	0.78	0.82
query15	0.85	0.83	0.82
query16	0.39	0.40	0.39
query17	1.05	1.06	1.05
query18	0.24	0.22	0.22
query19	1.95	1.88	1.76
query20	0.01	0.00	0.01
query21	15.40	0.60	0.57
query22	2.15	2.00	2.34
query23	16.89	0.88	0.64
query24	4.32	0.70	1.44
query25	0.34	0.09	0.08
query26	0.54	0.15	0.14
query27	0.06	0.05	0.05
query28	9.58	0.48	0.47
query29	12.55	3.23	3.24
query30	0.25	0.06	0.06
query31	2.87	0.41	0.39
query32	3.23	0.46	0.45
query33	2.96	2.95	3.02
query34	17.20	4.44	4.53
query35	4.51	4.48	4.44
query36	0.69	0.47	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 104.92 s
Total hot run time: 29.76 s

@zddr
Copy link
Contributor

zddr commented Jun 25, 2025

run feut

@zddr
Copy link
Contributor

zddr commented Jun 25, 2025

run external

@zddr
Copy link
Contributor

zddr commented Jun 25, 2025

run feut

@zddr
Copy link
Contributor

zddr commented Jun 25, 2025

run external

@zddr
Copy link
Contributor

zddr commented Jun 25, 2025

run p0

@morrySnow morrySnow merged commit b83c166 into branch-3.1 Jun 26, 2025
22 checks passed
@morrySnow morrySnow deleted the auto-pick-50904-branch-3.1 branch June 26, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @zddr @morrySnow @dataroaring