Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #50904

### What problem does this PR solve?

not allow drop user `admin@%`

but should allow drop user `admin@'xxx.xxx.xxx'`

### Release note
Only treat admin@% and root@% as system users.
@github-actions github-actions bot requested a review from dataroaring as a code owner June 25, 2025 06:23
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 25, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39717 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c4348224fc73ffcf59ce5bdff175cb527b3e63a, data reload: false

------ Round 1 ----------------------------------
q1	17612	6703	6626	6626
q2	2054	167	196	167
q3	10589	1080	1190	1080
q4	10543	775	730	730
q5	7732	2859	2774	2774
q6	214	135	133	133
q7	957	621	640	621
q8	9347	1950	2020	1950
q9	6639	6400	6384	6384
q10	6985	2250	2304	2250
q11	466	265	261	261
q12	393	221	216	216
q13	17791	2977	2960	2960
q14	241	200	210	200
q15	505	468	468	468
q16	491	392	384	384
q17	983	548	550	548
q18	7093	6649	6655	6649
q19	1382	1090	1039	1039
q20	465	202	200	200
q21	3902	3307	3091	3091
q22	1092	997	986	986
Total cold run time: 107476 ms
Total hot run time: 39717 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6530	6508	6558	6508
q2	336	233	232	232
q3	2888	2765	2828	2765
q4	2051	1796	1793	1793
q5	5715	5740	5716	5716
q6	210	133	129	129
q7	2207	1797	1790	1790
q8	3369	3480	3524	3480
q9	8863	8670	8865	8670
q10	3565	3476	3505	3476
q11	600	503	511	503
q12	795	585	586	585
q13	10300	3153	3175	3153
q14	326	280	289	280
q15	515	456	458	456
q16	520	442	440	440
q17	1849	1641	1599	1599
q18	8274	7798	7746	7746
q19	1694	1607	1577	1577
q20	2169	1828	1820	1820
q21	5147	5021	5010	5010
q22	1138	1057	1025	1025
Total cold run time: 69061 ms
Total hot run time: 58753 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196095 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c4348224fc73ffcf59ce5bdff175cb527b3e63a, data reload: false

query1	1277	897	894	894
query2	6298	2003	1954	1954
query3	10932	4462	4328	4328
query4	62113	28714	23430	23430
query5	5225	452	448	448
query6	382	172	178	172
query7	5508	310	307	307
query8	291	220	225	220
query9	8379	2542	2529	2529
query10	454	261	253	253
query11	17747	15149	15666	15149
query12	164	99	110	99
query13	1431	433	452	433
query14	10470	6831	7145	6831
query15	204	189	183	183
query16	7115	487	512	487
query17	1134	590	591	590
query18	1868	332	310	310
query19	207	164	167	164
query20	117	107	104	104
query21	201	101	101	101
query22	4608	4372	4650	4372
query23	34714	33990	34058	33990
query24	6108	2861	2915	2861
query25	515	409	421	409
query26	661	162	165	162
query27	1847	336	366	336
query28	4021	2117	2085	2085
query29	691	436	425	425
query30	225	158	153	153
query31	992	825	883	825
query32	68	57	52	52
query33	403	304	284	284
query34	907	512	511	511
query35	838	732	731	731
query36	1074	975	973	973
query37	110	72	64	64
query38	4113	3925	3958	3925
query39	1533	1479	1467	1467
query40	192	95	98	95
query41	49	51	47	47
query42	120	104	106	104
query43	538	504	495	495
query44	1200	811	794	794
query45	189	171	164	164
query46	1143	761	735	735
query47	2017	1912	1931	1912
query48	473	375	387	375
query49	776	395	390	390
query50	830	428	425	425
query51	7479	7251	7165	7165
query52	96	90	89	89
query53	257	190	181	181
query54	569	480	459	459
query55	83	83	81	81
query56	269	245	248	245
query57	1336	1249	1246	1246
query58	215	203	204	203
query59	3406	3247	3125	3125
query60	274	257	267	257
query61	120	108	105	105
query62	783	698	670	670
query63	224	196	203	196
query64	1484	693	735	693
query65	3250	3202	3226	3202
query66	720	325	306	306
query67	15961	15545	15598	15545
query68	4272	574	565	565
query69	424	277	276	276
query70	1234	1102	1087	1087
query71	349	272	255	255
query72	6547	4181	3964	3964
query73	755	346	348	346
query74	10336	9283	9019	9019
query75	3359	2588	2633	2588
query76	1975	1059	1124	1059
query77	460	270	269	269
query78	10564	9726	9491	9491
query79	2087	596	591	591
query80	1350	411	424	411
query81	510	216	220	216
query82	1201	86	85	85
query83	268	149	141	141
query84	277	79	77	77
query85	1044	304	301	301
query86	376	302	287	287
query87	4436	4242	4243	4242
query88	3815	2351	2339	2339
query89	420	286	291	286
query90	2004	195	182	182
query91	182	148	147	147
query92	60	49	56	49
query93	2617	546	539	539
query94	791	247	287	247
query95	359	258	256	256
query96	621	284	295	284
query97	3334	3115	3137	3115
query98	216	191	200	191
query99	1583	1320	1275	1275
Total cold run time: 316824 ms
Total hot run time: 196095 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.9 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c4348224fc73ffcf59ce5bdff175cb527b3e63a, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.54	0.52	0.52
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.49	0.49
query10	0.55	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.12	0.12
query13	0.61	0.60	0.59
query14	0.77	0.80	0.79
query15	0.84	0.83	0.82
query16	0.38	0.39	0.40
query17	1.00	1.06	1.00
query18	0.25	0.22	0.22
query19	1.97	1.85	1.84
query20	0.01	0.02	0.01
query21	15.39	0.60	0.59
query22	2.49	1.86	2.21
query23	16.90	0.96	0.80
query24	3.24	0.62	1.88
query25	0.18	0.14	0.04
query26	0.52	0.14	0.13
query27	0.03	0.04	0.04
query28	10.00	0.54	0.48
query29	12.55	3.23	3.21
query30	0.25	0.06	0.05
query31	2.89	0.39	0.38
query32	3.24	0.46	0.46
query33	3.01	2.97	3.03
query34	17.12	4.59	4.55
query35	4.59	4.58	4.53
query36	0.64	0.47	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.15	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.44 s
Total hot run time: 29.9 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1b794dd into branch-3.0 Jun 30, 2025
23 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-50904-branch-3.0 branch June 30, 2025 07:56
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants