Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jan 14, 2021

Proposed changes

this is a part of #5232 , we add aws sdk dependency to thirdparty

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman self-assigned this Jan 17, 2021
@morningman morningman added the area/dependency Issues or PRs related to Doris dependencies label Jan 17, 2021
@yangzhg yangzhg force-pushed the add_aws_sdk_to_thirdparty branch from fba9fbf to ab0e20e Compare January 18, 2021 08:06
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 19, 2021
@yangzhg yangzhg merged commit 3a6476b into apache:master Jan 20, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@yangzhg yangzhg deleted the add_aws_sdk_to_thirdparty branch April 12, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/dependency Issues or PRs related to Doris dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants