Skip to content

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Jun 27, 2025

What problem does this PR solve?

  1. fix compute wrong scale of round_bankers/truncate/round/dround/floor/dfloor/ceil/dceil, introduced by [enhancement](function truncate) truncate can use column as scale argument #32746 and [enhancement](function) floor/ceil/round/round_bankers can use column as scale argument #34391

this sql will throw exception:

create table test_round_bankers_scale(
  id bigint,
  a decimal(32,6)
)
properties ("replication_num" = "1");

select round_bankers(a, 1-2)
from test_round_bankers_scale
order by id

(1105, 'errCode = 2, detailMessage = (172.20.48.119)[INTERNAL_ERROR]output type not match expr type  , col name  , expected type Nullable(Decimal(32, 6)) , real type Nullable(Decimal(32, 0))')

The scale of return type of the round_bankers function depends on the type of its arguments. If the second argument is an integer constant, that constant is used as the scale. If it is not a constant, the scale of the first argument is used instead. This leads to a problem: for expressions like 1 - 2, the scale used in the computation differs before and after constant folding, which can cause the Backend to throw an exception: type mismatch

So we need to fold the arguments into constants before binding the function, to ensure that the scale will not change

  1. keep idempotent of function signature. when we select a signature for a function, we should not change signature after do some rewrite

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 changed the title [fix](nereids) fix compute wrong scale of round_bankers [fix](nereids) fix compute wrong scale of round_bankers/truncate/round/dround/floor/dfloor/ceil/dceil Jun 27, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 33938 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a2c1757e3d661ce7d81e0e786760f0256e03afe6, data reload: false

------ Round 1 ----------------------------------
q1	17524	5258	5246	5246
q2	1928	286	185	185
q3	5744	1300	722	722
q4	9787	1040	517	517
q5	8580	2374	2310	2310
q6	191	161	131	131
q7	881	745	610	610
q8	9271	1276	1021	1021
q9	7757	5065	5060	5060
q10	6887	2392	1982	1982
q11	470	288	276	276
q12	343	342	216	216
q13	3366	3651	3103	3103
q14	228	223	212	212
q15	545	484	479	479
q16	427	420	372	372
q17	595	864	363	363
q18	7380	7272	7044	7044
q19	1080	950	540	540
q20	345	345	220	220
q21	3960	3172	2387	2387
q22	1069	1038	942	942
Total cold run time: 88358 ms
Total hot run time: 33938 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5174	5099	5143	5099
q2	239	337	218	218
q3	2181	2685	2306	2306
q4	1375	1788	1362	1362
q5	4193	4158	4138	4138
q6	212	162	122	122
q7	1900	1808	1703	1703
q8	2487	2387	2363	2363
q9	6758	6752	6766	6752
q10	2970	3189	2735	2735
q11	552	497	500	497
q12	635	726	574	574
q13	3305	3670	3110	3110
q14	282	280	277	277
q15	508	470	462	462
q16	431	474	428	428
q17	1099	1514	1312	1312
q18	7247	7144	7064	7064
q19	755	794	813	794
q20	1897	2016	1826	1826
q21	4815	4411	4317	4317
q22	1074	1008	989	989
Total cold run time: 50089 ms
Total hot run time: 48448 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185788 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a2c1757e3d661ce7d81e0e786760f0256e03afe6, data reload: false

query1	994	386	381	381
query2	6523	1799	1789	1789
query3	6745	216	218	216
query4	26728	23216	23486	23216
query5	5036	600	450	450
query6	297	217	204	204
query7	4628	492	280	280
query8	286	220	203	203
query9	8656	2613	2608	2608
query10	511	303	292	292
query11	15576	15075	14870	14870
query12	163	108	111	108
query13	1650	533	413	413
query14	9859	5706	5778	5706
query15	207	191	172	172
query16	7627	643	467	467
query17	1166	716	591	591
query18	2028	413	313	313
query19	195	201	159	159
query20	123	119	115	115
query21	213	124	107	107
query22	4109	4208	3995	3995
query23	34019	33303	33078	33078
query24	8396	2363	2405	2363
query25	568	577	392	392
query26	1238	266	143	143
query27	2732	506	340	340
query28	4335	2134	2104	2104
query29	723	560	453	453
query30	279	219	185	185
query31	934	858	782	782
query32	70	67	57	57
query33	567	450	320	320
query34	787	856	520	520
query35	774	822	781	781
query36	942	1023	888	888
query37	109	110	74	74
query38	4158	4152	4187	4152
query39	1481	1400	1469	1400
query40	208	114	102	102
query41	54	53	52	52
query42	124	107	102	102
query43	513	526	510	510
query44	1361	821	813	813
query45	179	169	163	163
query46	846	999	616	616
query47	1762	1794	1740	1740
query48	375	407	306	306
query49	735	451	396	396
query50	630	705	413	413
query51	4142	4205	4159	4159
query52	110	106	95	95
query53	233	263	185	185
query54	573	571	524	524
query55	85	87	90	87
query56	299	307	294	294
query57	1169	1197	1110	1110
query58	256	249	279	249
query59	2675	2872	2673	2673
query60	320	311	303	303
query61	121	120	117	117
query62	826	732	646	646
query63	216	185	185	185
query64	4247	999	646	646
query65	4289	4178	4215	4178
query66	1046	411	321	321
query67	15810	15621	15341	15341
query68	8684	901	532	532
query69	472	300	269	269
query70	1230	1115	1103	1103
query71	496	332	298	298
query72	5697	4765	4753	4753
query73	723	599	357	357
query74	8913	9392	9012	9012
query75	3941	3208	2760	2760
query76	3749	1167	792	792
query77	800	404	290	290
query78	10102	10126	9305	9305
query79	2137	862	588	588
query80	610	527	444	444
query81	502	269	238	238
query82	463	142	109	109
query83	252	259	312	259
query84	252	110	91	91
query85	780	359	318	318
query86	389	320	307	307
query87	4506	4560	4346	4346
query88	3755	2311	2289	2289
query89	457	327	287	287
query90	1924	220	214	214
query91	140	140	110	110
query92	74	62	54	54
query93	1606	1000	604	604
query94	677	409	312	312
query95	383	302	289	289
query96	505	583	278	278
query97	2761	2834	2691	2691
query98	239	208	206	206
query99	1415	1382	1270	1270
Total cold run time: 277270 ms
Total hot run time: 185788 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a2c1757e3d661ce7d81e0e786760f0256e03afe6, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.05
query3	0.25	0.08	0.08
query4	1.61	0.10	0.11
query5	0.45	0.43	0.42
query6	1.18	0.66	0.65
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.62	0.52	0.53
query10	0.57	0.58	0.57
query11	0.15	0.11	0.12
query12	0.16	0.11	0.11
query13	0.63	0.61	0.62
query14	0.82	0.81	0.81
query15	0.90	0.87	0.86
query16	0.40	0.37	0.39
query17	1.05	1.06	1.04
query18	0.24	0.22	0.22
query19	1.98	1.81	1.85
query20	0.01	0.01	0.01
query21	15.39	0.91	0.57
query22	0.76	1.19	0.75
query23	14.79	1.41	0.63
query24	6.98	1.65	0.64
query25	0.54	0.21	0.18
query26	0.62	0.17	0.15
query27	0.07	0.06	0.05
query28	9.52	0.91	0.47
query29	12.53	3.95	3.31
query30	0.26	0.10	0.07
query31	2.83	0.60	0.39
query32	3.24	0.55	0.47
query33	3.17	3.15	3.18
query34	16.13	5.42	4.77
query35	4.81	4.83	4.88
query36	0.69	0.50	0.50
query37	0.09	0.07	0.06
query38	0.06	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.04 s
Total hot run time: 29.67 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉
Increment coverage report
Complete coverage report

@924060929 924060929 force-pushed the fix_round_bankers branch from a2c1757 to 1d2f04e Compare July 1, 2025 07:49
@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33979 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1d2f04e58caf82b0c34e2106ef7a7db83c0f1ad8, data reload: false

------ Round 1 ----------------------------------
q1	17604	5187	5065	5065
q2	1927	291	183	183
q3	10321	1312	720	720
q4	10227	1036	522	522
q5	7512	2413	2250	2250
q6	177	169	129	129
q7	900	737	601	601
q8	9292	1351	1094	1094
q9	6896	5018	5067	5018
q10	6885	2401	1971	1971
q11	478	303	287	287
q12	354	354	222	222
q13	17778	3776	3104	3104
q14	236	227	213	213
q15	554	490	488	488
q16	425	438	397	397
q17	591	872	374	374
q18	7681	7189	7305	7189
q19	1204	954	539	539
q20	348	348	232	232
q21	4098	2575	2420	2420
q22	1027	988	961	961
Total cold run time: 106515 ms
Total hot run time: 33979 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5128	5138	5114	5114
q2	241	324	218	218
q3	2251	2677	2282	2282
q4	1371	1804	1356	1356
q5	4238	4405	4525	4405
q6	212	175	126	126
q7	2125	2030	1824	1824
q8	2731	2546	2553	2546
q9	7235	7444	7052	7052
q10	3138	3368	2850	2850
q11	599	524	489	489
q12	822	802	646	646
q13	3440	3731	3130	3130
q14	267	276	255	255
q15	526	468	455	455
q16	425	465	434	434
q17	1128	1445	1381	1381
q18	7622	7296	6996	6996
q19	752	713	872	713
q20	1935	1982	1829	1829
q21	4903	4330	4349	4330
q22	1063	1017	974	974
Total cold run time: 52152 ms
Total hot run time: 49405 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185070 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1d2f04e58caf82b0c34e2106ef7a7db83c0f1ad8, data reload: false

query1	1011	397	384	384
query2	6533	1716	1705	1705
query3	6749	211	205	205
query4	26571	24111	23293	23293
query5	4858	597	426	426
query6	308	216	202	202
query7	4622	499	294	294
query8	297	224	209	209
query9	8666	2612	2598	2598
query10	482	317	260	260
query11	15571	14992	14870	14870
query12	156	106	102	102
query13	1639	524	403	403
query14	9228	5681	5729	5681
query15	202	185	183	183
query16	7330	625	453	453
query17	1159	733	611	611
query18	2022	410	314	314
query19	195	192	162	162
query20	128	119	115	115
query21	213	121	105	105
query22	3991	4202	4135	4135
query23	34019	33046	33040	33040
query24	8499	2394	2387	2387
query25	584	500	443	443
query26	1229	263	145	145
query27	2769	495	347	347
query28	4324	2110	2081	2081
query29	743	563	432	432
query30	280	217	194	194
query31	928	859	797	797
query32	72	64	62	62
query33	554	347	313	313
query34	794	827	514	514
query35	848	806	733	733
query36	950	983	867	867
query37	115	98	79	79
query38	4166	4211	4046	4046
query39	1475	1410	1403	1403
query40	210	115	104	104
query41	55	57	49	49
query42	122	111	111	111
query43	516	517	480	480
query44	1318	808	798	798
query45	175	169	163	163
query46	851	1010	636	636
query47	1732	1808	1703	1703
query48	392	414	306	306
query49	708	476	389	389
query50	632	692	410	410
query51	4140	4178	4122	4122
query52	108	107	100	100
query53	228	254	185	185
query54	572	560	494	494
query55	84	80	79	79
query56	300	289	292	289
query57	1221	1168	1114	1114
query58	278	259	265	259
query59	2578	2639	2552	2552
query60	324	329	311	311
query61	125	120	127	120
query62	819	717	669	669
query63	221	185	190	185
query64	4307	1001	656	656
query65	4237	4209	4174	4174
query66	1118	418	307	307
query67	15883	15677	15412	15412
query68	7968	890	529	529
query69	470	294	268	268
query70	1190	1102	1073	1073
query71	461	335	308	308
query72	5791	4783	4747	4747
query73	694	595	351	351
query74	9220	9029	8908	8908
query75	3860	3203	2683	2683
query76	3746	1161	721	721
query77	787	375	291	291
query78	10008	10037	9284	9284
query79	2905	794	590	590
query80	625	499	455	455
query81	465	252	217	217
query82	454	121	94	94
query83	279	258	249	249
query84	292	106	96	96
query85	807	373	391	373
query86	331	302	288	288
query87	4411	4467	4352	4352
query88	3437	2271	2252	2252
query89	403	328	284	284
query90	1959	208	209	208
query91	135	143	112	112
query92	76	59	54	54
query93	2534	938	577	577
query94	667	375	282	282
query95	377	301	286	286
query96	491	574	278	278
query97	2747	2758	2624	2624
query98	226	211	207	207
query99	1459	1393	1259	1259
Total cold run time: 276809 ms
Total hot run time: 185070 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1d2f04e58caf82b0c34e2106ef7a7db83c0f1ad8, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.44	0.42	0.42
query6	1.17	0.66	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.61	0.52	0.52
query10	0.58	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.80	0.81	0.80
query15	0.91	0.86	0.88
query16	0.39	0.39	0.40
query17	1.11	1.07	1.06
query18	0.22	0.22	0.22
query19	1.93	1.82	1.86
query20	0.02	0.01	0.01
query21	15.41	0.87	0.55
query22	0.76	1.34	0.71
query23	14.73	1.41	0.64
query24	6.93	0.83	0.81
query25	0.46	0.28	0.17
query26	0.55	0.16	0.14
query27	0.06	0.06	0.05
query28	9.32	0.93	0.46
query29	12.60	3.92	3.31
query30	0.24	0.10	0.07
query31	2.83	0.58	0.38
query32	3.24	0.56	0.48
query33	3.07	3.06	3.17
query34	16.02	5.38	4.78
query35	4.79	4.83	4.86
query36	0.68	0.50	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.15	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.37 s
Total hot run time: 29.7 s

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33452 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4a33b04a880e5ee81e536519aec235167b69d9ba, data reload: false

------ Round 1 ----------------------------------
q1	17573	5113	4992	4992
q2	1916	287	184	184
q3	10349	1254	683	683
q4	10246	970	511	511
q5	7916	2375	2311	2311
q6	176	161	125	125
q7	883	742	604	604
q8	9296	1233	965	965
q9	6785	5074	5086	5074
q10	6865	2339	1976	1976
q11	493	300	272	272
q12	334	341	217	217
q13	17769	3661	3107	3107
q14	230	229	205	205
q15	551	470	483	470
q16	419	408	393	393
q17	577	849	347	347
q18	7650	7046	7019	7019
q19	2231	962	522	522
q20	312	330	212	212
q21	3531	2536	2306	2306
q22	1069	1006	957	957
Total cold run time: 107171 ms
Total hot run time: 33452 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5231	5037	5035	5035
q2	232	318	220	220
q3	2189	2621	2239	2239
q4	1403	1776	1349	1349
q5	4232	4403	4509	4403
q6	201	165	121	121
q7	2026	1861	1869	1861
q8	2638	2610	2518	2518
q9	7383	7337	7346	7337
q10	3080	3297	2857	2857
q11	597	526	492	492
q12	671	759	627	627
q13	3564	4024	3402	3402
q14	304	308	268	268
q15	512	488	475	475
q16	447	492	454	454
q17	1126	1519	1399	1399
q18	7816	7757	7562	7562
q19	752	756	805	756
q20	1924	1937	1841	1841
q21	4714	4351	4286	4286
q22	1048	1045	995	995
Total cold run time: 52090 ms
Total hot run time: 50497 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184655 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4a33b04a880e5ee81e536519aec235167b69d9ba, data reload: false

query1	1010	388	382	382
query2	6544	1681	1685	1681
query3	6742	217	206	206
query4	26747	23614	23392	23392
query5	4367	566	429	429
query6	294	218	232	218
query7	4630	487	289	289
query8	280	215	216	215
query9	8602	2621	2640	2621
query10	446	349	278	278
query11	15890	15104	14852	14852
query12	158	105	104	104
query13	1636	529	406	406
query14	8705	5598	5612	5598
query15	196	182	173	173
query16	7173	618	446	446
query17	1177	692	570	570
query18	1965	396	285	285
query19	194	194	184	184
query20	122	115	114	114
query21	209	118	101	101
query22	4058	4092	3976	3976
query23	33684	32841	32944	32841
query24	8494	2349	2367	2349
query25	537	466	387	387
query26	1224	260	144	144
query27	2756	505	336	336
query28	4344	2126	2101	2101
query29	735	541	445	445
query30	283	219	186	186
query31	910	849	772	772
query32	96	70	60	60
query33	549	377	308	308
query34	787	835	517	517
query35	823	831	732	732
query36	946	981	887	887
query37	117	100	75	75
query38	4128	4073	4083	4073
query39	1480	1444	1401	1401
query40	206	115	103	103
query41	62	53	51	51
query42	121	105	100	100
query43	490	506	476	476
query44	1295	807	810	807
query45	174	168	166	166
query46	820	998	625	625
query47	1778	1832	1670	1670
query48	394	413	311	311
query49	735	475	395	395
query50	638	683	407	407
query51	4093	4147	4099	4099
query52	111	118	94	94
query53	219	247	182	182
query54	599	559	503	503
query55	85	82	80	80
query56	301	320	282	282
query57	1214	1189	1128	1128
query58	284	260	281	260
query59	2636	2771	2653	2653
query60	341	356	312	312
query61	154	159	148	148
query62	809	721	671	671
query63	225	197	192	192
query64	4425	1084	759	759
query65	4281	4172	4166	4166
query66	1207	398	303	303
query67	15726	15485	15149	15149
query68	8240	876	519	519
query69	475	299	276	276
query70	1215	1085	1100	1085
query71	468	316	291	291
query72	5801	4727	4839	4727
query73	717	641	343	343
query74	8949	9206	9029	9029
query75	3783	3179	2647	2647
query76	3621	1140	707	707
query77	785	387	287	287
query78	10063	10177	9369	9369
query79	2286	810	591	591
query80	605	514	449	449
query81	486	254	232	232
query82	422	124	92	92
query83	288	303	228	228
query84	290	109	91	91
query85	779	370	320	320
query86	333	300	282	282
query87	4489	4380	4255	4255
query88	3341	2290	2245	2245
query89	392	313	289	289
query90	1907	206	198	198
query91	144	146	122	122
query92	71	60	54	54
query93	1697	960	593	593
query94	673	403	295	295
query95	371	286	285	285
query96	483	564	274	274
query97	2683	2750	2758	2750
query98	243	206	215	206
query99	1446	1394	1298	1298
Total cold run time: 274007 ms
Total hot run time: 184655 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4a33b04a880e5ee81e536519aec235167b69d9ba, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.04
query3	0.24	0.08	0.09
query4	1.61	0.11	0.11
query5	0.44	0.42	0.43
query6	1.16	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.59	0.50	0.51
query10	0.57	0.57	0.56
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.60
query14	0.80	0.81	0.81
query15	0.90	0.88	0.87
query16	0.38	0.38	0.41
query17	1.04	1.09	1.07
query18	0.22	0.21	0.21
query19	1.97	1.86	1.88
query20	0.01	0.01	0.01
query21	15.41	0.92	0.55
query22	0.74	1.02	0.64
query23	15.13	1.35	0.66
query24	6.79	1.09	0.96
query25	0.50	0.30	0.09
query26	0.58	0.16	0.14
query27	0.06	0.05	0.05
query28	9.57	0.94	0.45
query29	12.61	4.10	3.35
query30	0.26	0.09	0.07
query31	2.83	0.58	0.39
query32	3.24	0.56	0.48
query33	3.13	3.10	3.11
query34	16.00	5.38	4.80
query35	4.86	4.79	4.85
query36	0.68	0.50	0.49
query37	0.09	0.07	0.07
query38	0.05	0.05	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.91 s
Total hot run time: 29.83 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 15.38% (2/13) 🎉
Increment coverage report
Complete coverage report

@924060929 924060929 force-pushed the fix_round_bankers branch from 4a33b04 to fb75699 Compare July 16, 2025 09:32
@924060929
Copy link
Contributor Author

run buildall

1 similar comment
@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34016 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9924e9fc873ef427aafb6e1123d47a4ee9ce228d, data reload: false

------ Round 1 ----------------------------------
q1	17617	5234	5102	5102
q2	1936	284	174	174
q3	10318	1306	722	722
q4	10217	1014	504	504
q5	7552	2323	2336	2323
q6	173	155	126	126
q7	894	741	593	593
q8	9319	1285	1018	1018
q9	6815	5104	5084	5084
q10	6883	2373	1997	1997
q11	477	287	286	286
q12	340	344	212	212
q13	17744	3617	3149	3149
q14	247	241	230	230
q15	544	472	471	471
q16	429	446	372	372
q17	610	865	349	349
q18	7575	7167	7177	7167
q19	1208	951	541	541
q20	339	319	212	212
q21	4098	3108	2417	2417
q22	1052	1056	967	967
Total cold run time: 106387 ms
Total hot run time: 34016 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5153	5072	5135	5072
q2	252	346	220	220
q3	2149	2677	2289	2289
q4	1367	1766	1317	1317
q5	4232	4516	4630	4516
q6	263	172	128	128
q7	2032	1978	1763	1763
q8	2656	2539	2552	2539
q9	7297	7336	7272	7272
q10	3166	3291	2894	2894
q11	583	513	495	495
q12	688	781	608	608
q13	3573	4020	3365	3365
q14	314	339	316	316
q15	525	481	475	475
q16	444	489	491	489
q17	1270	1561	1411	1411
q18	7900	7684	7538	7538
q19	823	884	941	884
q20	1992	2361	1885	1885
q21	5070	4491	4589	4491
q22	1114	1072	1208	1072
Total cold run time: 52863 ms
Total hot run time: 51039 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187624 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9924e9fc873ef427aafb6e1123d47a4ee9ce228d, data reload: false

query1	979	391	396	391
query2	6520	1688	1719	1688
query3	6755	209	214	209
query4	26790	23741	23002	23002
query5	4405	579	458	458
query6	313	212	195	195
query7	4636	501	290	290
query8	265	226	210	210
query9	8621	2633	2630	2630
query10	469	323	285	285
query11	15672	15110	14959	14959
query12	159	109	106	106
query13	1660	529	417	417
query14	8979	5982	5906	5906
query15	211	201	170	170
query16	7206	619	455	455
query17	1198	723	589	589
query18	1981	409	315	315
query19	206	190	165	165
query20	121	117	125	117
query21	215	125	107	107
query22	4751	4738	4767	4738
query23	34930	34005	33264	33264
query24	8442	2356	2363	2356
query25	534	444	382	382
query26	1231	265	141	141
query27	2732	549	351	351
query28	4309	2141	2103	2103
query29	739	540	424	424
query30	277	215	183	183
query31	920	856	790	790
query32	66	63	58	58
query33	548	381	293	293
query34	795	831	521	521
query35	762	803	732	732
query36	964	1010	900	900
query37	104	95	70	70
query38	4111	4152	4105	4105
query39	1491	1441	1413	1413
query40	211	114	105	105
query41	57	53	75	53
query42	115	103	107	103
query43	502	527	494	494
query44	1372	820	833	820
query45	176	163	164	163
query46	842	996	618	618
query47	1763	1830	1738	1738
query48	394	408	313	313
query49	710	467	376	376
query50	617	681	403	403
query51	5649	5522	5395	5395
query52	114	103	95	95
query53	220	256	179	179
query54	561	561	487	487
query55	81	77	80	77
query56	289	301	286	286
query57	1199	1207	1104	1104
query58	262	253	259	253
query59	2628	2629	2637	2629
query60	334	343	290	290
query61	125	119	123	119
query62	779	711	665	665
query63	229	183	188	183
query64	4309	996	663	663
query65	4284	4176	4175	4175
query66	1148	399	341	341
query67	15902	15790	15316	15316
query68	8856	890	527	527
query69	530	328	280	280
query70	1259	1167	1158	1158
query71	456	318	322	318
query72	5836	4776	4916	4776
query73	744	672	372	372
query74	8968	9033	9012	9012
query75	4163	3196	2703	2703
query76	3659	1153	717	717
query77	783	373	284	284
query78	10048	10271	9414	9414
query79	1620	894	578	578
query80	617	529	454	454
query81	470	251	230	230
query82	255	127	97	97
query83	281	307	237	237
query84	287	105	83	83
query85	763	358	312	312
query86	332	307	276	276
query87	4590	4572	4329	4329
query88	2901	2366	2280	2280
query89	381	319	296	296
query90	2066	206	220	206
query91	152	147	109	109
query92	76	66	58	58
query93	1107	938	587	587
query94	667	403	299	299
query95	375	301	289	289
query96	496	571	280	280
query97	2723	2768	2615	2615
query98	221	211	205	205
query99	1419	1426	1312	1312
Total cold run time: 277040 ms
Total hot run time: 187624 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9924e9fc873ef427aafb6e1123d47a4ee9ce228d, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.26	0.07	0.07
query4	1.62	0.11	0.11
query5	0.45	0.45	0.41
query6	1.15	0.66	0.68
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.58	0.57	0.57
query11	0.15	0.11	0.10
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	0.81	0.82	0.81
query15	0.90	0.86	0.88
query16	0.39	0.38	0.40
query17	1.08	1.04	1.05
query18	0.22	0.22	0.21
query19	2.01	1.88	1.83
query20	0.02	0.01	0.02
query21	15.37	0.88	0.53
query22	0.75	1.06	0.77
query23	14.93	1.40	0.65
query24	6.57	1.66	1.59
query25	0.48	0.25	0.13
query26	0.66	0.16	0.13
query27	0.07	0.05	0.06
query28	9.99	0.85	0.45
query29	12.54	4.02	3.29
query30	3.06	3.04	2.99
query31	2.83	0.60	0.39
query32	3.24	0.58	0.48
query33	3.05	3.25	3.10
query34	15.98	5.39	4.79
query35	4.82	4.84	4.88
query36	0.68	0.50	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.7 s
Total hot run time: 33.42 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 15.38% (2/13) 🎉
Increment coverage report
Complete coverage report

@924060929 924060929 force-pushed the fix_round_bankers branch from 9924e9f to 72710e6 Compare July 16, 2025 11:20
@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33968 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 72710e60c49865eb43c014fb72a519990186285f, data reload: false

------ Round 1 ----------------------------------
q1	17564	5205	5071	5071
q2	1932	292	185	185
q3	10288	1265	709	709
q4	10210	1003	523	523
q5	7532	2383	2501	2383
q6	178	154	127	127
q7	886	733	592	592
q8	9293	1244	1065	1065
q9	6724	5062	5100	5062
q10	6893	2382	1973	1973
q11	511	282	275	275
q12	342	341	218	218
q13	17781	3767	3212	3212
q14	241	237	225	225
q15	532	486	482	482
q16	441	456	377	377
q17	597	861	368	368
q18	7629	7088	7035	7035
q19	1211	959	563	563
q20	344	326	232	232
q21	3901	2517	2332	2332
q22	1039	1007	959	959
Total cold run time: 106069 ms
Total hot run time: 33968 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5161	5121	5146	5121
q2	249	323	221	221
q3	2157	2621	2304	2304
q4	1334	1757	1305	1305
q5	4229	4397	4515	4397
q6	214	170	130	130
q7	2069	1907	1793	1793
q8	2682	2684	2475	2475
q9	7246	7288	7267	7267
q10	3093	3289	2884	2884
q11	572	520	488	488
q12	753	780	653	653
q13	3607	3997	3311	3311
q14	280	318	268	268
q15	527	465	476	465
q16	441	503	457	457
q17	1172	1568	1377	1377
q18	7805	7895	7423	7423
q19	820	831	1009	831
q20	1893	1985	1808	1808
q21	4674	4409	4260	4260
q22	1026	1024	1001	1001
Total cold run time: 52004 ms
Total hot run time: 50239 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187090 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72710e60c49865eb43c014fb72a519990186285f, data reload: false

query1	994	377	424	377
query2	6707	1720	1692	1692
query3	6806	220	210	210
query4	26920	23403	23281	23281
query5	4317	565	444	444
query6	305	221	210	210
query7	4613	481	287	287
query8	256	233	209	209
query9	8586	2619	2611	2611
query10	479	330	276	276
query11	15751	15003	14795	14795
query12	153	104	100	100
query13	1646	541	393	393
query14	8527	5826	5835	5826
query15	198	196	170	170
query16	7119	632	462	462
query17	1002	688	592	592
query18	1972	395	305	305
query19	192	182	154	154
query20	124	117	120	117
query21	209	122	105	105
query22	4191	4486	4290	4290
query23	33890	33241	33220	33220
query24	8479	2370	2366	2366
query25	525	476	382	382
query26	1249	265	144	144
query27	2778	495	337	337
query28	4313	2132	2095	2095
query29	763	542	432	432
query30	285	219	181	181
query31	892	842	743	743
query32	69	64	58	58
query33	564	351	314	314
query34	802	825	517	517
query35	796	814	742	742
query36	976	1009	919	919
query37	116	98	81	81
query38	4183	4136	4171	4136
query39	1498	1453	1449	1449
query40	218	125	110	110
query41	94	52	57	52
query42	118	102	109	102
query43	495	507	473	473
query44	1302	823	811	811
query45	175	168	166	166
query46	854	1026	623	623
query47	1809	1895	1787	1787
query48	376	431	308	308
query49	741	482	379	379
query50	626	689	412	412
query51	5458	5454	5420	5420
query52	105	103	95	95
query53	215	250	185	185
query54	555	575	513	513
query55	79	75	82	75
query56	319	291	295	291
query57	1185	1204	1132	1132
query58	266	250	252	250
query59	2595	2705	2630	2630
query60	325	324	311	311
query61	120	125	124	124
query62	790	696	648	648
query63	221	186	189	186
query64	4358	1015	734	734
query65	4244	4216	4189	4189
query66	1152	420	370	370
query67	16341	15515	15768	15515
query68	7558	882	532	532
query69	485	305	261	261
query70	1200	1149	1104	1104
query71	420	333	299	299
query72	5568	4608	4681	4608
query73	633	555	350	350
query74	8862	9142	8786	8786
query75	3204	3243	2688	2688
query76	3175	1159	722	722
query77	497	398	288	288
query78	9946	10016	9379	9379
query79	2038	813	567	567
query80	601	533	441	441
query81	480	258	226	226
query82	211	125	92	92
query83	242	242	232	232
query84	280	108	82	82
query85	779	361	318	318
query86	331	324	296	296
query87	4460	4420	4360	4360
query88	3780	2319	2285	2285
query89	406	310	289	289
query90	1953	203	206	203
query91	137	139	116	116
query92	76	59	54	54
query93	1629	932	595	595
query94	695	467	312	312
query95	375	287	277	277
query96	505	559	285	285
query97	2693	2766	2674	2674
query98	239	204	194	194
query99	1347	1394	1262	1262
Total cold run time: 273186 ms
Total hot run time: 187090 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 72710e60c49865eb43c014fb72a519990186285f, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.05	0.04
query3	0.25	0.07	0.08
query4	1.63	0.11	0.11
query5	0.44	0.41	0.43
query6	1.16	0.65	0.68
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.51	0.51
query10	0.59	0.57	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.61
query14	0.80	0.83	0.80
query15	0.92	0.85	0.86
query16	0.39	0.40	0.39
query17	1.09	1.09	1.05
query18	0.23	0.23	0.21
query19	1.96	1.81	1.83
query20	0.02	0.01	0.01
query21	15.39	0.90	0.53
query22	0.75	1.14	0.89
query23	14.72	1.41	0.67
query24	6.66	1.92	0.62
query25	0.48	0.25	0.11
query26	0.62	0.18	0.15
query27	0.07	0.06	0.05
query28	9.59	0.95	0.46
query29	12.58	3.99	3.28
query30	3.07	3.02	2.93
query31	2.82	0.58	0.39
query32	3.23	0.55	0.47
query33	3.09	3.16	3.15
query34	16.12	5.41	4.78
query35	4.84	4.79	4.87
query36	0.72	0.51	0.49
query37	0.09	0.06	0.06
query38	0.05	0.05	0.03
query39	0.03	0.03	0.02
query40	0.18	0.15	0.15
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.05	0.03	0.03
Total cold run time: 106.47 s
Total hot run time: 32.49 s

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33705 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93070e9b1b62f3190e846b760bbebcf4e3aac2be, data reload: false

------ Round 1 ----------------------------------
q1	17591	5252	5280	5252
q2	1940	268	183	183
q3	10314	1435	712	712
q4	10218	1211	521	521
q5	7514	2364	2274	2274
q6	179	166	134	134
q7	921	759	623	623
q8	9298	1282	1021	1021
q9	6799	5223	5090	5090
q10	6885	2360	1968	1968
q11	462	277	274	274
q12	348	364	219	219
q13	17780	3504	2995	2995
q14	235	238	217	217
q15	549	464	471	464
q16	429	428	383	383
q17	580	838	351	351
q18	7607	7160	7047	7047
q19	2501	972	552	552
q20	320	316	212	212
q21	3384	3027	2258	2258
q22	1020	1055	955	955
Total cold run time: 106874 ms
Total hot run time: 33705 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5483	5277	5328	5277
q2	239	305	216	216
q3	2077	2572	2204	2204
q4	1325	1723	1323	1323
q5	4127	4438	4473	4438
q6	223	180	135	135
q7	1937	2043	1863	1863
q8	2572	2508	2426	2426
q9	7425	7383	7474	7383
q10	3298	3290	2977	2977
q11	537	498	517	498
q12	739	806	593	593
q13	3475	3779	3234	3234
q14	296	316	298	298
q15	502	460	451	451
q16	443	489	423	423
q17	1159	1523	1398	1398
q18	7887	7833	7617	7617
q19	13549	945	907	907
q20	2788	2019	2016	2016
q21	14550	4225	4257	4225
q22	1101	1025	1002	1002
Total cold run time: 75732 ms
Total hot run time: 50904 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93070e9b1b62f3190e846b760bbebcf4e3aac2be, data reload: false

============================================
query1	1000	396	424	396
query2	6496	1820	1699	1699
query3	6744	232	230	230
query4	26745	23634	23198	23198
query5	4359	642	536	536
query6	309	245	227	227
query7	4633	545	299	299
query8	281	257	226	226
query9	8582	2991	2967	2967
query10	473	360	313	313
query11	15912	14958	14785	14785
query12	187	139	139	139
query13	1667	545	414	414
query14	8704	5943	5900	5900
query15	223	187	176	176
query16	7137	677	495	495
query17	1235	791	632	632
query18	2209	467	332	332
query19	233	219	197	197
query20	158	146	140	140
query21	221	130	111	111
query22	3915	4202	3774	3774
query23	34578	34454	34382	34382
query24	8115	2445	2424	2424
query25	571	507	441	441
query26	1120	288	162	162
query27	2672	496	362	362
query28	4355	2347	2338	2338
query29	811	611	539	539
query30	300	232	201	201
query31	894	817	716	716
query32	87	78	84	78
query33	560	417	386	386
query34	826	829	563	563
query35	792	889	749	749
query36	1018	1047	961	961
query37	136	115	99	99
query38	4015	4014	3929	3929
query39	1449	1384	1376	1376
query40	250	147	138	138
query41	62	58	54	54
query42	147	122	134	122
query43	531	504	487	487
query44	1405	892	870	870
query45	193	194	189	189
query46	952	1048	665	665
query47	1789	1828	1733	1733
query48	408	435	323	323
query49	717	500	416	416
query50	655	710	409	409
query51	4207	4218	4168	4168
query52	132	133	126	126
query53	260	286	217	217
query54	662	638	564	564
query55	91	94	93	93
query56	351	356	360	356
query57	1196	1232	1162	1162
query58	343	330	339	330
query59	2676	2696	2533	2533
query60	420	379	386	379
query61	126	127	128	127
query62	841	742	651	651
query63	252	219	238	219
query64	4353	1117	769	769
query65	4223	4140	4170	4140
query66	1047	462	337	337
query67	query68	19450	1133	910	910
query69	993	284	302	284
query70	1478	1146	1093	1093
query71	669	345	338	338
query72	9102	2367	2663	2367
query73	4002	686	358	358
query74	8976	9007	8921	8921
query75	7404	3110	2667	2667
query76	8410	1233	790	790
query77	1169	413	348	348
query78	9592	11113	9535	9535
query79	15533	641	595	595
query80	3173	572	585	572
query81	551	264	232	232
query82	552	161	122	122
query83	405	291	274	274
query84	301	99	90	90
query85	1156	386	401	386
query86	358	326	301	301
query87	4247	4167	4106	4106
query88	5603	2266	2245	2245
query89	504	378	316	316
query90	2487	240	232	232
query91	150	155	114	114
query92	91	75	68	68
query93	6609	1012	664	664
query94	1261	398	281	281
query95	433	339	333	333
query96	521	601	287	287
query97	2728	2740	2572	2572
query98	260	237	221	221
query99	1482	1424	1261	1261
Total cold run time: 311661 ms
Total hot run time: 171352 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93070e9b1b62f3190e846b760bbebcf4e3aac2be, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.07	0.08
query4	1.61	0.11	0.11
query5	0.42	0.41	0.41
query6	1.14	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.48	0.46
query10	0.52	0.52	0.53
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.65	0.63	0.64
query14	0.89	1.30	0.88
query15	0.97	0.88	0.88
query16	0.39	0.40	0.39
query17	1.07	1.06	1.07
query18	0.22	0.21	0.20
query19	1.88	1.92	1.90
query20	0.02	0.01	0.02
query21	15.38	0.86	0.55
query22	0.78	1.22	0.83
query23	14.76	1.21	0.63
query24	6.96	1.29	0.81
query25	0.49	0.18	0.13
query26	0.58	0.15	0.13
query27	0.06	0.06	0.05
query28	9.54	0.87	0.45
query29	12.59	3.81	3.32
query30	3.03	3.06	3.02
query31	2.82	0.58	0.41
query32	3.29	0.57	0.48
query33	3.00	3.20	3.27
query34	16.15	5.43	4.95
query35	4.93	4.97	4.92
query36	0.70	0.53	0.51
query37	0.10	0.07	0.08
query38	0.06	0.06	0.04
query39	0.03	0.03	0.03
query40	0.16	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.67 s
Total hot run time: 33.25 s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 3315f6a into apache:master Aug 5, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants