-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) keep idempotent of function signature #52447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33938 ms |
TPC-DS: Total hot run time: 185788 ms |
ClickBench: Total hot run time: 29.67 s |
FE UT Coverage ReportIncrement line coverage |
a2c1757 to
1d2f04e
Compare
|
run buildall |
TPC-H: Total hot run time: 33979 ms |
TPC-DS: Total hot run time: 185070 ms |
ClickBench: Total hot run time: 29.7 s |
|
run buildall |
TPC-H: Total hot run time: 33452 ms |
TPC-DS: Total hot run time: 184655 ms |
ClickBench: Total hot run time: 29.83 s |
FE UT Coverage ReportIncrement line coverage |
...main/java/org/apache/doris/nereids/trees/expressions/functions/ComputePrecisionForRound.java
Show resolved
Hide resolved
4a33b04 to
fb75699
Compare
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 34016 ms |
TPC-DS: Total hot run time: 187624 ms |
ClickBench: Total hot run time: 33.42 s |
FE UT Coverage ReportIncrement line coverage |
9924e9f to
72710e6
Compare
|
run buildall |
TPC-H: Total hot run time: 33968 ms |
TPC-DS: Total hot run time: 187090 ms |
ClickBench: Total hot run time: 32.49 s |
f1bd938 to
93070e9
Compare
|
run buildall |
TPC-H: Total hot run time: 33705 ms |
TPC-DS: Total hot run time: 171352 ms |
ClickBench: Total hot run time: 33.25 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
this sql will throw exception:
The scale of return type of the round_bankers function depends on the type of its arguments. If the second argument is an integer constant, that constant is used as the scale. If it is not a constant, the scale of the first argument is used instead. This leads to a problem: for expressions like
1 - 2, the scale used in the computation differs before and after constant folding, which can cause the Backend to throw an exception: type mismatchSo we need to fold the arguments into constants before binding the function, to ensure that the scale will not change
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)