-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) Fix profile lock table,translate summary time err and add ut test #52601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) Fix profile lock table,translate summary time err and add ut test #52601
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
| if (statementContext.getConnectContext().getExecutor() != null) { | ||
| statementContext.getConnectContext().getExecutor().getSummaryProfile().setNereidsDistributeTime(); | ||
| statementContext.getConnectContext().getExecutor().getSummaryProfile() | ||
| .setNereidsDistributeTime(TimeUtils.getStartTimeMs()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why move TimeUtils.getStartTimeMs() in parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TimeUtils.getStartTimeMs() is passed in as a parameter to facilitate better unit testing, as the unit tests need to control and assert based on a fixed time.
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33531 ms |
TPC-DS: Total hot run time: 184460 ms |
ClickBench: Total hot run time: 29.19 s |
26c9d03 to
382e09a
Compare
|
run buildall |
TPC-H: Total hot run time: 33813 ms |
TPC-DS: Total hot run time: 186834 ms |
ClickBench: Total hot run time: 32.73 s |
0974e81 to
3cd899d
Compare
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 34288 ms |
TPC-DS: Total hot run time: 186894 ms |
ClickBench: Total hot run time: 32.62 s |
FE UT Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
3010c9a to
779bac0
Compare
|
run buildall |
TPC-H: Total hot run time: 34848 ms |
TPC-DS: Total hot run time: 189687 ms |
ClickBench: Total hot run time: 29.78 s |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
…add ut test (apache#52601) 1. Nereids Translate Time should be after method `PhysicalPlanTranslator#translatePlan` 2. fix 2.1 and 3.0 `Parse SQL Time` and `Nereids Lock Table Time` has the same parseSqlStartTime. Related PR: apache#39670 apache#45679
What problem does this PR solve?
PhysicalPlanTranslator#translatePlanParse SQL TimeandNereids Lock Table Timehas the same parseSqlStartTime.Issue Number: close #xxx
Related PR: #39670 #45679
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)