Skip to content

branch-3.1: [fix](mow) fix potential mem leak for DeleteBitmap::AggCache #52596 #52614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 2, 2025
Merged

branch-3.1: [fix](mow) fix potential mem leak for DeleteBitmap::AggCache #52596 #52614

morrySnow merged 1 commit into from
Jul 2, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

Cherry-picked from #52596

[fix](mow) fix potential mem leak for DeleteBitmap::AggCache (#52596)
76f4a5c 
Problem Summary:

DeleteBitmap::AggCache use a singleton to manage the memory of LRUCache.
It needs to release the cache memory at program exit.
@github-actions github-actions bot requested a review from morrySnow as a code owner July 1, 2025 13:41
@morrySnow morrySnow closed this Jul 2, 2025
@morrySnow morrySnow reopened this Jul 2, 2025
@morrySnow
Copy link
Contributor

morrySnow commented Jul 2, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 2, 2025

TPC-H: Total hot run time: 40062 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 76f4a5c18134c0481526ae3e74334a9d498d3c61, data reload: false

------ Round 1 ----------------------------------
q1	17638	6954	6631	6631
q2	2079	211	164	164
q3	10611	1142	1194	1142
q4	10419	772	716	716
q5	7759	2886	2805	2805
q6	214	134	136	134
q7	993	621	628	621
q8	9355	1973	2060	1973
q9	6734	6453	6445	6445
q10	6991	2266	2295	2266
q11	454	269	266	266
q12	397	220	215	215
q13	17782	2972	3011	2972
q14	234	204	204	204
q15	500	460	477	460
q16	441	372	370	370
q17	998	608	586	586
q18	7387	6725	6667	6667
q19	1307	1002	995	995
q20	485	202	204	202
q21	3923	3313	3242	3242
q22	1113	1012	986	986
Total cold run time: 107814 ms
Total hot run time: 40062 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6623	6582	6552	6552
q2	326	225	232	225
q3	2919	3011	3028	3011
q4	2052	1790	1833	1790
q5	5731	5736	5744	5736
q6	209	127	129	127
q7	2185	1769	1810	1769
q8	3397	3565	3552	3552
q9	8725	8845	8817	8817
q10	3580	3571	3535	3535
q11	600	483	483	483
q12	818	598	586	586
q13	8346	3227	3139	3139
q14	297	278	281	278
q15	513	458	461	458
q16	488	459	455	455
q17	1843	1606	1618	1606
q18	8294	7808	7926	7808
q19	1679	1506	1460	1460
q20	2070	1825	1880	1825
q21	5157	5065	5004	5004
q22	1148	1098	1043	1043
Total cold run time: 67000 ms
Total hot run time: 59259 ms

@doris-robot
Copy link

doris-robot commented Jul 2, 2025

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.06% (12384/27485)
Line Coverage 36.04% (109634/304225)
Region Coverage 35.12% (56825/161817)
Branch Coverage 32.24% (30823/95604)

@doris-robot
Copy link

doris-robot commented Jul 2, 2025

TPC-DS: Total hot run time: 197431 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 76f4a5c18134c0481526ae3e74334a9d498d3c61, data reload: false

query1	1296	901	907	901
query2	6274	1998	1982	1982
query3	10941	4401	4538	4401
query4	32878	23448	23493	23448
query5	3531	455	442	442
query6	264	178	175	175
query7	4012	314	315	314
query8	295	238	236	236
query9	9394	2560	2556	2556
query10	473	281	253	253
query11	17957	15216	15171	15171
query12	159	100	105	100
query13	1557	443	428	428
query14	9777	7329	6844	6844
query15	271	177	205	177
query16	8013	499	514	499
query17	1603	615	598	598
query18	2171	329	326	326
query19	370	179	173	173
query20	129	119	121	119
query21	204	125	111	111
query22	4710	4390	4564	4390
query23	34826	34409	34287	34287
query24	11413	2869	2916	2869
query25	668	433	446	433
query26	1488	174	175	174
query27	2741	352	367	352
query28	7477	2190	2150	2150
query29	898	473	475	473
query30	265	170	169	169
query31	1074	816	817	816
query32	99	59	58	58
query33	765	299	313	299
query34	955	499	507	499
query35	854	751	733	733
query36	1130	944	935	935
query37	127	72	66	66
query38	4136	4012	4006	4006
query39	1511	1504	1503	1503
query40	262	106	104	104
query41	47	48	48	48
query42	122	100	99	99
query43	533	496	505	496
query44	1254	814	809	809
query45	189	181	179	179
query46	1185	750	725	725
query47	2089	1998	1998	1998
query48	423	342	348	342
query49	1032	418	379	379
query50	864	442	432	432
query51	7336	7350	7264	7264
query52	98	93	88	88
query53	275	191	187	187
query54	1187	477	467	467
query55	78	79	83	79
query56	274	274	238	238
query57	1359	1208	1221	1208
query58	244	213	217	213
query59	3313	3232	3248	3232
query60	300	259	276	259
query61	120	113	118	113
query62	868	714	713	713
query63	219	192	193	192
query64	4115	704	652	652
query65	3345	3350	3275	3275
query66	915	315	295	295
query67	15920	15527	15619	15527
query68	4882	590	574	574
query69	440	265	266	265
query70	1100	1061	1112	1061
query71	343	268	256	256
query72	6375	4026	4112	4026
query73	744	349	356	349
query74	10726	9172	9098	9098
query75	3329	2613	2646	2613
query76	2640	1071	1038	1038
query77	433	272	266	266
query78	10753	9797	9543	9543
query79	1425	598	591	591
query80	1137	462	460	460
query81	530	218	213	213
query82	867	91	90	90
query83	227	143	144	143
query84	236	81	83	81
query85	1352	311	296	296
query86	384	292	289	289
query87	4430	4210	4222	4210
query88	3396	2370	2310	2310
query89	409	295	291	291
query90	1880	186	183	183
query91	141	106	108	106
query92	63	52	50	50
query93	1681	559	562	559
query94	789	292	285	285
query95	360	257	257	257
query96	614	274	273	273
query97	3289	3103	3238	3103
query98	208	216	199	199
query99	1525	1274	1319	1274
Total cold run time: 301380 ms
Total hot run time: 197431 ms

@morrySnow morrySnow merged commit 06f494c into branch-3.1 Jul 2, 2025
19 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-52596-branch-3.1 branch July 2, 2025 11:23
etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025
@github-actions @etah000
branch-3.1: [fix](mow) fix potential mem leak for DeleteBitmap::AggCa…
e3f3638 
…che apache#52596 (apache#52614)

Cherry-picked from apache#52596

Co-authored-by: zhannngchen <zhangchen@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morrySnow @doris-robot