-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](mow) Move DeleteBitmapAggCache to ExecEnv
#52649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
324ad3a to
2ae3265
Compare
2ae3265 to
d9ca8b6
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34084 ms |
TPC-DS: Total hot run time: 186935 ms |
ClickBench: Total hot run time: 29.37 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33919 ms |
TPC-DS: Total hot run time: 186305 ms |
ClickBench: Total hot run time: 29.32 s |
Contributor
Author
|
run buildall |
b25d8d0 to
4c51757
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 183919 ms |
ClickBench: Total hot run time: 29.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Collaborator
|
run cloud_p0 |
hello-stephen
approved these changes
Jul 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
### What problem does this PR solve? fix #52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Jul 3, 2025
fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Jul 3, 2025
fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jul 4, 2025
### What problem does this PR solve? fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jul 4, 2025
### What problem does this PR solve? fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jul 4, 2025
### What problem does this PR solve? fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 4, 2025
### What problem does this PR solve? fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Jul 7, 2025
fix apache#52596, DeleteBitmapAggCache should be destructed before CacheManager ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /root/doris/be/src/runtime/memory/cache_policy.cpp:35:31 *** Query id: 0-0 *** *** is nereids: 0 *** *** tablet id: 0 *** *** Aborted at 1751405577 (unix time) try "date -d @1751405577" if you are using GNU date *** *** Current BE git commitID: cd35cf0eb5 *** *** SIGSEGV address not mapped to object (@0x10) received by PID 15013 (TID 15013 OR 0x7fced202a4c0) from PID 16; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# PosixSignals::chained_handler(int, siginfo_t*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007FCED2404090 in /lib/x86_64-linux-gnu/libc.so.6 4# __pthread_mutex_lock at ../nptl/pthread_mutex_lock.c:67 5# doris::CacheManager::unregister_cache(doris::CachePolicy::CacheType) at /root/doris/be/src/runtime/memory/cache_manager.h:56 6# doris::CachePolicy::~CachePolicy() at /root/doris/be/src/runtime/memory/cache_policy.cpp:36 7# doris::DeleteBitmap::AggCachePolicy::~AggCachePolicy() at /root/doris/be/src/olap/tablet_meta.h:568 8# __run_exit_handlers at /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:109 9# on_exit at /build/glibc-SzIz7B/glibc-2.31/stdlib/on_exit.c:26 10# __libc_start_main at ../csu/libc-start.c:261 11# _start in /home/work/unlimit_teamcity/TeamCity/Agents/20250702042258agent_172.16.0.200_1/work/60183217f6ee2a9c/output/be/lib/doris_be
etah000
pushed a commit
to etah000/doris
that referenced
this pull request
Jul 7, 2025
…e#52649 (apache#52705) Cherry-picked from apache#52649 Co-authored-by: bobhan1 <baohan@selectdb.com>
dataroaring
pushed a commit
that referenced
this pull request
Jul 8, 2025
yiguolei
pushed a commit
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.11-merged
dev/3.0.7-merged
dev/3.1.0-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #52596, DeleteBitmapAggCache should be destructed before CacheManager
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)