[fix](nereids) fix insert into values throw 'Invalid call to sql on unbound object' and 'Insert has filtered data in strict mode' exception #52802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Jul 4, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33478 ms |
TPC-DS: Total hot run time: 184614 ms |
ClickBench: Total hot run time: 29.23 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
924060929
force-pushed
the
fix_insert_into_values
branch
from
b7e5cfb to
e06f84c
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32956 ms |
TPC-DS: Total hot run time: 184986 ms |
ClickBench: Total hot run time: 29.33 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33362 ms |
TPC-DS: Total hot run time: 188030 ms |
ClickBench: Total hot run time: 30.06 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33087 ms |
TPC-DS: Total hot run time: 185149 ms |
ClickBench: Total hot run time: 29.85 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
starocean999
approved these changes
Jul 10, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morrySnow
approved these changes
Jul 10, 2025
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Jul 10, 2025
…nbound object' and 'Insert has filtered data in strict mode' exception (apache#52802) 1. fix `Invalid call to sql on unbound object` when use `interval`, introduced by apache#40202 ```sql CREATE TABLE `test_insert_cast_interval` ( `id` int NULL, `dt` date NULL ) ENGINE=OLAP DISTRIBUTED BY HASH(`id`) BUCKETS 10 PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); INSERT INTO test_insert_cast_interval values(1, date_floor('2020-02-02', interval 1 second)); (1105, 'errCode = 2, detailMessage = Invalid call to sql on unbound object') ``` 2. fix `Insert has filtered data in strict mode`, introduced by apache#49116 ```sql CREATE TABLE `test_insert_more_string` ( `r_regionkey` int NULL, `r_name` varchar(25) NULL, `r_comment` varchar(152) NULL ) ENGINE=OLAP DISTRIBUTED BY HASH(`r_regionkey`) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1"); insert into test_insert_more_string values (3, "akljalkjbalkjsldkrjewokjfalksdjflaksjfdlaskjfalsdkfjalsdfjkasfdl", "aa"); (1105, 'errCode = 2, detailMessage = Insert has filtered data in strict mode') ``` (cherry picked from commit 2c01f69)
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Jul 14, 2025
…nbound object' and 'Insert has filtered data in strict mode' exception (apache#52802) 1. fix `Invalid call to sql on unbound object` when use `interval`, introduced by apache#40202 ```sql CREATE TABLE `test_insert_cast_interval` ( `id` int NULL, `dt` date NULL ) ENGINE=OLAP DISTRIBUTED BY HASH(`id`) BUCKETS 10 PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); INSERT INTO test_insert_cast_interval values(1, date_floor('2020-02-02', interval 1 second)); (1105, 'errCode = 2, detailMessage = Invalid call to sql on unbound object') ``` 2. fix `Insert has filtered data in strict mode`, introduced by apache#49116 ```sql CREATE TABLE `test_insert_more_string` ( `r_regionkey` int NULL, `r_name` varchar(25) NULL, `r_comment` varchar(152) NULL ) ENGINE=OLAP DISTRIBUTED BY HASH(`r_regionkey`) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1"); insert into test_insert_more_string values (3, "akljalkjbalkjsldkrjewokjfalksdjflaksjfdlaskjfalsdkfjalsdfjkasfdl", "aa"); (1105, 'errCode = 2, detailMessage = Insert has filtered data in strict mode') ``` (cherry picked from commit 2c01f69)
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Aug 26, 2025
16 tasks
924060929
pushed a commit
that referenced
this pull request
Aug 28, 2025
…r insert value truncate long string (#55325) for below sql: ```sql create table t(a int, b varchar(2)); insert into t values(1, 'abcde'); ``` for doris 2.0, the insert command will throw error 'Insert has filtered data in strict mode', because length of value 'abcde' is bigger than varchar(2). for mysql, pg, the above sql will also throw error for the same reason. for doris version >= 2.1.0, it will not throw error, and just truncate 'abcde' to 'ab'. what's more, for stream load, no matter 2.0, or 2.1, ..., doris will stream load fail. but considering 2.1 have released for 1.5+ year, we don't want to make a behaviour change for 2.1, so add a session variable enable_insert_value_auto_cast, when insert value with longer string value, then will have: - if enable_insert_value_auto_cast = true (default), the longer string will be truncate and insert succ; - if enable_insert_value_auto_cast = false, enable_insert_strict = true(default), will throw exception 'Insert has filtered data in strict mode'; - if enable_insert_value_auto_cast = false, enable_insert_strict = false, then the longer string will be filtered, other rows will insert succ. relate PR: #52802
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
…r insert value truncate long string (#55325) for below sql: ```sql create table t(a int, b varchar(2)); insert into t values(1, 'abcde'); ``` for doris 2.0, the insert command will throw error 'Insert has filtered data in strict mode', because length of value 'abcde' is bigger than varchar(2). for mysql, pg, the above sql will also throw error for the same reason. for doris version >= 2.1.0, it will not throw error, and just truncate 'abcde' to 'ab'. what's more, for stream load, no matter 2.0, or 2.1, ..., doris will stream load fail. but considering 2.1 have released for 1.5+ year, we don't want to make a behaviour change for 2.1, so add a session variable enable_insert_value_auto_cast, when insert value with longer string value, then will have: - if enable_insert_value_auto_cast = true (default), the longer string will be truncate and insert succ; - if enable_insert_value_auto_cast = false, enable_insert_strict = true(default), will throw exception 'Insert has filtered data in strict mode'; - if enable_insert_value_auto_cast = false, enable_insert_strict = false, then the longer string will be filtered, other rows will insert succ. relate PR: #52802
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Aug 29, 2025
…r insert value truncate long string (apache#55325) for below sql: ```sql create table t(a int, b varchar(2)); insert into t values(1, 'abcde'); ``` for doris 2.0, the insert command will throw error 'Insert has filtered data in strict mode', because length of value 'abcde' is bigger than varchar(2). for mysql, pg, the above sql will also throw error for the same reason. for doris version >= 2.1.0, it will not throw error, and just truncate 'abcde' to 'ab'. what's more, for stream load, no matter 2.0, or 2.1, ..., doris will stream load fail. but considering 2.1 have released for 1.5+ year, we don't want to make a behaviour change for 2.1, so add a session variable enable_insert_value_auto_cast, when insert value with longer string value, then will have: - if enable_insert_value_auto_cast = true (default), the longer string will be truncate and insert succ; - if enable_insert_value_auto_cast = false, enable_insert_strict = true(default), will throw exception 'Insert has filtered data in strict mode'; - if enable_insert_value_auto_cast = false, enable_insert_strict = false, then the longer string will be filtered, other rows will insert succ. relate PR: apache#52802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Invalid call to sql on unbound objectwhen useinterval, introduced by [enhancement](nereids) improve lots of values ininsert into valuesstatement #40202Insert has filtered data in strict mode, introduced by [feature](nereids)support stream load, routine load and broker load in nereids #49116Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)