Skip to content

[opt](group_concat) allow args be types other than string #52805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 8, 2025
Merged

[opt](group_concat) allow args be types other than string #52805

morrySnow merged 1 commit into from
Jul 8, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Jul 4, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow changed the title [opt](group_concat) let args could be other type than varchar [opt](group_concat) allow args o be types other than string Jul 5, 2025
@morrySnow
Copy link
Contributor Author

morrySnow commented Jul 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

TPC-H: Total hot run time: 33572 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60720db83b3e3e6f23888cd9c86fccc96813a2c3, data reload: false

------ Round 1 ----------------------------------
q1	17588	5208	5025	5025
q2	1933	278	179	179
q3	10353	1300	689	689
q4	10286	991	497	497
q5	8422	2301	2342	2301
q6	186	160	126	126
q7	869	742	591	591
q8	9316	1263	1076	1076
q9	6766	5064	5104	5064
q10	6860	2338	1951	1951
q11	478	283	278	278
q12	338	348	218	218
q13	17783	3644	3095	3095
q14	237	227	210	210
q15	562	484	471	471
q16	414	417	375	375
q17	596	851	348	348
q18	7461	7200	7083	7083
q19	1331	934	529	529
q20	336	355	224	224
q21	3643	2540	2272	2272
q22	1073	1026	970	970
Total cold run time: 106831 ms
Total hot run time: 33572 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5094	5064	5064	5064
q2	237	328	218	218
q3	2169	2695	2313	2313
q4	1366	1748	1290	1290
q5	4207	4393	4523	4393
q6	227	170	126	126
q7	2130	2013	1870	1870
q8	2652	2594	2558	2558
q9	7232	7307	7294	7294
q10	3115	3305	2934	2934
q11	609	506	518	506
q12	844	783	633	633
q13	3608	3907	3321	3321
q14	292	303	295	295
q15	523	473	481	473
q16	443	499	469	469
q17	1196	1511	1429	1429
q18	7989	7738	7397	7397
q19	776	781	820	781
q20	1964	1992	1897	1897
q21	4777	4419	4267	4267
q22	1056	1005	966	966
Total cold run time: 52506 ms
Total hot run time: 50494 ms

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

TPC-DS: Total hot run time: 184730 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60720db83b3e3e6f23888cd9c86fccc96813a2c3, data reload: false

query1	976	375	370	370
query2	6538	1652	1633	1633
query3	6736	212	207	207
query4	26129	23706	23457	23457
query5	4351	582	458	458
query6	297	221	205	205
query7	4642	504	289	289
query8	279	219	235	219
query9	8626	2609	2614	2609
query10	462	344	267	267
query11	15271	14998	15203	14998
query12	155	107	100	100
query13	1653	525	421	421
query14	9050	5697	5750	5697
query15	201	185	189	185
query16	7494	634	451	451
query17	1213	729	596	596
query18	2011	410	316	316
query19	199	201	167	167
query20	123	117	119	117
query21	209	123	110	110
query22	4135	4316	3930	3930
query23	34119	33176	32951	32951
query24	8392	2359	2364	2359
query25	510	478	400	400
query26	1214	268	146	146
query27	2755	509	350	350
query28	4283	2119	2094	2094
query29	763	586	428	428
query30	284	218	196	196
query31	907	817	750	750
query32	69	65	62	62
query33	568	356	326	326
query34	788	828	517	517
query35	795	801	735	735
query36	939	973	887	887
query37	109	102	80	80
query38	4094	4156	4095	4095
query39	1522	1412	1421	1412
query40	209	114	105	105
query41	54	52	51	51
query42	125	106	113	106
query43	498	490	482	482
query44	1281	813	815	813
query45	191	163	159	159
query46	833	998	618	618
query47	1756	1828	1702	1702
query48	377	406	311	311
query49	745	496	389	389
query50	625	671	412	412
query51	4095	4113	4094	4094
query52	117	108	99	99
query53	225	280	192	192
query54	575	564	507	507
query55	83	78	85	78
query56	300	303	295	295
query57	1182	1189	1104	1104
query58	260	260	254	254
query59	2567	2591	2466	2466
query60	316	304	291	291
query61	126	120	122	120
query62	797	683	658	658
query63	217	183	184	183
query64	4304	988	651	651
query65	4272	4129	4171	4129
query66	1090	411	337	337
query67	15797	15345	15420	15345
query68	8007	889	534	534
query69	471	337	272	272
query70	1233	1134	1087	1087
query71	446	315	309	309
query72	5608	4622	4620	4620
query73	683	566	342	342
query74	8860	8811	8989	8811
query75	3698	3177	2699	2699
query76	3625	1161	720	720
query77	788	376	285	285
query78	9908	10196	9305	9305
query79	1750	832	569	569
query80	611	524	516	516
query81	471	254	228	228
query82	413	129	92	92
query83	249	257	247	247
query84	258	103	81	81
query85	787	360	376	360
query86	339	297	290	290
query87	4468	4440	4372	4372
query88	2888	2235	2249	2235
query89	384	320	280	280
query90	1935	203	199	199
query91	143	141	113	113
query92	76	56	59	56
query93	1071	944	589	589
query94	676	420	308	308
query95	379	291	283	283
query96	497	561	277	277
query97	2681	2764	2640	2640
query98	234	206	199	199
query99	1410	1408	1271	1271
Total cold run time: 270925 ms
Total hot run time: 184730 ms

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

ClickBench: Total hot run time: 29.08 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60720db83b3e3e6f23888cd9c86fccc96813a2c3, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.61	0.11	0.11
query5	0.44	0.43	0.40
query6	1.18	0.66	0.65
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.52	0.52
query10	0.57	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.63	0.63	0.62
query14	0.79	0.80	0.81
query15	0.89	0.88	0.88
query16	0.39	0.38	0.40
query17	1.08	1.06	1.07
query18	0.23	0.21	0.21
query19	1.93	1.88	1.91
query20	0.02	0.01	0.01
query21	15.39	0.90	0.56
query22	0.75	1.18	0.69
query23	14.88	1.38	0.63
query24	7.68	0.81	0.35
query25	0.54	0.19	0.06
query26	0.48	0.17	0.13
query27	0.07	0.05	0.05
query28	9.68	0.91	0.44
query29	12.56	3.95	3.30
query30	0.24	0.09	0.06
query31	2.85	0.60	0.38
query32	3.24	0.54	0.46
query33	3.15	3.03	3.08
query34	16.11	5.43	4.81
query35	4.81	4.86	4.80
query36	0.69	0.50	0.48
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.02	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 104.69 s
Total hot run time: 29.08 s

@morrySnow
Copy link
Contributor Author

morrySnow commented Jul 8, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/37) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-H: Total hot run time: 33530 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7303f1dbbdcc720e9faaaf531e7f4995c5662e85, data reload: false

------ Round 1 ----------------------------------
q1	17631	5223	5097	5097
q2	1938	285	186	186
q3	10304	1402	746	746
q4	10236	1053	522	522
q5	7755	2393	2386	2386
q6	183	160	132	132
q7	905	757	619	619
q8	9306	1309	1114	1114
q9	6840	5135	5071	5071
q10	6898	2404	1991	1991
q11	490	313	271	271
q12	338	359	212	212
q13	17786	3782	3142	3142
q14	232	223	220	220
q15	563	487	485	485
q16	439	424	398	398
q17	594	877	350	350
q18	7697	7273	7119	7119
q19	1215	981	552	552
q20	339	360	225	225
q21	3936	3231	2392	2392
q22	362	318	300	300
Total cold run time: 105987 ms
Total hot run time: 33530 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5208	5132	5146	5132
q2	247	321	221	221
q3	2203	2736	2319	2319
q4	1440	1855	1416	1416
q5	4269	4520	4553	4520
q6	222	168	122	122
q7	2094	1960	1839	1839
q8	2690	2591	2611	2591
q9	7225	7367	7292	7292
q10	3198	3279	2980	2980
q11	570	525	477	477
q12	720	799	646	646
q13	3808	3993	3482	3482
q14	288	326	286	286
q15	505	485	499	485
q16	465	498	447	447
q17	1235	1640	1375	1375
q18	7990	7700	7687	7687
q19	845	783	874	783
q20	1949	1953	1861	1861
q21	4819	4474	4414	4414
q22	663	585	560	560
Total cold run time: 52653 ms
Total hot run time: 50935 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-DS: Total hot run time: 185170 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7303f1dbbdcc720e9faaaf531e7f4995c5662e85, data reload: false

query1	1013	388	386	386
query2	6544	1728	1726	1726
query3	6748	212	207	207
query4	26240	23949	23010	23010
query5	4469	597	448	448
query6	303	240	210	210
query7	4623	516	303	303
query8	282	235	216	216
query9	8642	2603	2638	2603
query10	478	308	270	270
query11	15888	15082	14900	14900
query12	164	108	104	104
query13	1659	547	400	400
query14	9192	5763	5804	5763
query15	206	192	178	178
query16	7492	652	459	459
query17	1194	726	600	600
query18	2049	413	313	313
query19	207	198	163	163
query20	120	125	115	115
query21	216	124	106	106
query22	4067	4252	4030	4030
query23	34177	33154	33095	33095
query24	8429	2407	2432	2407
query25	538	506	414	414
query26	1231	260	150	150
query27	2749	501	347	347
query28	4307	2116	2115	2115
query29	717	578	445	445
query30	285	216	193	193
query31	900	827	761	761
query32	69	68	61	61
query33	556	371	312	312
query34	822	851	519	519
query35	769	829	738	738
query36	963	994	884	884
query37	108	106	79	79
query38	4182	4152	4169	4152
query39	1475	1410	1412	1410
query40	205	117	105	105
query41	57	56	51	51
query42	123	112	107	107
query43	501	530	480	480
query44	1367	817	810	810
query45	184	167	164	164
query46	848	1008	629	629
query47	1736	1810	1708	1708
query48	385	420	306	306
query49	751	486	376	376
query50	689	695	410	410
query51	4172	4167	4194	4167
query52	111	110	102	102
query53	231	269	181	181
query54	587	589	517	517
query55	84	81	93	81
query56	301	290	305	290
query57	1179	1187	1140	1140
query58	263	257	259	257
query59	2678	2742	2643	2643
query60	333	325	304	304
query61	129	119	125	119
query62	812	723	669	669
query63	227	194	191	191
query64	4278	1001	662	662
query65	4330	4197	4208	4197
query66	1102	404	308	308
query67	15836	15702	15242	15242
query68	8624	908	536	536
query69	474	311	275	275
query70	1190	1170	1104	1104
query71	487	317	326	317
query72	5477	4663	4625	4625
query73	706	574	353	353
query74	9009	9152	8726	8726
query75	3946	3177	2676	2676
query76	3727	1170	745	745
query77	783	392	305	305
query78	10122	10216	9407	9407
query79	2913	817	603	603
query80	676	514	441	441
query81	458	266	227	227
query82	457	125	102	102
query83	279	324	241	241
query84	289	100	86	86
query85	767	374	318	318
query86	333	319	299	299
query87	4477	4510	4417	4417
query88	3083	2285	2267	2267
query89	405	324	280	280
query90	1943	215	212	212
query91	211	141	111	111
query92	74	58	56	56
query93	1827	970	582	582
query94	683	408	320	320
query95	370	288	287	287
query96	498	586	282	282
query97	2743	2713	2657	2657
query98	232	208	205	205
query99	1484	1381	1300	1300
Total cold run time: 276319 ms
Total hot run time: 185170 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

ClickBench: Total hot run time: 29.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7303f1dbbdcc720e9faaaf531e7f4995c5662e85, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.63	0.11	0.11
query5	0.43	0.42	0.41
query6	1.17	0.67	0.67
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.62	0.51	0.51
query10	0.57	0.57	0.56
query11	0.15	0.12	0.11
query12	0.16	0.13	0.11
query13	0.63	0.61	0.62
query14	0.82	0.81	0.85
query15	0.90	0.88	0.89
query16	0.39	0.38	0.40
query17	1.06	1.06	1.05
query18	0.23	0.21	0.22
query19	1.98	1.88	1.81
query20	0.01	0.02	0.01
query21	15.41	0.91	0.53
query22	0.74	1.16	0.75
query23	14.90	1.39	0.64
query24	6.81	2.03	0.63
query25	0.50	0.20	0.13
query26	0.62	0.16	0.14
query27	0.07	0.06	0.06
query28	10.04	0.91	0.45
query29	12.55	3.96	3.28
query30	0.24	0.09	0.07
query31	2.84	0.61	0.40
query32	3.23	0.57	0.47
query33	3.15	3.11	3.12
query34	16.08	5.52	4.78
query35	4.88	4.92	4.93
query36	0.71	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.46 s
Total hot run time: 29.63 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by anyone and no changes requested.

Jibing-Li
Jibing-Li reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title has typo o?

@morrySnow morrySnow changed the title [opt](group_concat) allow args o be types other than string [opt](group_concat) allow args to be types other than string Jul 8, 2025
@morrySnow morrySnow changed the title [opt](group_concat) allow args to be types other than string [opt](group_concat) allow args be types other than string Jul 8, 2025
@morrySnow
Copy link
Contributor Author

morrySnow commented Jul 8, 2025

PR title has typo o?

done

@morrySnow morrySnow merged commit 34b8e7d into apache:master Jul 8, 2025
28 of 32 checks passed
@morrySnow morrySnow deleted the opt_group_concat branch July 8, 2025 08:02
github-actions bot pushed a commit that referenced this pull request Jul 9, 2025
@morrySnow
[opt](group_concat) allow args be types other than string (#52805)
4c25600
@github-actions github-actions bot mentioned this pull request Jul 9, 2025
Merged
morrySnow added a commit that referenced this pull request Jul 10, 2025
@github-actions @morrySnow
branch-3.1: [opt](group_concat) allow args be types other than string #…
690f199 
…52805 (#53012)

Cherry-picked from #52805

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@morrySnow morrySnow added dev/3.1.0-merged dev/3.0.x usercase Important user case type label and removed dev/3.1.x labels Jul 10, 2025
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 18, 2025
@morrySnow
branch-3.0: [opt](group_concat) allow args be types other than string a…
d551b77 
…pache#52805

cherry picked from apache#52805
@morrySnow morrySnow mentioned this pull request Jul 18, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 20, 2025
@morrySnow
branch-3.0: [opt](group_concat) allow args be types other than string #…
c3608e0 
…52805 (#53531)

cherry picked from #52805
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@Jibing-Li Jibing-Li Jibing-Li approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged kind/behavior-changed reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @hello-stephen @doris-robot @starocean999 @Jibing-Li @dataroaring