Skip to content

branch-3.0: [Opt](cloud-mow) Retry to commit txn when encounter stale calc delete bitmap response regardless of status code (#52547) #52848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jul 8, 2025
Merged

branch-3.0: [Opt](cloud-mow) Retry to commit txn when encounter stale calc delete bitmap response regardless of status code (#52547) #52848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions fe/fe-core/src/main/java/org/apache/doris/master/MasterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,12 +683,8 @@ private void finishCalcDeleteBitmap(AgentTask task, TFinishTaskRequest request)
// and if meta is missing, we no longer need to resend this task
try {
CalcDeleteBitmapTask calcDeleteBitmapTask = (CalcDeleteBitmapTask) task;
if (request.getTaskStatus().getStatusCode() != TStatusCode.OK) {
calcDeleteBitmapTask.countDownToZero(request.getTaskStatus().getStatusCode(),
"backend: " + task.getBackendId() + ", error_tablet_size: "
+ request.getErrorTabletIdsSize() + ", err_msg: "
+ request.getTaskStatus().getErrorMsgs().toString());
} else if (request.isSetRespPartitions()
// check if the request is stale first, if so, let it retry regardless of the status code
if (request.isSetRespPartitions()
&& calcDeleteBitmapTask.isFinishRequestStale(request.getRespPartitions())) {
LOG.warn("get staled response from backend: {}, report version: {}. calcDeleteBitmapTask's"
+ "partitionInfos: {}. response's partitionInfos: {}", task.getBackendId(),
Expand All @@ -699,6 +695,11 @@ private void finishCalcDeleteBitmap(AgentTask task, TFinishTaskRequest request)
calcDeleteBitmapTask.countDownToZero(TStatusCode.DELETE_BITMAP_LOCK_ERROR,
"get staled response from backend " + task.getBackendId() + ", report version: "
+ request.getReportVersion());
} else if (request.getTaskStatus().getStatusCode() != TStatusCode.OK) {
calcDeleteBitmapTask.countDownToZero(request.getTaskStatus().getStatusCode(),
"backend: " + task.getBackendId() + ", error_tablet_size: " + request.getErrorTabletIdsSize()
+ ", error_tablets: " + request.getErrorTabletIds()
+ ", err_msg: " + request.getTaskStatus().getErrorMsgs().toString());
} else {
calcDeleteBitmapTask.countDownLatch(task.getBackendId(), calcDeleteBitmapTask.getTransactionId());
if (LOG.isDebugEnabled()) {
Expand Down