Skip to content

branch-3.0: [fix](inverted index) catch IO exception to avoid coredump in inverted index string reader #51844 #52864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Jul 8, 2025
Merged

branch-3.0: [fix](inverted index) catch IO exception to avoid coredump in inverted index string reader #51844 #52864

dataroaring merged 3 commits into from
Jul 8, 2025

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Jul 7, 2025

cherry pick from #51844

@airborne12
[fix](inverted index) catch IO exception to avoid coredump in inverte…
4a9af40 
…d index string reader (apache#51844)

Problem Summary:
This PR adds error handling around CLucene interactions in the string
inverted index reader to prevent core dumps on IO failures and
introduces.
@airborne12 airborne12 requested a review from dataroaring as a code owner July 7, 2025 06:05
@airborne12
Copy link
Member Author

airborne12 commented Jul 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

airborne12 commented Jul 7, 2025

run buildall

@airborne12
Copy link
Member Author

airborne12 commented Jul 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 7, 2025

BE UT Coverage Report

Increment line coverage 86.11% (31/36) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.22% (10948/26562)
Line Coverage 31.98% (93738/293091)
Region Coverage 31.11% (48353/155429)
Branch Coverage 27.56% (24766/89862)

dataroaring
dataroaring approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit fd15f76 into apache:branch-3.0 Jul 8, 2025
20 of 24 checks passed
@airborne12 airborne12 deleted the pick_51844_to_origin_branch-3.0 branch July 8, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airborne12 @hello-stephen @doris-robot @dataroaring