Skip to content

branch-2.1:[fix](auth)fix when authentication, the permissions of multiple roles should be merged #52349 #52947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Jul 24, 2025
Merged

branch-2.1:[fix](auth)fix when authentication, the permissions of multiple roles should be merged #52349 #52947

yiguolei merged 2 commits into from
Jul 24, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Jul 8, 2025 •
edited by morrySnow
Loading

pick #52349

@zddr zddr requested a review from yiguolei as a code owner July 8, 2025 10:36
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Jul 8, 2025

run buildall

3 similar comments
@zddr
Copy link
Contributor Author

zddr commented Jul 8, 2025

run buildall

@zddr
Copy link
Contributor Author

zddr commented Jul 9, 2025

run buildall

@zddr
Copy link
Contributor Author

zddr commented Jul 9, 2025

run buildall

zddr added 2 commits July 23, 2025 12:00
@zddr @morrySnow
[fix](auth)fix when authentication, the permissions of multiple roles…
bbb68dd 
… should be merged (apache#52349)

### What problem does this PR solve?

when user1 has two role: role1 and role2

role1 has priv1

role2 has priv2

when user1 needs both priv1 and priv2 for authorization

**expect behavior**：

Authentication successful

**Current system behavior**：

the system will throw a 'Permission Denied' error."

**Fix Solution**：

When validating permissions via the second role, retain awareness of
privileges assigned to the first role
# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
#	fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
#	fe/fe-core/src/test/java/org/apache/doris/mysql/privilege/AuthTest.java
#	fe/fe-core/src/test/java/org/apache/doris/utframe/TestWithFeService.java
@zddr @morrySnow
fix p0
b9d6eea
@morrySnow
Copy link
Contributor

morrySnow commented Jul 23, 2025

run buildall

@morrySnow morrySnow changed the title branch-2.1:[fix](auth)fix when authentication, the permissions of multiple roles… branch-2.1:[fix](auth)fix when authentication, the permissions of multiple roles should be merged #52349 Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 5873aa3 into apache:branch-2.1 Jul 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zddr @hello-stephen @morrySnow @yiguolei