-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](load) limit concurrency of delete_bitmap computation #52962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34367 ms |
TPC-DS: Total hot run time: 185970 ms |
ClickBench: Total hot run time: 29.73 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33874 ms |
TPC-DS: Total hot run time: 184421 ms |
ClickBench: Total hot run time: 32.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2f3c87c to
78feb2a
Compare
|
run buildall |
TPC-H: Total hot run time: 34858 ms |
TPC-DS: Total hot run time: 188774 ms |
ClickBench: Total hot run time: 29.82 s |
78feb2a to
382ba20
Compare
|
run buildall |
382ba20 to
13a0b35
Compare
|
run buildall |
TPC-H: Total hot run time: 34912 ms |
TPC-DS: Total hot run time: 189531 ms |
ClickBench: Total hot run time: 29.9 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34495 ms |
TPC-DS: Total hot run time: 188487 ms |
ClickBench: Total hot run time: 29.94 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Related PR: #48156
Problem Summary:
Previously, the same thread pool was used to calculate the DeleteBitmap during both the build rowset and publish stages. This led to high CPU usage and resource contention, especially impacting memtable flushing performance.
To mitigate this, a dedicated thread pool is introduced for DeleteBitmap computation during the build rowset stage. This new pool is configured with a lower maximum thread count (8 vs. the original 32) to better control resource consumption and reduce interference with other critical operations.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)