Skip to content

[metrics](warmup) add some metrics for warmup jobs #52991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 7, 2025
Merged

[metrics](warmup) add some metrics for warmup jobs #52991

dataroaring merged 1 commit into from
Aug 7, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 9, 2025 •
edited
Loading

What problem does this PR solve?

Add some metrics for warm up jobs, and fix some metrics.

file_cache_once_or_periodic_warm_up_submitted_tablet_num
file_cache_once_or_periodic_warm_up_finished_tablet_num

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou gavinchou mentioned this pull request Jul 9, 2025
Merged
16 tasks
gavinchou pushed a commit that referenced this pull request Jul 9, 2025
@kaijchen
[metrics](warmup) add some metrics for warmup jobs #52991 (#52739)
ab2fce4 
pick #52991 

Add the following metrics:

* `file_cache_once_or_periodic_warm_up_submitted_tablet_num`
* `file_cache_once_or_periodic_warm_up_finished_tablet_num`

Fix the following metrics:

* `file_cache_once_or_periodic_warm_up_finished_segment_num`
* `file_cache_once_or_periodic_warm_up_finished_segment_size`
* `file_cache_once_or_periodic_warm_up_finished_index_num`
* `file_cache_once_or_periodic_warm_up_finished_index_size`
kaijchen added a commit to kaijchen/doris that referenced this pull request Jul 14, 2025
@kaijchen
[metrics](warmup) add some metrics for warmup jobs apache#52991 (apac…
e264e70 
…he#52739)

pick apache#52991 

Add the following metrics:

* `file_cache_once_or_periodic_warm_up_submitted_tablet_num`
* `file_cache_once_or_periodic_warm_up_finished_tablet_num`

Fix the following metrics:

* `file_cache_once_or_periodic_warm_up_finished_segment_num`
* `file_cache_once_or_periodic_warm_up_finished_segment_size`
* `file_cache_once_or_periodic_warm_up_finished_index_num`
* `file_cache_once_or_periodic_warm_up_finished_index_size`
@kaijchen kaijchen mentioned this pull request Jul 14, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Jul 15, 2025
@kaijchen
[metrics](warmup) add some metrics for warmup jobs #52991 (#52739) (#…
13ed5b7 
…53189)

pick #52991 

Add the following metrics:

* `file_cache_once_or_periodic_warm_up_submitted_tablet_num`
* `file_cache_once_or_periodic_warm_up_finished_tablet_num`

Fix the following metrics:

* `file_cache_once_or_periodic_warm_up_finished_segment_num`
* `file_cache_once_or_periodic_warm_up_finished_segment_size`
* `file_cache_once_or_periodic_warm_up_finished_index_num`
* `file_cache_once_or_periodic_warm_up_finished_index_size`
@kaijchen kaijchen marked this pull request as ready for review August 5, 2025 14:41
@kaijchen
Copy link
Member Author

kaijchen commented Aug 5, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

TPC-H: Total hot run time: 33637 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 300de76264aa146d37c343f50fe035769ccbf782, data reload: false

------ Round 1 ----------------------------------
q1	17600	5321	5194	5194
q2	1925	299	185	185
q3	10303	1346	699	699
q4	10225	976	533	533
q5	7505	2492	2281	2281
q6	173	171	130	130
q7	896	741	658	658
q8	9290	1286	961	961
q9	6766	5133	5030	5030
q10	6872	2351	1975	1975
q11	454	280	265	265
q12	349	369	229	229
q13	17792	3436	2999	2999
q14	227	237	239	237
q15	525	478	462	462
q16	437	424	367	367
q17	556	802	360	360
q18	7435	7116	7045	7045
q19	1229	971	544	544
q20	320	312	212	212
q21	3411	2502	2272	2272
q22	1108	999	1004	999
Total cold run time: 105398 ms
Total hot run time: 33637 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5428	5327	5337	5327
q2	234	301	216	216
q3	2076	2577	2170	2170
q4	1296	1698	1336	1336
q5	4134	4210	4516	4210
q6	241	188	137	137
q7	1973	1923	1755	1755
q8	2509	2555	2461	2461
q9	7237	7140	7162	7140
q10	3221	3315	2958	2958
q11	566	654	521	521
q12	690	781	602	602
q13	3397	3519	3216	3216
q14	304	323	318	318
q15	510	452	565	452
q16	514	500	585	500
q17	1140	1438	1480	1438
q18	13726	7784	7735	7735
q19	13324	938	1091	938
q20	2431	1909	1834	1834
q21	15842	4577	4692	4577
q22	1232	1036	996	996
Total cold run time: 82025 ms
Total hot run time: 50837 ms

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

TPC-DS: Total hot run time: 170182 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 300de76264aa146d37c343f50fe035769ccbf782, data reload: false

============================================
query1	997	395	417	395
query2	6500	1780	1767	1767
query3	6745	232	222	222
query4	26682	23543	23066	23066
query5	4420	665	509	509
query6	325	256	223	223
query7	4627	524	295	295
query8	300	228	214	214
query9	8542	2922	2915	2915
query10	464	337	282	282
query11	15956	15345	14747	14747
query12	183	139	133	133
query13	1655	541	425	425
query14	8664	5852	5823	5823
query15	208	194	168	168
query16	7139	635	460	460
query17	991	772	647	647
query18	1995	476	330	330
query19	226	211	192	192
query20	141	141	142	141
query21	214	128	112	112
query22	3960	4051	3989	3989
query23	34695	34420	34304	34304
query24	7572	2391	2416	2391
query25	584	590	450	450
query26	737	288	168	168
query27	2595	513	347	347
query28	2978	2341	2346	2341
query29	735	588	486	486
query30	294	247	201	201
query31	876	811	711	711
query32	94	77	74	74
query33	531	475	376	376
query34	806	864	516	516
query35	767	871	758	758
query36	1008	1068	939	939
query37	137	108	92	92
query38	3920	3957	3964	3957
query39	1468	1395	1380	1380
query40	230	144	129	129
query41	63	62	53	53
query42	141	122	127	122
query43	495	515	477	477
query44	1400	873	870	870
query45	198	190	183	183
query46	937	1068	664	664
query47	1807	1835	1748	1748
query48	400	435	320	320
query49	673	504	396	396
query50	656	686	401	401
query51	4263	4209	4210	4209
query52	124	135	117	117
query53	257	288	208	208
query54	640	644	553	553
query55	90	92	88	88
query56	349	355	343	343
query57	1193	1242	1144	1144
query58	334	335	351	335
query59	2644	2661	2567	2567
query60	418	397	373	373
query61	136	123	123	123
query62	783	735	664	664
query63	248	212	213	212
query64	2831	1095	838	838
query65	4210	4118	4137	4118
query66	1030	489	341	341
query67	query68	18602	634	608	608
query69	994	317	294	294
query70	1421	1102	1113	1102
query71	668	336	318	318
query72	9131	2277	2401	2277
query73	4662	640	355	355
query74	9005	8930	8681	8681
query75	7269	3142	2674	2674
query76	8573	1226	781	781
query77	1229	436	332	332
query78	9417	10704	9475	9475
query79	14968	610	596	596
query80	1857	565	506	506
query81	536	261	231	231
query82	475	148	120	120
query83	357	306	282	282
query84	300	105	84	84
query85	966	374	338	338
query86	368	307	305	305
query87	4169	4157	4112	4112
query88	5602	2259	2203	2203
query89	475	358	358	358
query90	2532	227	226	226
query91	145	149	110	110
query92	91	72	68	68
query93	6380	970	657	657
query94	1118	405	279	279
query95	424	322	319	319
query96	501	589	280	280
query97	2700	2766	2560	2560
query98	251	233	221	221
query99	1451	1416	1288	1288
Total cold run time: 303918 ms
Total hot run time: 170182 ms

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

ClickBench: Total hot run time: 33.17 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 300de76264aa146d37c343f50fe035769ccbf782, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.05
query3	0.24	0.07	0.07
query4	1.63	0.11	0.11
query5	0.43	0.43	0.42
query6	1.19	0.66	0.65
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.56	0.49	0.47
query10	0.53	0.53	0.53
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.65	0.65	0.63
query14	0.90	1.14	1.21
query15	0.94	0.89	0.86
query16	0.39	0.39	0.40
query17	1.05	1.08	1.04
query18	0.23	0.21	0.20
query19	2.00	1.78	1.80
query20	0.02	0.01	0.01
query21	15.39	0.83	0.56
query22	0.79	1.18	0.72
query23	14.88	1.17	0.65
query24	7.28	1.74	0.84
query25	0.51	0.26	0.14
query26	0.58	0.16	0.13
query27	0.05	0.06	0.05
query28	9.97	0.82	0.44
query29	12.58	3.81	3.31
query30	3.05	2.94	2.93
query31	2.81	0.57	0.41
query32	3.24	0.57	0.49
query33	3.03	3.14	3.20
query34	16.17	5.37	4.96
query35	4.88	4.93	5.02
query36	0.71	0.52	0.50
query37	0.09	0.08	0.07
query38	0.05	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.04	0.03
query42	0.04	0.04	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.68 s
Total hot run time: 33.17 s

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.22% (16353/28090)
Line Coverage 47.10% (147693/313545)
Region Coverage 36.08% (110540/306383)
Branch Coverage 38.96% (49061/125926)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 5, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/15) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.33% (22429/27577)
Line Coverage 74.05% (232141/313511)
Region Coverage 61.45% (193319/314608)
Branch Coverage 65.44% (83420/127468)

dataroaring
dataroaring approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 39a6660 into apache:master Aug 7, 2025
26 of 29 checks passed
freemandealer pushed a commit to freemandealer/doris that referenced this pull request Aug 7, 2025
@kaijchen @freemandealer
[metrics](warmup) add some metrics for warmup jobs (apache#52991)
801dc96 
### What problem does this PR solve?

Add some metrics for warm up jobs, and fix some metrics.

file_cache_once_or_periodic_warm_up_submitted_tablet_num
file_cache_once_or_periodic_warm_up_finished_tablet_num
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaijchen @Thearas @doris-robot @hello-stephen @gavinchou @dataroaring @morrySnow