Skip to content

[fix](recycler) Fix two errors for recycler #53042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 14, 2025
Merged

[fix](recycler) Fix two errors for recycler #53042

dataroaring merged 1 commit into from
Jul 14, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Jul 10, 2025 •
edited
Loading

  • Fix not catch exception for azure AzureListIterator

  • Make AWS::InitAPI and Aws::ShutdownAPI called both in main thread

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Jul 10, 2025

run buildall

@swjtu-zhanglei
[fix](recycler) Fix two errors for recycler
94348a4 
* Fix not catch exception for azure AzureListIterator

* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Jul 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

Cloud UT Coverage Report

Increment line coverage 48.98% (24/49) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.62% (1256/1558)
Line Coverage 67.76% (21419/31609)
Region Coverage 67.25% (10610/15777)
Branch Coverage 56.74% (5566/9810)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gavinchou
gavinchou reviewed Jul 14, 2025
View reviewed changes
cloud/src/recycler/s3_accessor.cpp
std::make_shared<SimpleThreadPool>(config::recycle_pool_parallelism, "s3_accessor");
worker_pool->start();
});
S3Environment::getInstance();
Copy link
Contributor

@gavinchou gavinchou Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call seems confusing and meaningless

Copy link
Contributor Author

@swjtu-zhanglei swjtu-zhanglei Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call seems confusing and meaningless

image just a refact, don't change the original logicality

@dataroaring dataroaring merged commit a9e7311 into apache:master Jul 14, 2025
33 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
@swjtu-zhanglei
[fix](recycler) Fix two errors for recycler (#53042)
bf1b74d 
* Fix not catch exception for azure AzureListIterator

* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@github-actions github-actions bot mentioned this pull request Jul 14, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
@swjtu-zhanglei
[fix](recycler) Fix two errors for recycler (#53042)
f1b26da 
* Fix not catch exception for azure AzureListIterator

* Make `AWS::InitAPI` and `Aws::ShutdownAPI` called both in main thread
@github-actions github-actions bot mentioned this pull request Jul 14, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 15, 2025
@github-actions @swjtu-zhanglei
branch-3.0: [fix](recycler) Fix two errors for recycler #53042 (#53224)
5e63953 
Cherry-picked from #53042

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
morrySnow pushed a commit that referenced this pull request Jul 15, 2025
@github-actions @swjtu-zhanglei
branch-3.1: [fix](recycler) Fix two errors for recycler #53042 (#53225)
427604f 
Cherry-picked from #53042

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou left review comments

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swjtu-zhanglei @Thearas @doris-robot @gavinchou @hello-stephen @dataroaring @morrySnow