[fix](function)fix month=0 of from_iso8601_date function. #53050

hubgeter · 2025-07-10T08:06:54Z

What problem does this PR solve?

Related PR: #40695
Problem Summary:

Release note

pr #40695 introduced the function from_iso8601_date, which parses the string to get year、mouth、 day, and sets the date value through the set_time_unit function.
Since set_time_unit lacks some judgment on mouth, it may get an illegal date in the end, which may cause core in debug mode.

sql : select from_iso8601_date('2023-00-01');

F20250709 09:50:14.366984 3587796 vdatetime_value.h:1222] Check failed: date_v2_value_.month_ != 0
*** Check failure stack trace: ***
    @     0x559bd7050d96  google::LogMessage::SendToLog()
    @     0x559bd704d7e0  google::LogMessage::Flush()
    @     0x559bd70515d9  google::LogMessageFatal::~LogMessageFatal()
    @     0x559bc725a570  doris::DateV2Value<>::set_time_unit<>()
    @     0x559bc7257380  doris::vectorized::FromIso8601DateV2::execute()
    @     0x559bc7255a88  doris::vectorized::FunctionOtherTypesToDateType<>::execute_impl()
    @     0x559bc09e0781  doris::vectorized::DefaultExecutable::execute_impl()
    @     0x559bc423aa20  doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal()
    @     0x559bc4234938  doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns()
    @     0x559bc4233f42  doris::vectorized::PreparedFunctionImpl::default_implementation_for_nulls()
    @     0x559bc423a773  doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal()
    @     0x559bc4234938  doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns()
    @     0x559bc4234a57  doris::vectorized::PreparedFunctionImpl::execute()

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-07-10T08:07:05Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

hubgeter · 2025-07-10T08:07:13Z

run buildall

doris-robot · 2025-07-10T09:55:49Z

TPC-H: Total hot run time: 33441 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fbdb84c57ba02fbf756bc52bf7a9168d8a380c22, data reload: false

------ Round 1 ----------------------------------
q1	17613	5234	5050	5050
q2	1921	278	199	199
q3	10344	1314	723	723
q4	10265	1010	542	542
q5	8192	2433	2330	2330
q6	193	157	124	124
q7	905	772	615	615
q8	9311	1335	1268	1268
q9	6943	5172	5136	5136
q10	6889	2380	1963	1963
q11	487	275	267	267
q12	337	343	221	221
q13	17769	3640	3074	3074
q14	233	227	208	208
q15	547	472	492	472
q16	427	439	375	375
q17	587	890	347	347
q18	7594	7303	7135	7135
q19	1226	948	558	558
q20	340	354	221	221
q21	3685	3177	2319	2319
q22	354	319	294	294
Total cold run time: 106162 ms
Total hot run time: 33441 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5124	5067	5106	5067
q2	231	322	216	216
q3	2153	2665	2301	2301
q4	1349	1796	1352	1352
q5	4244	4446	4482	4446
q6	228	172	122	122
q7	2017	1987	1765	1765
q8	2616	2757	2597	2597
q9	7283	7236	7283	7236
q10	3171	3254	2902	2902
q11	593	509	505	505
q12	670	814	639	639
q13	3693	4025	3403	3403
q14	269	301	293	293
q15	511	465	465	465
q16	465	490	464	464
q17	1165	1519	1432	1432
q18	7775	7771	7805	7771
q19	772	774	827	774
q20	1931	1965	1852	1852
q21	4681	4382	4312	4312
q22	639	567	535	535
Total cold run time: 51580 ms
Total hot run time: 50449 ms

doris-robot · 2025-07-10T10:07:26Z

TPC-DS: Total hot run time: 186136 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fbdb84c57ba02fbf756bc52bf7a9168d8a380c22, data reload: false

query1	984	378	399	378
query2	6530	1741	1745	1741
query3	6753	208	229	208
query4	26429	23498	23641	23498
query5	4379	588	433	433
query6	335	215	210	210
query7	4634	501	298	298
query8	279	234	229	229
query9	8618	2665	2668	2665
query10	481	341	259	259
query11	15668	14992	14878	14878
query12	170	106	105	105
query13	1640	535	415	415
query14	9418	5807	5878	5807
query15	210	194	167	167
query16	7630	432	249	249
query17	1329	717	566	566
query18	2012	391	305	305
query19	188	188	171	171
query20	131	115	117	115
query21	209	124	102	102
query22	4051	4097	3953	3953
query23	33849	33116	33080	33080
query24	8438	2386	2433	2386
query25	547	473	390	390
query26	1231	260	154	154
query27	2770	502	340	340
query28	4297	2127	2101	2101
query29	720	558	486	486
query30	289	217	199	199
query31	930	832	748	748
query32	75	80	63	63
query33	550	360	286	286
query34	815	843	541	541
query35	589	655	556	556
query36	923	985	904	904
query37	120	104	73	73
query38	4197	4118	4151	4118
query39	1520	1382	1473	1382
query40	212	116	105	105
query41	57	56	53	53
query42	130	123	112	112
query43	515	522	471	471
query44	1335	823	822	822
query45	178	174	170	170
query46	837	1020	646	646
query47	1744	1755	1717	1717
query48	379	411	307	307
query49	747	468	389	389
query50	634	680	418	418
query51	4181	4146	4036	4036
query52	119	116	108	108
query53	226	255	189	189
query54	588	595	508	508
query55	85	83	86	83
query56	309	317	311	311
query57	1156	1203	1129	1129
query58	274	266	266	266
query59	2633	2721	2583	2583
query60	344	348	319	319
query61	157	153	153	153
query62	806	730	645	645
query63	223	198	193	193
query64	4561	1257	842	842
query65	4259	4162	4179	4162
query66	1051	409	313	313
query67	15798	15597	15307	15307
query68	8772	883	534	534
query69	495	317	270	270
query70	1227	1144	1073	1073
query71	473	319	297	297
query72	5946	4852	4919	4852
query73	735	642	355	355
query74	9365	8808	8989	8808
query75	4111	3205	2690	2690
query76	3683	1158	748	748
query77	789	404	288	288
query78	10904	11291	10220	10220
query79	1097	843	596	596
query80	606	511	470	470
query81	480	253	219	219
query82	412	126	107	107
query83	257	252	239	239
query84	249	109	87	87
query85	779	413	323	323
query86	337	314	293	293
query87	4449	4465	4306	4306
query88	2955	2308	2311	2308
query89	379	325	294	294
query90	1944	218	212	212
query91	143	146	115	115
query92	72	62	58	58
query93	1080	958	595	595
query94	680	314	200	200
query95	378	295	286	286
query96	502	570	294	294
query97	2742	2716	2626	2626
query98	231	208	203	203
query99	1399	1353	1254	1254
Total cold run time: 275147 ms
Total hot run time: 186136 ms

doris-robot · 2025-07-10T10:12:43Z

ClickBench: Total hot run time: 30.25 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fbdb84c57ba02fbf756bc52bf7a9168d8a380c22, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.25	0.08	0.08
query4	1.60	0.10	0.11
query5	0.45	0.41	0.42
query6	1.18	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.51	0.53
query10	0.57	0.59	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.62	0.61
query14	0.79	0.81	0.82
query15	0.88	0.89	0.86
query16	0.39	0.39	0.40
query17	1.07	1.09	1.05
query18	0.22	0.22	0.20
query19	1.94	1.84	1.84
query20	0.02	0.01	0.02
query21	15.41	0.92	0.54
query22	0.76	1.33	0.64
query23	14.83	1.39	0.58
query24	6.59	1.42	1.67
query25	0.53	0.18	0.23
query26	0.47	0.15	0.13
query27	0.06	0.05	0.05
query28	10.66	0.93	0.46
query29	12.56	3.99	3.30
query30	0.26	0.09	0.06
query31	2.83	0.60	0.40
query32	3.24	0.56	0.48
query33	3.18	3.14	3.12
query34	15.98	5.39	4.76
query35	4.82	4.83	4.82
query36	0.68	0.51	0.49
query37	0.09	0.06	0.07
query38	0.05	0.05	0.04
query39	0.04	0.03	0.03
query40	0.16	0.15	0.15
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.43 s
Total hot run time: 30.25 s

zclllyybb

LGTM

github-actions · 2025-07-10T10:35:11Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-10T10:35:13Z

PR approved by anyone and no changes requested.

doris-robot · 2025-07-10T11:21:27Z

BE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.03% (15502/27182)
Line Coverage	45.87% (138339/301583)
Region Coverage	35.30% (103493/293200)
Branch Coverage	37.73% (45523/120647)

hubgeter · 2025-07-11T07:40:15Z

run buildall

doris-robot · 2025-07-11T09:08:22Z

TPC-H: Total hot run time: 33698 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7896955f19cf75fe4ab24553782db4e480aa2419, data reload: false

------ Round 1 ----------------------------------
q1	17572	5221	5135	5135
q2	1928	288	198	198
q3	10300	1311	727	727
q4	10210	993	535	535
q5	7608	2436	2361	2361
q6	187	158	129	129
q7	906	759	600	600
q8	9306	1292	1120	1120
q9	6943	5151	5154	5151
q10	6907	2365	1962	1962
q11	496	292	297	292
q12	351	350	224	224
q13	17761	3748	3086	3086
q14	230	223	213	213
q15	541	478	487	478
q16	420	419	370	370
q17	602	896	380	380
q18	7546	7213	7197	7197
q19	1197	956	565	565
q20	348	338	233	233
q21	4087	3173	2449	2449
q22	371	324	293	293
Total cold run time: 105817 ms
Total hot run time: 33698 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5100	5103	5142	5103
q2	243	324	219	219
q3	2141	2693	2307	2307
q4	1367	1841	1322	1322
q5	4251	4308	4543	4308
q6	219	167	130	130
q7	2050	1942	1852	1852
q8	2692	2592	2591	2591
q9	7418	7296	7154	7154
q10	3112	3301	2871	2871
q11	596	513	501	501
q12	684	795	680	680
q13	3582	4057	3350	3350
q14	332	317	281	281
q15	524	496	489	489
q16	436	516	437	437
q17	1178	1551	1423	1423
q18	8029	7785	7667	7667
q19	823	850	862	850
q20	2080	2074	2001	2001
q21	5087	4515	4720	4515
q22	626	575	528	528
Total cold run time: 52570 ms
Total hot run time: 50579 ms

doris-robot · 2025-07-11T09:20:03Z

TPC-DS: Total hot run time: 187616 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7896955f19cf75fe4ab24553782db4e480aa2419, data reload: false

query1	1006	382	377	377
query2	6506	1663	1661	1661
query3	6749	229	216	216
query4	26662	23274	23463	23274
query5	4364	582	439	439
query6	306	229	206	206
query7	4626	493	278	278
query8	278	223	207	207
query9	8596	2617	2627	2617
query10	473	320	269	269
query11	15613	15048	14885	14885
query12	152	106	105	105
query13	1635	553	413	413
query14	8741	5902	5883	5883
query15	211	199	173	173
query16	7330	653	492	492
query17	1217	739	621	621
query18	1993	411	315	315
query19	197	193	172	172
query20	131	118	113	113
query21	207	123	108	108
query22	4057	4403	4587	4403
query23	35004	33650	33963	33650
query24	8413	2399	2384	2384
query25	548	457	390	390
query26	1233	266	144	144
query27	2765	493	345	345
query28	4293	2116	2094	2094
query29	749	581	454	454
query30	272	212	183	183
query31	915	829	738	738
query32	68	61	56	56
query33	552	370	313	313
query34	793	833	542	542
query35	761	839	757	757
query36	923	975	895	895
query37	113	101	78	78
query38	4108	4108	4080	4080
query39	1446	1402	1403	1402
query40	199	121	107	107
query41	53	54	49	49
query42	125	103	111	103
query43	499	509	484	484
query44	1355	862	811	811
query45	175	170	164	164
query46	827	1045	637	637
query47	1753	1791	1696	1696
query48	396	429	307	307
query49	734	474	400	400
query50	631	685	404	404
query51	5428	5501	5512	5501
query52	111	106	91	91
query53	218	252	188	188
query54	579	568	497	497
query55	104	86	81	81
query56	320	309	291	291
query57	1166	1182	1121	1121
query58	268	259	262	259
query59	2532	2681	2477	2477
query60	335	326	322	322
query61	139	124	121	121
query62	808	738	672	672
query63	230	190	189	189
query64	4324	1041	648	648
query65	4269	4185	4144	4144
query66	1153	409	327	327
query67	15911	15437	15385	15385
query68	8069	903	532	532
query69	491	321	277	277
query70	1191	1110	1096	1096
query71	498	331	293	293
query72	5612	4720	4773	4720
query73	657	591	348	348
query74	9191	9108	8972	8972
query75	3958	3187	2684	2684
query76	3740	1224	696	696
query77	777	403	290	290
query78	9880	10032	9250	9250
query79	2503	831	595	595
query80	634	520	482	482
query81	469	254	230	230
query82	455	127	95	95
query83	283	258	237	237
query84	288	111	90	90
query85	776	356	317	317
query86	325	310	273	273
query87	4423	4487	4417	4417
query88	3400	2264	2260	2260
query89	387	312	284	284
query90	1947	211	211	211
query91	134	137	108	108
query92	76	58	62	58
query93	1158	917	602	602
query94	677	460	309	309
query95	373	299	296	296
query96	494	569	276	276
query97	2722	2786	2643	2643
query98	237	202	203	202
query99	1434	1408	1265	1265
Total cold run time: 275907 ms
Total hot run time: 187616 ms

doris-robot · 2025-07-11T09:25:20Z

ClickBench: Total hot run time: 30.08 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7896955f19cf75fe4ab24553782db4e480aa2419, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.08	0.07
query4	1.61	0.11	0.11
query5	0.42	0.43	0.43
query6	1.19	0.66	0.65
query7	0.03	0.01	0.02
query8	0.05	0.04	0.04
query9	0.59	0.51	0.52
query10	0.57	0.58	0.56
query11	0.15	0.12	0.11
query12	0.15	0.12	0.11
query13	0.63	0.61	0.61
query14	0.79	0.82	0.82
query15	0.90	0.89	0.87
query16	0.38	0.40	0.41
query17	1.04	1.07	1.02
query18	0.23	0.22	0.22
query19	1.96	1.83	1.87
query20	0.01	0.01	0.02
query21	15.45	0.88	0.53
query22	0.74	1.20	0.70
query23	14.92	1.38	0.58
query24	6.81	1.18	1.33
query25	0.50	0.30	0.18
query26	0.65	0.17	0.14
query27	0.06	0.06	0.05
query28	9.59	0.92	0.45
query29	12.57	4.05	3.33
query30	0.25	0.10	0.06
query31	2.85	0.60	0.39
query32	3.23	0.56	0.47
query33	3.10	3.11	3.13
query34	16.08	5.42	4.77
query35	4.82	4.86	4.86
query36	0.71	0.51	0.50
query37	0.09	0.06	0.07
query38	0.06	0.05	0.04
query39	0.03	0.02	0.02
query40	0.17	0.15	0.14
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.88 s
Total hot run time: 30.08 s

doris-robot · 2025-07-11T10:51:54Z

BE UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.16% (15532/27175)
Line Coverage	46.02% (138857/301712)
Region Coverage	35.40% (103825/293328)
Branch Coverage	37.92% (45778/120726)

morningman · 2025-07-13T00:33:02Z

run buildall

doris-robot · 2025-07-13T02:11:19Z

TPC-H: Total hot run time: 33277 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b62c07b8b2881837d7798813a6021d3552504e2, data reload: false

------ Round 1 ----------------------------------
q1	17582	5233	5142	5142
q2	1945	301	188	188
q3	10491	1306	740	740
q4	10263	1007	519	519
q5	7919	2365	2365	2365
q6	178	158	128	128
q7	903	763	596	596
q8	9307	1348	1052	1052
q9	6960	5097	5163	5097
q10	6908	2409	1969	1969
q11	480	295	263	263
q12	342	350	211	211
q13	17778	3696	3085	3085
q14	237	232	214	214
q15	540	490	478	478
q16	432	418	385	385
q17	579	875	379	379
q18	7787	7131	7035	7035
q19	1217	958	563	563
q20	332	354	221	221
q21	3676	3184	2348	2348
q22	343	316	299	299
Total cold run time: 106199 ms
Total hot run time: 33277 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5356	5130	5100	5100
q2	240	332	222	222
q3	2210	2729	2299	2299
q4	1362	1775	1282	1282
q5	4258	4129	4508	4129
q6	215	167	134	134
q7	2104	1981	1887	1887
q8	2682	2623	2629	2623
q9	7470	7410	7434	7410
q10	3098	3301	2905	2905
q11	611	532	498	498
q12	684	826	642	642
q13	3591	3958	3343	3343
q14	390	305	272	272
q15	519	482	502	482
q16	451	501	453	453
q17	1185	1633	1356	1356
q18	8061	7844	7644	7644
q19	806	868	1054	868
q20	1984	2010	1883	1883
q21	4704	4361	4339	4339
q22	668	601	578	578
Total cold run time: 52649 ms
Total hot run time: 50349 ms

doris-robot · 2025-07-13T02:22:55Z

TPC-DS: Total hot run time: 184721 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b62c07b8b2881837d7798813a6021d3552504e2, data reload: false

query1	1020	396	400	396
query2	6527	1704	1708	1704
query3	6738	213	217	213
query4	26426	23382	23025	23025
query5	4358	568	429	429
query6	300	219	210	210
query7	4632	496	291	291
query8	272	220	226	220
query9	8645	2615	2637	2615
query10	469	324	269	269
query11	15866	15008	14768	14768
query12	159	109	105	105
query13	1663	520	412	412
query14	9314	6100	6068	6068
query15	208	192	179	179
query16	7656	429	250	250
query17	1340	696	567	567
query18	2009	401	305	305
query19	188	184	160	160
query20	119	111	112	111
query21	212	125	119	119
query22	4105	4214	4019	4019
query23	34023	33059	33295	33059
query24	8415	2354	2400	2354
query25	517	455	388	388
query26	1221	265	143	143
query27	2775	505	331	331
query28	4293	2140	2106	2106
query29	708	557	444	444
query30	286	223	197	197
query31	925	828	757	757
query32	72	61	58	58
query33	582	338	286	286
query34	792	837	535	535
query35	603	652	554	554
query36	930	985	894	894
query37	111	101	76	76
query38	4135	4168	4187	4168
query39	1510	1447	1429	1429
query40	209	115	102	102
query41	57	60	59	59
query42	154	106	107	106
query43	512	517	465	465
query44	1320	820	833	820
query45	177	172	165	165
query46	839	1020	617	617
query47	1760	1821	1719	1719
query48	379	413	296	296
query49	744	482	386	386
query50	631	700	421	421
query51	5524	5540	5599	5540
query52	105	108	94	94
query53	228	255	179	179
query54	580	586	496	496
query55	87	81	86	81
query56	299	320	288	288
query57	1185	1187	1135	1135
query58	268	255	260	255
query59	2560	2738	2503	2503
query60	320	320	295	295
query61	128	143	156	143
query62	801	746	696	696
query63	226	185	191	185
query64	4509	1163	829	829
query65	4295	4190	4178	4178
query66	1064	420	317	317
query67	15895	15510	15423	15423
query68	7831	889	521	521
query69	497	373	260	260
query70	1156	1158	1102	1102
query71	429	317	283	283
query72	5522	2388	5147	2388
query73	728	754	354	354
query74	9070	9019	8864	8864
query75	3557	3206	2688	2688
query76	3314	1148	703	703
query77	785	370	310	310
query78	10923	11336	10276	10276
query79	1437	818	567	567
query80	630	513	432	432
query81	477	253	218	218
query82	187	126	96	96
query83	257	240	232	232
query84	255	104	88	88
query85	758	375	310	310
query86	371	309	288	288
query87	4400	4461	4300	4300
query88	2855	2242	2284	2242
query89	378	319	287	287
query90	1869	210	207	207
query91	146	137	110	110
query92	71	61	55	55
query93	1134	946	592	592
query94	638	318	205	205
query95	385	292	283	283
query96	494	562	277	277
query97	2688	2776	2666	2666
query98	224	207	208	207
query99	1347	1410	1303	1303
Total cold run time: 273793 ms
Total hot run time: 184721 ms

doris-robot · 2025-07-13T02:28:13Z

ClickBench: Total hot run time: 29.94 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b62c07b8b2881837d7798813a6021d3552504e2, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.45	0.45	0.42
query6	1.14	0.67	0.67
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.54	0.52
query10	0.56	0.58	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.63
query14	0.79	0.80	0.82
query15	0.88	0.90	0.86
query16	0.38	0.39	0.39
query17	1.07	1.08	1.05
query18	0.23	0.22	0.21
query19	1.94	1.86	1.81
query20	0.02	0.01	0.01
query21	15.38	0.90	0.53
query22	0.76	1.28	0.63
query23	14.88	1.38	0.65
query24	7.23	1.62	0.98
query25	0.53	0.25	0.21
query26	0.71	0.16	0.13
query27	0.06	0.05	0.06
query28	9.65	0.88	0.46
query29	12.65	4.01	3.33
query30	0.25	0.10	0.07
query31	2.84	0.60	0.39
query32	3.24	0.57	0.48
query33	3.05	3.12	3.12
query34	16.25	5.42	4.77
query35	4.87	4.86	4.90
query36	0.69	0.50	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.57 s
Total hot run time: 29.94 s

doris-robot · 2025-07-13T03:52:53Z

BE UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.47% (15622/27182)
Line Coverage	46.22% (139580/301971)
Region Coverage	35.54% (104332/293557)
Branch Coverage	38.09% (46018/120802)

zclllyybb

LGTM

github-actions · 2025-07-14T02:45:05Z

PR approved by at least one committer and no changes requested.

Related PR: apache#40695 Problem Summary: pr apache#40695 introduced the function `from_iso8601_date`, which parses the string to get year、mouth、 day, and sets the date value through the `set_time_unit` function. Since `set_time_unit` lacks some judgment on mouth, it may get an illegal date in the end, which may cause core in debug mode. sql : `select from_iso8601_date('2023-00-01');` ``` F20250709 09:50:14.366984 3587796 vdatetime_value.h:1222] Check failed: date_v2_value_.month_ != 0 *** Check failure stack trace: *** @ 0x559bd7050d96 google::LogMessage::SendToLog() @ 0x559bd704d7e0 google::LogMessage::Flush() @ 0x559bd70515d9 google::LogMessageFatal::~LogMessageFatal() @ 0x559bc725a570 doris::DateV2Value<>::set_time_unit<>() @ 0x559bc7257380 doris::vectorized::FromIso8601DateV2::execute() @ 0x559bc7255a88 doris::vectorized::FunctionOtherTypesToDateType<>::execute_impl() @ 0x559bc09e0781 doris::vectorized::DefaultExecutable::execute_impl() @ 0x559bc423aa20 doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal() @ 0x559bc4234938 doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns() @ 0x559bc4233f42 doris::vectorized::PreparedFunctionImpl::default_implementation_for_nulls() @ 0x559bc423a773 doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal() @ 0x559bc4234938 doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns() @ 0x559bc4234a57 doris::vectorized::PreparedFunctionImpl::execute() ```

…#53050 (#53308) bp #53050

…53050) (#53309) bp #53050

…53050) (#53438) bp #53050 Related PR: #40695 Problem Summary: pr #40695 introduced the function `from_iso8601_date`, which parses the string to get year、mouth、 day, and sets the date value through the `set_time_unit` function. Since `set_time_unit` lacks some judgment on mouth, it may get an illegal date in the end, which may cause core in debug mode. sql : `select from_iso8601_date('2023-00-01');` ``` F20250709 09:50:14.366984 3587796 vdatetime_value.h:1222] Check failed: date_v2_value_.month_ != 0 *** Check failure stack trace: *** @ 0x559bd7050d96 google::LogMessage::SendToLog() @ 0x559bd704d7e0 google::LogMessage::Flush() @ 0x559bd70515d9 google::LogMessageFatal::~LogMessageFatal() @ 0x559bc725a570 doris::DateV2Value<>::set_time_unit<>() @ 0x559bc7257380 doris::vectorized::FromIso8601DateV2::execute() @ 0x559bc7255a88 doris::vectorized::FunctionOtherTypesToDateType<>::execute_impl() @ 0x559bc09e0781 doris::vectorized::DefaultExecutable::execute_impl() @ 0x559bc423aa20 doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal() @ 0x559bc4234938 doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns() @ 0x559bc4233f42 doris::vectorized::PreparedFunctionImpl::default_implementation_for_nulls() @ 0x559bc423a773 doris::vectorized::PreparedFunctionImpl::_execute_skipped_constant_deal() @ 0x559bc4234938 doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns() @ 0x559bc4234a57 doris::vectorized::PreparedFunctionImpl::execute() ``` ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

zclllyybb added p0_c dev/2.1.x dev/3.0.x dev/3.1.x labels Jul 10, 2025

zclllyybb previously approved these changes Jul 10, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 10, 2025

github-actions bot added the reviewed label Jul 10, 2025

Mryange approved these changes Jul 10, 2025

View reviewed changes

hubgeter dismissed zclllyybb’s stale review via 7896955 July 11, 2025 07:39

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

hubgeter added 2 commits July 12, 2025 17:32

[fix](function)fix month=0 of from_iso8601_date function.

467d614

add it

1b62c07

morningman force-pushed the fix_iso8601_date branch from 7896955 to 1b62c07 Compare July 13, 2025 00:32

zclllyybb approved these changes Jul 14, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2025

zclllyybb merged commit 1fd3aa0 into apache:master Jul 14, 2025
23 of 25 checks passed

github-actions bot added dev/3.0.x-conflict dev/2.1.x-conflict dev/3.1.x-conflict labels Jul 14, 2025

This was referenced Jul 15, 2025

branch-3.1:[fix](function)fix month=0 of from_iso8601_date function. (#53050) #53308

Merged

branch-3.0:[fix](function)fix month=0 of from_iso8601_date function. (#53050) #53309

Merged

hubgeter mentioned this pull request Jul 17, 2025

branch-2.1:[fix](function)fix month=0 of from_iso8601_date function. (#53050) #53438

Merged

16 tasks

morrySnow pushed a commit that referenced this pull request Jul 18, 2025

branch-3.1: [fix](function) fix month=0 of from_iso8601_date function. …

95eb18e

…#53050 (#53308) bp #53050

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jul 18, 2025

dataroaring pushed a commit that referenced this pull request Jul 18, 2025

branch-3.0:[fix](function)fix month=0 of from_iso8601_date function. (#…

cd8d3f8

…53050) (#53309) bp #53050

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jul 18, 2025

yiguolei added dev/2.1.11-merged and removed dev/2.1.x dev/2.1.x-conflict labels Jul 18, 2025

[fix](function)fix month=0 of from_iso8601_date function. #53050

[fix](function)fix month=0 of from_iso8601_date function. #53050

Uh oh!

Conversation

hubgeter commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jul 10, 2025

Uh oh!

hubgeter commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

BE UT Coverage Report

Uh oh!

hubgeter commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

Uh oh!

doris-robot commented Jul 11, 2025

BE UT Coverage Report

Uh oh!

morningman commented Jul 13, 2025

Uh oh!

doris-robot commented Jul 13, 2025

Uh oh!

doris-robot commented Jul 13, 2025

Uh oh!

doris-robot commented Jul 13, 2025

Uh oh!

doris-robot commented Jul 13, 2025

BE UT Coverage Report

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hubgeter commented Jul 10, 2025 •

edited

Loading