-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.1: [fix](variant type) fix add variant column, index #53092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39542 ms |
TPC-DS: Total hot run time: 196574 ms |
ClickBench: Total hot run time: 30.45 s |
|
run buildall |
TPC-H: Total hot run time: 39534 ms |
TPC-DS: Total hot run time: 196450 ms |
ClickBench: Total hot run time: 29.8 s |
|
run buildall |
TPC-H: Total hot run time: 39708 ms |
TPC-DS: Total hot run time: 189254 ms |
ClickBench: Total hot run time: 29.94 s |
0029668 to
04a28f1
Compare
|
run buildall |
TPC-H: Total hot run time: 39659 ms |
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Outdated
Show resolved
Hide resolved
TPC-DS: Total hot run time: 197370 ms |
ClickBench: Total hot run time: 29.91 s |
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
Outdated
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 39516 ms |
TPC-DS: Total hot run time: 196085 ms |
ClickBench: Total hot run time: 29.55 s |
regression-test/suites/datatype_p0/nested_types/ddl/create_nestedtypes_with_schemachange.groovy
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 40016 ms |
TPC-DS: Total hot run time: 198001 ms |
ClickBench: Total hot run time: 30.73 s |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
TPC-H: Total hot run time: 39998 ms |
TPC-DS: Total hot run time: 196337 ms |
ClickBench: Total hot run time: 29.84 s |
|
run buildall |
TPC-H: Total hot run time: 39466 ms |
TPC-DS: Total hot run time: 197133 ms |
ClickBench: Total hot run time: 30.09 s |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…2927) 1. support when the sub-columns in the specified variant are of a fixed type, these sub-columns can be included in sparse columns. 2. add many cases and ut branch-3.1: [fix](variant type) fix add variant column, index (apache#53092) [fix](variant) Fix metadata compatibility for FE (apache#53748) - In version 3.1, we used 'VariantType', which inherits from 'ScalarType', as the metadata storage for newly created variants, differing from the previously used 'ScalarType'. - To ensure compatibility with previous metadata, convert 'VariantType' to 'ScalarType' before use. fix [fix](variant) fix array contains null fix case fix
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)