-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them #53198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them #53198
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ce945b4 to
9899a91
Compare
|
run buildall |
TPC-H: Total hot run time: 33130 ms |
TPC-DS: Total hot run time: 189655 ms |
ClickBench: Total hot run time: 29.19 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
8ae861c to
fe43e14
Compare
|
run buildall |
TPC-H: Total hot run time: 33490 ms |
TPC-DS: Total hot run time: 188135 ms |
ClickBench: Total hot run time: 29.75 s |
fd5fb89 to
88211a3
Compare
TPC-H: Total hot run time: 34306 ms |
TPC-DS: Total hot run time: 187646 ms |
ClickBench: Total hot run time: 32.64 s |
|
run buildall |
TPC-H: Total hot run time: 34282 ms |
TPC-DS: Total hot run time: 188496 ms |
ClickBench: Total hot run time: 32.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
…lete bitmap tasks on input segments before converting delete bitmaps on them (#53198)" (#58855) This reverts commit 9b6115d. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
What problem does this PR solve?
When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(#38369).
Caused by #48156
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)