Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 14, 2025

What problem does this PR solve?

When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(#38369).

Caused by #48156

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1 bobhan1 force-pushed the seg-comp-should-wait-before-convert-dbm branch from ce945b4 to 9899a91 Compare July 14, 2025 08:53
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 14, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33130 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9899a91722655fc68f8ba28adc491e1a5f56e852, data reload: false

------ Round 1 ----------------------------------
q1	17561	5216	5062	5062
q2	1929	277	184	184
q3	10333	1278	698	698
q4	10223	1021	518	518
q5	7526	2303	2359	2303
q6	171	159	125	125
q7	898	739	590	590
q8	9313	1292	1125	1125
q9	6878	5080	5077	5077
q10	6886	2366	1990	1990
q11	475	303	280	280
q12	337	343	205	205
q13	17776	3634	3037	3037
q14	222	230	216	216
q15	561	476	482	476
q16	431	423	381	381
q17	588	868	375	375
q18	7636	7144	7093	7093
q19	1071	938	530	530
q20	340	345	222	222
q21	3899	2530	2353	2353
q22	357	320	290	290
Total cold run time: 105411 ms
Total hot run time: 33130 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5062	5064	5108	5064
q2	249	324	217	217
q3	2168	2704	2314	2314
q4	1330	1748	1336	1336
q5	4194	4165	4558	4165
q6	215	174	133	133
q7	2054	1925	1815	1815
q8	2607	2574	2569	2569
q9	7323	7301	7230	7230
q10	3117	3260	2875	2875
q11	593	538	495	495
q12	663	789	630	630
q13	3629	4003	3438	3438
q14	291	328	284	284
q15	537	471	470	470
q16	450	501	444	444
q17	1173	1610	1377	1377
q18	7934	7671	7631	7631
q19	782	744	808	744
q20	2033	2095	1918	1918
q21	5069	4580	4576	4576
q22	634	609	589	589
Total cold run time: 52107 ms
Total hot run time: 50314 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189655 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9899a91722655fc68f8ba28adc491e1a5f56e852, data reload: false

query1	979	382	385	382
query2	6503	1688	1657	1657
query3	6743	212	217	212
query4	26381	24128	23530	23530
query5	4976	568	432	432
query6	309	225	202	202
query7	4631	512	277	277
query8	253	219	212	212
query9	8603	2614	2649	2614
query10	516	321	270	270
query11	15289	15177	14819	14819
query12	148	105	106	105
query13	1643	515	401	401
query14	9097	6131	6136	6131
query15	207	190	166	166
query16	7331	424	261	261
query17	1305	702	602	602
query18	1988	388	294	294
query19	190	190	159	159
query20	119	115	117	115
query21	210	121	104	104
query22	4223	4587	4649	4587
query23	35014	33946	33805	33805
query24	8416	2389	2335	2335
query25	525	453	387	387
query26	1226	260	144	144
query27	2768	519	349	349
query28	4274	2144	2110	2110
query29	714	552	430	430
query30	286	221	183	183
query31	909	851	771	771
query32	72	69	68	68
query33	564	342	288	288
query34	782	827	506	506
query35	587	645	572	572
query36	970	1027	936	936
query37	111	96	74	74
query38	4153	4123	4112	4112
query39	1487	1450	1438	1438
query40	204	117	107	107
query41	65	57	55	55
query42	122	105	105	105
query43	502	499	493	493
query44	1343	823	841	823
query45	178	174	168	168
query46	842	1029	633	633
query47	1779	1818	1735	1735
query48	389	473	308	308
query49	735	488	391	391
query50	632	684	411	411
query51	5531	5534	5330	5330
query52	105	102	94	94
query53	227	246	191	191
query54	564	561	488	488
query55	81	78	83	78
query56	304	305	304	304
query57	1169	1181	1101	1101
query58	269	275	254	254
query59	2673	2667	2591	2591
query60	324	328	312	312
query61	124	143	126	126
query62	817	722	685	685
query63	230	181	183	181
query64	4348	1216	828	828
query65	4310	4187	4202	4187
query66	1127	396	329	329
query67	16041	15765	15704	15704
query68	6854	889	519	519
query69	510	334	280	280
query70	1225	1149	1148	1148
query71	399	313	299	299
query72	5519	4983	5144	4983
query73	660	620	347	347
query74	9328	8934	9007	8934
query75	3167	3219	2699	2699
query76	3174	1156	717	717
query77	499	382	284	284
query78	10914	11067	10229	10229
query79	2418	843	579	579
query80	593	509	437	437
query81	477	254	222	222
query82	191	129	93	93
query83	244	252	236	236
query84	245	108	92	92
query85	812	364	348	348
query86	380	316	297	297
query87	4482	4440	4482	4440
query88	3882	2326	2307	2307
query89	389	318	290	290
query90	1934	217	215	215
query91	140	139	109	109
query92	79	59	58	58
query93	1962	936	580	580
query94	678	318	197	197
query95	376	289	287	287
query96	497	578	282	282
query97	2692	2788	2622	2622
query98	233	228	207	207
query99	1371	1438	1266	1266
Total cold run time: 275861 ms
Total hot run time: 189655 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.19 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9899a91722655fc68f8ba28adc491e1a5f56e852, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.60	0.10	0.10
query5	0.44	0.45	0.40
query6	1.16	0.65	0.66
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.62	0.50	0.51
query10	0.57	0.56	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.79	0.82	0.81
query15	0.89	0.88	0.86
query16	0.38	0.39	0.39
query17	1.06	1.04	1.03
query18	0.22	0.22	0.21
query19	1.96	1.87	1.95
query20	0.01	0.02	0.01
query21	15.41	0.88	0.54
query22	0.75	1.19	0.70
query23	14.92	1.37	0.65
query24	7.27	1.86	0.42
query25	0.35	0.25	0.07
query26	0.66	0.18	0.15
query27	0.06	0.04	0.04
query28	8.74	0.88	0.45
query29	12.57	4.04	3.31
query30	0.25	0.09	0.07
query31	2.84	0.60	0.38
query32	3.24	0.56	0.50
query33	3.12	3.13	3.09
query34	16.10	5.40	4.77
query35	4.84	4.84	4.80
query36	0.70	0.52	0.49
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.41 s
Total hot run time: 29.19 s

dataroaring
dataroaring previously approved these changes Jul 14, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (26/26) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.66% (15698/27225)
Line Coverage 46.36% (140030/302072)
Region Coverage 35.62% (104621/293745)
Branch Coverage 38.17% (46128/120834)

@bobhan1 bobhan1 requested a review from gavinchou as a code owner July 14, 2025 11:47
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 14, 2025
@bobhan1 bobhan1 force-pushed the seg-comp-should-wait-before-convert-dbm branch from 8ae861c to fe43e14 Compare July 14, 2025 11:54
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 14, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33490 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe43e143b43cbac6cf1dbc3c0b2c33195488e994, data reload: false

------ Round 1 ----------------------------------
q1	17565	5307	5104	5104
q2	1923	291	191	191
q3	10440	1380	716	716
q4	10283	1035	538	538
q5	8577	2442	2359	2359
q6	183	161	130	130
q7	910	736	600	600
q8	9334	1349	1137	1137
q9	7396	5115	5205	5115
q10	6918	2392	1985	1985
q11	502	296	283	283
q12	347	350	214	214
q13	17794	3744	3101	3101
q14	231	230	217	217
q15	552	469	482	469
q16	439	426	377	377
q17	598	910	380	380
q18	7818	7322	7116	7116
q19	1231	956	556	556
q20	359	362	225	225
q21	4009	2673	2378	2378
q22	361	326	299	299
Total cold run time: 107770 ms
Total hot run time: 33490 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5250	5134	5141	5134
q2	257	322	223	223
q3	2195	2711	2292	2292
q4	1357	1815	1320	1320
q5	4258	4589	4612	4589
q6	221	178	134	134
q7	2005	1971	1799	1799
q8	2664	2626	2591	2591
q9	7573	7175	7251	7175
q10	3097	3455	2832	2832
q11	578	520	480	480
q12	710	759	638	638
q13	3657	4028	3347	3347
q14	286	462	332	332
q15	530	472	472	472
q16	453	492	453	453
q17	1213	1594	1372	1372
q18	8013	7910	7717	7717
q19	839	878	914	878
q20	2060	2091	1987	1987
q21	5063	4660	4545	4545
q22	676	673	621	621
Total cold run time: 52955 ms
Total hot run time: 50931 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188135 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe43e143b43cbac6cf1dbc3c0b2c33195488e994, data reload: false

query1	978	383	389	383
query2	6509	1744	1717	1717
query3	6752	210	219	210
query4	26463	23400	23441	23400
query5	4350	587	445	445
query6	318	213	203	203
query7	4625	514	283	283
query8	277	220	218	218
query9	8624	2616	2636	2616
query10	467	318	279	279
query11	15331	15081	14809	14809
query12	161	104	102	102
query13	1659	544	425	425
query14	8613	5820	5867	5820
query15	226	193	168	168
query16	7312	644	488	488
query17	1227	721	595	595
query18	1994	407	300	300
query19	201	195	167	167
query20	125	117	113	113
query21	219	128	162	128
query22	4166	4317	4641	4317
query23	35168	34123	33656	33656
query24	8415	2352	2367	2352
query25	524	452	380	380
query26	1227	259	142	142
query27	2765	500	340	340
query28	4288	2089	2063	2063
query29	753	544	428	428
query30	282	218	190	190
query31	893	845	736	736
query32	73	63	55	55
query33	556	362	327	327
query34	794	837	505	505
query35	750	785	770	770
query36	959	983	927	927
query37	109	99	79	79
query38	4180	4122	4147	4122
query39	1470	1417	1431	1417
query40	201	113	105	105
query41	55	51	50	50
query42	126	107	102	102
query43	519	512	469	469
query44	1362	840	817	817
query45	175	171	170	170
query46	867	1030	626	626
query47	1750	1791	1712	1712
query48	387	417	306	306
query49	723	459	396	396
query50	651	690	411	411
query51	5548	5443	5507	5443
query52	109	103	98	98
query53	224	259	178	178
query54	562	566	495	495
query55	80	85	82	82
query56	301	282	278	278
query57	1182	1214	1107	1107
query58	254	248	247	247
query59	2644	2720	2579	2579
query60	321	317	306	306
query61	128	126	118	118
query62	807	711	656	656
query63	236	187	186	186
query64	4350	991	682	682
query65	4306	4177	4242	4177
query66	1168	409	313	313
query67	16036	15819	15815	15815
query68	8885	906	511	511
query69	457	315	271	271
query70	1241	1159	1139	1139
query71	486	327	306	306
query72	5565	4831	4813	4813
query73	575	627	345	345
query74	8918	9152	8946	8946
query75	4089	3160	2717	2717
query76	3663	1149	734	734
query77	907	391	295	295
query78	10142	10052	9288	9288
query79	4556	786	563	563
query80	678	513	437	437
query81	472	262	225	225
query82	346	124	101	101
query83	276	246	233	233
query84	290	103	87	87
query85	752	353	317	317
query86	330	297	311	297
query87	4351	4349	4393	4349
query88	2876	2292	2288	2288
query89	433	320	281	281
query90	2021	210	207	207
query91	131	138	106	106
query92	74	62	58	58
query93	2683	927	578	578
query94	678	406	324	324
query95	378	294	282	282
query96	491	574	280	280
query97	2690	2779	2675	2675
query98	224	217	195	195
query99	1392	1361	1288	1288
Total cold run time: 279925 ms
Total hot run time: 188135 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe43e143b43cbac6cf1dbc3c0b2c33195488e994, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.25	0.07	0.06
query4	1.63	0.11	0.12
query5	0.43	0.42	0.41
query6	1.18	0.65	0.68
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.52
query10	0.58	0.56	0.56
query11	0.15	0.11	0.12
query12	0.14	0.11	0.12
query13	0.62	0.61	0.61
query14	0.79	0.82	0.81
query15	0.89	0.88	0.88
query16	0.39	0.38	0.39
query17	1.07	1.05	1.06
query18	0.22	0.21	0.20
query19	1.92	1.80	1.85
query20	0.01	0.01	0.01
query21	15.40	0.89	0.55
query22	0.74	1.19	0.71
query23	14.90	1.41	0.65
query24	6.70	1.18	0.99
query25	0.48	0.21	0.12
query26	0.57	0.17	0.14
query27	0.07	0.05	0.05
query28	9.11	0.96	0.44
query29	12.54	4.04	3.28
query30	0.28	0.09	0.06
query31	2.83	0.59	0.38
query32	3.23	0.56	0.47
query33	3.08	3.18	3.14
query34	16.07	5.37	4.75
query35	4.88	4.81	4.81
query36	0.68	0.49	0.49
query37	0.08	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.13
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.07 s
Total hot run time: 29.75 s

@bobhan1 bobhan1 force-pushed the seg-comp-should-wait-before-convert-dbm branch 3 times, most recently from fd5fb89 to 88211a3 Compare July 15, 2025 06:32
@doris-robot
Copy link

TPC-H: Total hot run time: 34306 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 966b46ebec5ea2726a51255a8500a7f408e4323d, data reload: false

------ Round 1 ----------------------------------
q1	17581	5233	5094	5094
q2	1946	285	184	184
q3	10296	1272	734	734
q4	10219	1036	542	542
q5	7597	2415	2411	2411
q6	179	164	130	130
q7	919	756	597	597
q8	9339	1383	1157	1157
q9	7313	5219	5123	5123
q10	6902	2397	1991	1991
q11	485	292	279	279
q12	352	350	216	216
q13	17776	3702	3068	3068
q14	228	245	233	233
q15	553	492	479	479
q16	423	439	375	375
q17	627	881	366	366
q18	7490	7369	7174	7174
q19	1234	956	584	584
q20	350	340	230	230
q21	4019	3214	2362	2362
q22	1075	1008	977	977
Total cold run time: 106903 ms
Total hot run time: 34306 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5221	5121	5133	5121
q2	243	322	222	222
q3	2198	2662	2310	2310
q4	1394	1834	1346	1346
q5	4334	4480	4603	4480
q6	220	175	130	130
q7	2021	1994	1768	1768
q8	2645	2582	2555	2555
q9	7563	7444	7293	7293
q10	3092	3327	2839	2839
q11	564	505	504	504
q12	703	751	628	628
q13	3576	4270	3329	3329
q14	299	334	306	306
q15	545	485	482	482
q16	441	507	444	444
q17	1221	1558	1418	1418
q18	7928	7865	7582	7582
q19	835	859	907	859
q20	1937	1998	1832	1832
q21	4793	4348	4294	4294
q22	1085	1062	1021	1021
Total cold run time: 52858 ms
Total hot run time: 50763 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187646 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 966b46ebec5ea2726a51255a8500a7f408e4323d, data reload: false

query1	1004	381	391	381
query2	6520	1698	1685	1685
query3	6744	214	214	214
query4	26241	23777	22993	22993
query5	4359	576	435	435
query6	307	222	208	208
query7	4630	534	302	302
query8	282	230	235	230
query9	8619	2682	2761	2682
query10	487	341	284	284
query11	15667	15210	14852	14852
query12	159	106	104	104
query13	1652	534	388	388
query14	9316	5858	5919	5858
query15	231	200	171	171
query16	7241	627	457	457
query17	1178	728	579	579
query18	1979	402	298	298
query19	196	176	182	176
query20	121	121	115	115
query21	213	126	105	105
query22	4049	4276	4085	4085
query23	34007	33029	33421	33029
query24	8510	2420	2413	2413
query25	565	452	399	399
query26	1231	271	149	149
query27	2765	517	347	347
query28	4337	2157	2122	2122
query29	759	565	442	442
query30	287	213	188	188
query31	931	854	790	790
query32	75	72	71	71
query33	563	348	315	315
query34	839	853	529	529
query35	804	826	747	747
query36	990	1011	932	932
query37	114	99	75	75
query38	4232	4254	4110	4110
query39	1522	1439	1444	1439
query40	216	118	109	109
query41	57	56	55	55
query42	118	144	107	107
query43	528	516	489	489
query44	1342	823	839	823
query45	180	175	171	171
query46	844	1049	640	640
query47	1776	1854	1787	1787
query48	397	428	311	311
query49	730	489	403	403
query50	660	680	429	429
query51	5606	5617	5552	5552
query52	119	113	101	101
query53	224	259	186	186
query54	582	608	530	530
query55	85	81	86	81
query56	322	329	279	279
query57	1193	1188	1151	1151
query58	271	270	280	270
query59	2558	2697	2585	2585
query60	360	345	332	332
query61	175	154	156	154
query62	792	724	659	659
query63	227	203	197	197
query64	4415	1078	740	740
query65	4263	4201	4226	4201
query66	1145	439	336	336
query67	16036	15893	15791	15791
query68	8578	923	539	539
query69	482	324	275	275
query70	1288	1177	1082	1082
query71	465	343	321	321
query72	5624	4631	4585	4585
query73	702	568	356	356
query74	8844	9266	8839	8839
query75	3953	3209	2727	2727
query76	3656	1168	726	726
query77	791	396	301	301
query78	10083	10122	9337	9337
query79	2619	840	606	606
query80	624	516	469	469
query81	486	261	228	228
query82	511	129	100	100
query83	287	277	241	241
query84	298	110	87	87
query85	856	366	324	324
query86	386	337	315	315
query87	4523	4620	4471	4471
query88	3579	2296	2253	2253
query89	400	324	305	305
query90	1847	217	206	206
query91	137	139	115	115
query92	78	61	57	57
query93	1800	938	588	588
query94	678	427	299	299
query95	383	303	291	291
query96	504	579	279	279
query97	2799	2727	2674	2674
query98	236	210	208	208
query99	1433	1414	1274	1274
Total cold run time: 277877 ms
Total hot run time: 187646 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 966b46ebec5ea2726a51255a8500a7f408e4323d, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.24	0.07	0.08
query4	1.62	0.11	0.10
query5	0.44	0.44	0.43
query6	1.17	0.69	0.68
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.53	0.52
query10	0.59	0.57	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.64	0.62	0.62
query14	0.84	0.82	0.83
query15	0.91	0.91	0.87
query16	0.41	0.40	0.42
query17	1.05	1.07	1.08
query18	0.24	0.22	0.22
query19	1.98	1.85	1.83
query20	0.02	0.02	0.02
query21	15.40	0.91	0.54
query22	0.75	1.25	0.63
query23	14.95	1.43	0.64
query24	7.20	1.41	0.74
query25	0.48	0.11	0.14
query26	0.63	0.17	0.14
query27	0.06	0.05	0.06
query28	10.14	0.91	0.44
query29	12.61	4.00	3.32
query30	2.99	3.01	2.95
query31	2.82	0.61	0.38
query32	3.23	0.56	0.47
query33	3.17	3.22	3.23
query34	16.07	5.43	4.79
query35	4.83	4.82	4.83
query36	0.70	0.52	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.78 s
Total hot run time: 32.64 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 16, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34282 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bcc9251dda979eeef5c23d18d58d19cc4199a44b, data reload: false

------ Round 1 ----------------------------------
q1	17599	5342	5125	5125
q2	1939	288	184	184
q3	10303	1297	742	742
q4	10246	1024	505	505
q5	7718	2434	2386	2386
q6	202	161	132	132
q7	945	772	609	609
q8	9315	1369	1100	1100
q9	7461	5170	5135	5135
q10	6898	2398	2011	2011
q11	487	283	277	277
q12	337	355	216	216
q13	17779	3674	3114	3114
q14	224	234	213	213
q15	538	477	481	477
q16	450	441	391	391
q17	573	878	355	355
q18	7668	7268	7172	7172
q19	1220	980	580	580
q20	348	336	222	222
q21	4036	3191	2396	2396
q22	1041	1001	940	940
Total cold run time: 107327 ms
Total hot run time: 34282 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5234	5163	5172	5163
q2	257	317	210	210
q3	2184	2675	2305	2305
q4	1324	1783	1333	1333
q5	4419	4600	4591	4591
q6	216	173	131	131
q7	2025	1968	1861	1861
q8	2669	2726	2654	2654
q9	7371	7386	7213	7213
q10	3086	3289	2850	2850
q11	625	516	527	516
q12	683	757	649	649
q13	3678	4041	3468	3468
q14	273	301	290	290
q15	545	478	466	466
q16	445	516	469	469
q17	1184	1627	1396	1396
q18	7935	7804	7583	7583
q19	854	937	943	937
q20	2045	2102	1890	1890
q21	5085	4709	4628	4628
q22	1127	1104	1029	1029
Total cold run time: 53264 ms
Total hot run time: 51632 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188496 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bcc9251dda979eeef5c23d18d58d19cc4199a44b, data reload: false

query1	992	390	384	384
query2	6509	1689	1696	1689
query3	6752	211	212	211
query4	26952	23467	23593	23467
query5	4350	579	471	471
query6	313	222	201	201
query7	4620	516	295	295
query8	284	218	219	218
query9	8640	2661	2652	2652
query10	480	328	269	269
query11	15309	15213	14960	14960
query12	164	109	104	104
query13	1672	534	402	402
query14	8862	5870	5916	5870
query15	197	203	180	180
query16	7631	653	481	481
query17	1213	727	600	600
query18	2018	413	314	314
query19	198	189	159	159
query20	118	116	112	112
query21	222	126	108	108
query22	4297	4336	4602	4336
query23	34751	34172	34197	34172
query24	8448	2386	2344	2344
query25	530	463	378	378
query26	1223	259	146	146
query27	2749	501	360	360
query28	4348	2164	2139	2139
query29	725	574	428	428
query30	284	212	192	192
query31	910	847	762	762
query32	88	59	57	57
query33	555	368	306	306
query34	794	832	504	504
query35	765	821	750	750
query36	946	993	870	870
query37	105	91	69	69
query38	4245	4154	4139	4139
query39	1485	1445	1402	1402
query40	210	120	102	102
query41	58	52	53	52
query42	116	106	109	106
query43	505	511	466	466
query44	1289	822	805	805
query45	175	166	159	159
query46	835	1028	616	616
query47	1789	1816	1719	1719
query48	382	404	321	321
query49	740	472	408	408
query50	624	696	401	401
query51	5450	5433	5423	5423
query52	105	96	100	96
query53	216	250	182	182
query54	563	590	492	492
query55	87	79	81	79
query56	294	295	282	282
query57	1179	1201	1121	1121
query58	260	249	257	249
query59	2556	2584	2524	2524
query60	323	328	329	328
query61	121	118	116	116
query62	791	717	681	681
query63	228	181	178	178
query64	4294	976	648	648
query65	4313	4182	4178	4178
query66	1096	403	309	309
query67	15884	16020	15687	15687
query68	8240	909	540	540
query69	474	305	275	275
query70	1224	1079	1135	1079
query71	482	330	293	293
query72	5770	4790	4937	4790
query73	740	684	353	353
query74	9195	9135	8764	8764
query75	3909	3205	2714	2714
query76	3741	1152	720	720
query77	795	386	288	288
query78	10038	10068	9282	9282
query79	2793	842	614	614
query80	645	505	433	433
query81	482	259	219	219
query82	472	125	91	91
query83	277	261	241	241
query84	290	103	87	87
query85	792	360	426	360
query86	381	292	292	292
query87	4482	4454	4315	4315
query88	3339	2224	2273	2224
query89	412	329	290	290
query90	1889	212	201	201
query91	137	137	110	110
query92	72	60	53	53
query93	2027	928	583	583
query94	658	404	314	314
query95	368	292	285	285
query96	498	567	282	282
query97	2705	2728	2667	2667
query98	226	209	226	209
query99	1416	1422	1299	1299
Total cold run time: 278196 ms
Total hot run time: 188496 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bcc9251dda979eeef5c23d18d58d19cc4199a44b, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.08
query4	1.62	0.11	0.11
query5	0.45	0.42	0.43
query6	1.18	0.66	0.66
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.60	0.51	0.52
query10	0.58	0.56	0.58
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.63	0.61	0.62
query14	0.80	0.80	0.81
query15	0.90	0.87	0.88
query16	0.38	0.40	0.39
query17	1.06	1.06	1.08
query18	0.22	0.22	0.21
query19	1.91	1.86	1.80
query20	0.02	0.01	0.01
query21	15.46	0.89	0.56
query22	0.76	1.20	0.67
query23	14.89	1.38	0.67
query24	6.70	1.92	0.97
query25	0.44	0.22	0.27
query26	0.59	0.16	0.14
query27	0.06	0.06	0.06
query28	9.35	0.94	0.44
query29	12.59	3.91	3.29
query30	3.05	2.95	2.97
query31	2.82	0.58	0.37
query32	3.23	0.57	0.47
query33	3.02	3.09	3.20
query34	16.19	5.33	4.82
query35	4.85	4.82	4.88
query36	0.67	0.51	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.28 s
Total hot run time: 32.81 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 75.32% (58/77) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.51% (15729/27351)
Line Coverage 46.15% (140265/303932)
Region Coverage 35.42% (104535/295148)
Branch Coverage 38.05% (46106/121187)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 79.22% (61/77) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.15% (21772/26828)
Line Coverage 73.72% (223642/303377)
Region Coverage 61.01% (184740/302818)
Branch Coverage 65.11% (79777/122535)

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 9b6115d into apache:master Jul 17, 2025
24 of 28 checks passed
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 9, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)"

This reverts commit 9b6115d.
yiguolei pushed a commit that referenced this pull request Dec 9, 2025
…lete bitmap tasks on input segments before converting delete bitmaps on them (#53198)" (#58855)

This reverts commit 9b6115d.

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 16, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)"

This reverts commit 9b6115d.
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 16, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)"

This reverts commit 9b6115d.
liaoxin01 pushed a commit that referenced this pull request Dec 17, 2025
…tasks on input segments before converting delete bitmaps on them (#53198)" (#59066)

This reverts commit 9b6115d.

#53198 may result in load stuck and
timeout finally, revert it temporarily and will be added back after we
find the root cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants