[Chore](result-sink) set ENABLE_PARALLEL_RESULT_SINK default value to true #53209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
BiteTheDDDDt
changed the title
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
pushed a commit
that referenced
this pull request
Jul 23, 2025
… and dry_run_query=true. (#53653) Related PR: #36053 && #53209 Problem Summary: Fixed the issue that the result of `dry_run_query=true` is wrong in multi-be scenarios (the number of rows is less) I think this may be related to the multi result sink introduced in pr #36053 && #53209. Reason: ```cpp vmysql_result_writer.cpp GetResultBatchCtx::on_close() { ... statistics->set_returned_rows(returned_rows); // Set only once per result_writer. ... } ``` ``` java if (connectContext != null && connectContext.getSessionVariable().dryRunQuery) { if (resultBatch.isEos()) { // This will only be counted once. numReceivedRows += resultBatch.getQueryStatistics().getReturnedRows(); } } else if (resultBatch.getBatch() != null) { numReceivedRows += resultBatch.getBatch().getRowsSize(); } ``` If there are multiple be, there will be multiple result sinks, and each result sink will update its own row count at the end. Since `resultBatch.isEos()` is only triggered once, the row count information is less.
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 30, 2025
… and dry_run_query=true. (apache#53653) Related PR: apache#36053 && apache#53209 Problem Summary: Fixed the issue that the result of `dry_run_query=true` is wrong in multi-be scenarios (the number of rows is less) I think this may be related to the multi result sink introduced in pr apache#36053 && apache#53209. Reason: ```cpp vmysql_result_writer.cpp GetResultBatchCtx::on_close() { ... statistics->set_returned_rows(returned_rows); // Set only once per result_writer. ... } ``` ``` java if (connectContext != null && connectContext.getSessionVariable().dryRunQuery) { if (resultBatch.isEos()) { // This will only be counted once. numReceivedRows += resultBatch.getQueryStatistics().getReturnedRows(); } } else if (resultBatch.getBatch() != null) { numReceivedRows += resultBatch.getBatch().getRowsSize(); } ``` If there are multiple be, there will be multiple result sinks, and each result sink will update its own row count at the end. Since `resultBatch.isEos()` is only triggered once, the row count information is less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)