-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.1: [fix](auto bucket)Fix auto bucket calc bucketnum err when partition size is invalid #52801 #53249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morrySnow
merged 3 commits into
apache:branch-3.1
from
deardeng:pick_52801_to_doris_branch-3.1
Jul 16, 2025
Merged
branch-3.1: [fix](auto bucket)Fix auto bucket calc bucketnum err when partition size is invalid #52801 #53249
morrySnow
merged 3 commits into
apache:branch-3.1
from
deardeng:pick_52801_to_doris_branch-3.1
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize is invalid (apache#52801) …ize invalid 1. Fixed the problem that auto bucket will calculate wrong results when partition size is inaccurate - If `replica.size == 0`, filter out this replica. In the tablet.getDataSize function, the size is calculated by taking the average value of the replicas. When the size of a replica is 0, it will have a great impact on the average value. Therefore, the replicas with size=0 are filtered out. - If the partition size equals 0, do not include it in the estimation of the partition size. - If all versions with data partitions have sizes equal to 0, then the newly calculated bucket number for the partition will equal the bucket number of the previous version with a size greater than 0. Since we do not know the partition size of the data partitions (as stats thread have not been collected yet), we assume that the new partition's size equals the size of the previous version with a size greater than 0. Consequently, the bucket number will naturally equal that of the previous partition. 2. Added alarm log when the bucket num calculated by auto bucket exceeds the threshold
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 39381 ms |
TPC-DS: Total hot run time: 190747 ms |
ClickBench: Total hot run time: 30.13 s |
Contributor
|
run buildall |
TPC-H: Total hot run time: 39465 ms |
TPC-DS: Total hot run time: 196356 ms |
ClickBench: Total hot run time: 29.81 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39838 ms |
TPC-DS: Total hot run time: 190625 ms |
ClickBench: Total hot run time: 30.44 s |
morrySnow
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #52801