Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #49954

#49954)

### What problem does this PR solve?

will cast string to double

### Release note

aggregate function sum and avg support string type as parameter
@github-actions github-actions bot requested a review from dataroaring as a code owner July 15, 2025 03:57
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 15, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39676 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ba4221f6b38c396a49fe583ee58fc34e76ba7c1f, data reload: false

------ Round 1 ----------------------------------
q1	17570	6944	6560	6560
q2	2078	198	184	184
q3	10575	1142	1178	1142
q4	10285	713	693	693
q5	7757	2849	2815	2815
q6	219	134	132	132
q7	978	619	600	600
q8	9363	1940	2045	1940
q9	6643	6335	6394	6335
q10	7041	2273	2263	2263
q11	459	265	264	264
q12	409	218	219	218
q13	17789	2954	2955	2954
q14	236	199	204	199
q15	505	472	471	471
q16	482	377	369	369
q17	963	583	552	552
q18	7149	6699	6744	6699
q19	1378	1063	1019	1019
q20	475	203	203	203
q21	3883	3075	3188	3075
q22	1090	989	1001	989
Total cold run time: 107327 ms
Total hot run time: 39676 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6611	6624	6566	6566
q2	328	232	224	224
q3	2856	2867	2904	2867
q4	2061	1831	1853	1831
q5	5679	5699	5644	5644
q6	215	132	128	128
q7	2204	1859	1780	1780
q8	3366	3546	3499	3499
q9	8704	8819	8832	8819
q10	3533	3486	3494	3486
q11	608	510	489	489
q12	783	593	580	580
q13	9104	3126	3220	3126
q14	301	269	272	269
q15	527	468	466	466
q16	485	457	449	449
q17	1833	1632	1594	1594
q18	8225	7778	7783	7778
q19	1708	1610	1593	1593
q20	2048	1798	1779	1779
q21	5100	5046	5074	5046
q22	1121	1060	1014	1014
Total cold run time: 67400 ms
Total hot run time: 59027 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196596 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ba4221f6b38c396a49fe583ee58fc34e76ba7c1f, data reload: false

query1	1263	936	894	894
query2	6335	1894	1846	1846
query3	10789	4440	4427	4427
query4	33125	23596	23714	23596
query5	3775	466	434	434
query6	261	178	183	178
query7	3996	320	326	320
query8	298	232	220	220
query9	9559	2545	2543	2543
query10	442	249	250	249
query11	17820	15230	15090	15090
query12	148	104	98	98
query13	1535	426	400	400
query14	9657	6895	6720	6720
query15	220	187	190	187
query16	7935	500	509	500
query17	1600	587	575	575
query18	2057	328	318	318
query19	215	163	167	163
query20	120	116	120	116
query21	208	116	110	110
query22	4641	4400	4513	4400
query23	35028	34143	34160	34143
query24	11227	2948	2931	2931
query25	673	430	434	430
query26	1420	177	168	168
query27	3078	355	361	355
query28	7654	2134	2186	2134
query29	945	493	474	474
query30	269	161	163	161
query31	1012	825	834	825
query32	97	57	55	55
query33	763	310	308	308
query34	1229	535	551	535
query35	874	769	733	733
query36	1117	938	963	938
query37	132	68	67	67
query38	4055	4028	3912	3912
query39	1530	1460	1633	1460
query40	250	104	106	104
query41	51	51	52	51
query42	111	104	106	104
query43	516	509	484	484
query44	1302	825	825	825
query45	191	168	174	168
query46	1174	745	758	745
query47	2049	1920	1952	1920
query48	472	375	387	375
query49	925	402	414	402
query50	829	428	441	428
query51	7442	7222	7324	7222
query52	99	91	91	91
query53	267	183	178	178
query54	1236	478	484	478
query55	81	80	75	75
query56	265	257	265	257
query57	1336	1194	1224	1194
query58	217	202	215	202
query59	3174	2958	3024	2958
query60	272	256	249	249
query61	108	107	106	106
query62	888	693	678	678
query63	223	197	189	189
query64	4219	690	673	673
query65	3294	3301	3282	3282
query66	1222	298	294	294
query67	16081	15457	15581	15457
query68	4536	595	578	578
query69	435	259	272	259
query70	1183	1086	1099	1086
query71	332	253	251	251
query72	6275	4045	4008	4008
query73	761	351	350	350
query74	10075	8935	9266	8935
query75	3316	2618	2662	2618
query76	2595	1106	1052	1052
query77	371	266	279	266
query78	10582	9608	9641	9608
query79	2129	607	600	600
query80	1115	416	423	416
query81	562	217	222	217
query82	919	87	84	84
query83	229	143	148	143
query84	241	79	82	79
query85	1381	284	291	284
query86	462	294	285	285
query87	4422	4254	4322	4254
query88	3675	2399	2351	2351
query89	408	287	294	287
query90	1858	183	194	183
query91	198	146	146	146
query92	67	48	48	48
query93	2397	554	552	552
query94	826	291	299	291
query95	358	257	260	257
query96	616	277	287	277
query97	3271	3166	3162	3162
query98	229	202	194	194
query99	1515	1277	1273	1273
Total cold run time: 302735 ms
Total hot run time: 196596 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.07 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ba4221f6b38c396a49fe583ee58fc34e76ba7c1f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.50	0.51	0.50
query6	1.12	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.49	0.49
query10	0.55	0.57	0.57
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.61
query14	0.76	0.78	0.81
query15	0.84	0.82	0.82
query16	0.36	0.36	0.38
query17	0.99	1.02	1.02
query18	0.24	0.21	0.22
query19	1.95	1.83	1.84
query20	0.02	0.01	0.01
query21	15.41	0.61	0.59
query22	2.38	2.72	1.40
query23	16.89	0.98	0.91
query24	3.23	1.34	1.75
query25	0.17	0.06	0.20
query26	0.53	0.14	0.15
query27	0.04	0.05	0.04
query28	9.54	0.55	0.48
query29	12.58	3.22	3.21
query30	0.25	0.06	0.06
query31	2.86	0.39	0.37
query32	3.26	0.46	0.45
query33	2.99	2.95	3.00
query34	17.00	4.43	4.46
query35	4.50	4.50	4.48
query36	0.66	0.48	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.59 s
Total hot run time: 30.07 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c24e6dd into branch-3.0 Jul 15, 2025
23 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-49954-branch-3.0 branch July 15, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants