Skip to content

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Jul 15, 2025

pick #53114

@koarz koarz requested a review from dataroaring as a code owner July 15, 2025 11:04
@Thearas
Copy link
Contributor

Thearas commented Jul 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Jul 15, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 100.00% (30/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.00% (1168/1442)
Line Coverage 64.94% (19858/30578)
Region Coverage 66.61% (10057/15098)
Branch Coverage 56.24% (5307/9436)

@doris-robot
Copy link

TPC-H: Total hot run time: 40065 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4c5488cc3243214db04209dd5354d7ff67b83d05, data reload: false

------ Round 1 ----------------------------------
q1	17954	7384	6622	6622
q2	2076	160	165	160
q3	10641	1246	1262	1246
q4	10425	765	779	765
q5	7762	2950	2797	2797
q6	215	134	130	130
q7	980	622	622	622
q8	9358	2029	2059	2029
q9	6716	6458	6445	6445
q10	6994	2293	2326	2293
q11	458	269	260	260
q12	390	219	222	219
q13	17774	2978	3009	2978
q14	241	213	224	213
q15	522	478	467	467
q16	475	403	377	377
q17	996	597	551	551
q18	7340	6721	6468	6468
q19	1379	1138	1059	1059
q20	461	200	198	198
q21	3939	3291	3182	3182
q22	1126	987	984	984
Total cold run time: 108222 ms
Total hot run time: 40065 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6618	6567	6594	6567
q2	325	229	241	229
q3	2951	2979	2990	2979
q4	2072	1849	1801	1801
q5	5742	5826	5761	5761
q6	215	130	131	130
q7	2194	1785	1843	1785
q8	3378	3628	3571	3571
q9	8764	9001	8940	8940
q10	3571	3578	3521	3521
q11	590	486	506	486
q12	825	576	586	576
q13	9782	3219	3182	3182
q14	310	283	281	281
q15	526	465	469	465
q16	501	439	440	439
q17	1892	1664	1627	1627
q18	8336	7862	7804	7804
q19	1700	1541	1545	1541
q20	2072	1877	1890	1877
q21	5214	5200	5152	5152
q22	1152	1084	1018	1018
Total cold run time: 68730 ms
Total hot run time: 59732 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.21% (10950/26573)
Line Coverage 31.94% (93818/293706)
Region Coverage 31.08% (48369/155604)
Branch Coverage 27.53% (24781/90014)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197094 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4c5488cc3243214db04209dd5354d7ff67b83d05, data reload: false

query1	1280	918	894	894
query2	6281	1851	1894	1851
query3	10962	4504	4679	4504
query4	33106	23263	23781	23263
query5	3810	460	437	437
query6	290	177	197	177
query7	3990	326	328	326
query8	302	227	225	225
query9	9255	2605	2589	2589
query10	485	259	255	255
query11	18117	15153	15293	15153
query12	169	104	103	103
query13	1561	428	426	426
query14	8848	7382	7782	7382
query15	282	190	184	184
query16	8168	475	505	475
query17	1741	601	611	601
query18	2204	332	309	309
query19	378	164	171	164
query20	131	120	120	120
query21	207	107	115	107
query22	4832	4478	4405	4405
query23	34587	34127	34367	34127
query24	11584	2856	2916	2856
query25	692	422	436	422
query26	1717	180	169	169
query27	2827	351	358	351
query28	7642	2185	2196	2185
query29	1057	464	474	464
query30	257	166	168	166
query31	1006	801	843	801
query32	92	56	52	52
query33	756	293	298	293
query34	1042	530	519	519
query35	853	724	728	724
query36	1125	970	965	965
query37	273	67	68	67
query38	4137	3988	3940	3940
query39	1527	1469	1455	1455
query40	266	101	112	101
query41	50	48	48	48
query42	115	97	102	97
query43	525	470	485	470
query44	1272	824	839	824
query45	188	173	169	169
query46	1158	757	714	714
query47	1980	1924	1908	1908
query48	469	408	377	377
query49	1058	410	415	410
query50	856	462	436	436
query51	7438	7206	7281	7206
query52	103	91	88	88
query53	263	186	182	182
query54	1240	481	475	475
query55	77	78	77	77
query56	264	238	241	238
query57	1340	1185	1205	1185
query58	232	212	211	211
query59	3166	2939	2981	2939
query60	289	266	253	253
query61	112	110	104	104
query62	857	698	682	682
query63	228	196	186	186
query64	4930	668	634	634
query65	3394	3355	3300	3300
query66	1327	294	297	294
query67	16588	15443	15595	15443
query68	4933	585	570	570
query69	444	270	257	257
query70	1179	1089	1118	1089
query71	353	255	252	252
query72	6200	4150	3983	3983
query73	767	366	374	366
query74	10423	9003	9305	9003
query75	3389	2648	2658	2648
query76	2644	1051	1094	1051
query77	442	266	273	266
query78	10540	9681	9677	9677
query79	1992	604	607	604
query80	740	431	424	424
query81	493	218	221	218
query82	703	87	88	87
query83	159	150	143	143
query84	246	78	78	78
query85	1380	301	295	295
query86	434	306	260	260
query87	4499	4232	4218	4218
query88	4204	2425	2383	2383
query89	429	287	292	287
query90	2080	183	183	183
query91	179	147	148	147
query92	62	50	50	50
query93	2148	565	558	558
query94	846	295	275	275
query95	351	259	262	259
query96	623	279	280	279
query97	3300	3168	3128	3128
query98	222	207	196	196
query99	1487	1303	1343	1303
Total cold run time: 305249 ms
Total hot run time: 197094 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4c5488cc3243214db04209dd5354d7ff67b83d05, data reload: false

query1	0.03	0.03	0.03
query2	0.10	0.04	0.04
query3	0.23	0.06	0.06
query4	1.66	0.08	0.08
query5	0.53	0.50	0.55
query6	1.12	0.74	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.49	0.51
query10	0.59	0.56	0.58
query11	0.16	0.12	0.13
query12	0.16	0.13	0.12
query13	0.61	0.60	0.59
query14	0.78	0.82	0.82
query15	0.87	0.86	0.84
query16	0.36	0.37	0.38
query17	1.07	1.05	1.01
query18	0.18	0.19	0.18
query19	1.87	1.84	1.83
query20	0.02	0.02	0.01
query21	15.42	0.67	0.66
query22	3.79	6.38	2.62
query23	18.23	1.43	1.36
query24	2.19	0.23	0.21
query25	0.15	0.10	0.09
query26	0.28	0.18	0.17
query27	0.08	0.08	0.08
query28	13.30	0.62	0.59
query29	12.66	3.36	3.31
query30	0.26	0.06	0.07
query31	2.87	0.41	0.41
query32	3.23	0.48	0.48
query33	3.00	3.03	3.07
query34	17.13	4.59	4.63
query35	4.68	4.61	4.64
query36	0.66	0.48	0.48
query37	0.18	0.16	0.16
query38	0.16	0.16	0.16
query39	0.06	0.05	0.04
query40	0.16	0.13	0.13
query41	0.10	0.06	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 109.67 s
Total hot run time: 31.81 s

@koarz koarz changed the title [enhance](meta-service) add real request ip for be rpc #53114. branch-3.0 [enhance](meta-service) add real request ip for be rpc #53114. Jul 16, 2025
@koarz
Copy link
Contributor Author

koarz commented Jul 16, 2025

run nonConcurrent

1 similar comment
@koarz
Copy link
Contributor Author

koarz commented Jul 16, 2025

run nonConcurrent

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@koarz
Copy link
Contributor Author

koarz commented Jul 17, 2025

run nonConcurrent

@dataroaring dataroaring merged commit 2e0cd89 into apache:branch-3.0 Jul 17, 2025
23 of 26 checks passed
@koarz koarz deleted the ms_be_ip3.0 branch July 18, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants