Skip to content

[fix](json) incorrect results of json_contains (#53291) #53364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 17, 2025
Merged

[fix](json) incorrect results of json_contains (#53291) #53364

dataroaring merged 1 commit into from
Jul 17, 2025

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 16, 2025

Fix the incorrect results and remove unused code.

Pick: #53291

Problem Summary:

None

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:

  • This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.

  • Yes.

  • Confirm the release note

  • Confirm test cases

  • Confirm document

  • Add branch pick label

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg mrhhsg requested a review from dataroaring as a code owner July 16, 2025 06:09
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-H: Total hot run time: 40185 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0021454accecb3b55294daacb0acafdc6d244e8e, data reload: false

------ Round 1 ----------------------------------
q1	17575	7060	6673	6673
q2	2091	165	165	165
q3	10654	1178	1182	1178
q4	10400	750	798	750
q5	7762	2844	2845	2844
q6	208	133	135	133
q7	998	631	598	598
q8	9353	1977	2032	1977
q9	6678	6423	6419	6419
q10	6949	2300	2275	2275
q11	462	261	258	258
q12	407	216	219	216
q13	17789	2989	3014	2989
q14	231	199	211	199
q15	509	468	467	467
q16	501	396	372	372
q17	998	617	604	604
q18	7627	6653	6683	6653
q19	1401	1090	1064	1064
q20	492	205	202	202
q21	3872	3186	3163	3163
q22	1109	993	986	986
Total cold run time: 108066 ms
Total hot run time: 40185 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6691	6658	6613	6613
q2	341	238	236	236
q3	2928	2984	2929	2929
q4	2036	1841	1749	1749
q5	5709	5753	5776	5753
q6	208	129	137	129
q7	2230	1789	1802	1789
q8	3383	3537	3572	3537
q9	8773	8904	8856	8856
q10	3543	3506	3520	3506
q11	602	492	500	492
q12	775	605	585	585
q13	9784	3193	3166	3166
q14	308	265	283	265
q15	517	458	472	458
q16	489	440	450	440
q17	1864	1658	1640	1640
q18	8344	7669	7799	7669
q19	1670	1693	1550	1550
q20	2053	1882	1871	1871
q21	5252	5063	4985	4985
q22	1104	1057	1028	1028
Total cold run time: 68604 ms
Total hot run time: 59246 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.22% (10948/26563)
Line Coverage 31.95% (93807/293607)
Region Coverage 31.10% (48367/155525)
Branch Coverage 27.54% (24776/89960)

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-DS: Total hot run time: 195748 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0021454accecb3b55294daacb0acafdc6d244e8e, data reload: false

query1	1313	908	892	892
query2	6288	1999	1854	1854
query3	10807	4260	4485	4260
query4	36450	23881	23282	23282
query5	3850	454	448	448
query6	264	169	165	165
query7	4003	308	306	306
query8	271	222	220	220
query9	9430	2589	2588	2588
query10	460	270	251	251
query11	16588	15155	15549	15155
query12	158	99	106	99
query13	1555	417	399	399
query14	9036	7610	6764	6764
query15	243	188	194	188
query16	7987	487	491	487
query17	1605	622	630	622
query18	2193	327	318	318
query19	251	171	170	170
query20	128	117	112	112
query21	209	108	120	108
query22	4806	4346	4447	4346
query23	35066	34212	33606	33606
query24	11705	2903	2858	2858
query25	692	433	438	433
query26	1767	182	175	175
query27	3005	368	362	362
query28	7815	2200	2209	2200
query29	1053	468	467	467
query30	271	156	158	156
query31	1048	826	870	826
query32	119	57	59	57
query33	743	298	304	298
query34	999	518	512	512
query35	830	753	759	753
query36	1087	933	906	906
query37	272	68	66	66
query38	4141	3941	3923	3923
query39	1543	1628	1484	1484
query40	265	108	104	104
query41	50	52	52	52
query42	113	99	102	99
query43	507	480	484	480
query44	1372	807	835	807
query45	182	170	167	167
query46	1162	758	740	740
query47	2023	1896	1961	1896
query48	478	399	385	385
query49	1052	390	415	390
query50	834	419	445	419
query51	7435	7305	7232	7232
query52	99	95	88	88
query53	260	183	187	183
query54	1210	473	478	473
query55	81	82	80	80
query56	259	251	251	251
query57	1324	1225	1231	1225
query58	219	207	214	207
query59	3200	2985	3010	2985
query60	299	260	269	260
query61	111	106	121	106
query62	827	702	709	702
query63	228	189	198	189
query64	5274	649	625	625
query65	3387	3303	3318	3303
query66	1212	297	289	289
query67	15997	15680	15546	15546
query68	4900	574	589	574
query69	458	270	276	270
query70	1166	1057	1104	1057
query71	335	255	247	247
query72	6178	4060	3994	3994
query73	751	349	345	345
query74	10555	8985	9170	8985
query75	3353	2627	2667	2627
query76	2626	1086	1157	1086
query77	358	270	275	270
query78	10552	9613	9559	9559
query79	1103	611	600	600
query80	920	439	428	428
query81	569	222	219	219
query82	427	91	85	85
query83	243	144	144	144
query84	230	80	76	76
query85	1286	297	291	291
query86	408	302	306	302
query87	4360	4166	4289	4166
query88	3881	2381	2358	2358
query89	406	291	293	291
query90	2132	184	181	181
query91	178	150	150	150
query92	61	48	48	48
query93	1985	565	572	565
query94	1067	295	308	295
query95	379	254	253	253
query96	618	278	276	276
query97	3265	3146	3131	3131
query98	216	206	196	196
query99	1492	1284	1280	1280
Total cold run time: 305969 ms
Total hot run time: 195748 ms

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

ClickBench: Total hot run time: 29.78 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0021454accecb3b55294daacb0acafdc6d244e8e, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.59	0.10	0.10
query5	0.53	0.49	0.52
query6	1.12	0.73	0.74
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.56	0.50	0.49
query10	0.54	0.57	0.56
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.60	0.60
query14	0.77	0.78	0.80
query15	0.84	0.83	0.82
query16	0.39	0.41	0.38
query17	1.06	1.06	1.05
query18	0.23	0.22	0.22
query19	1.93	1.78	1.85
query20	0.02	0.01	0.01
query21	15.40	0.58	0.58
query22	2.55	2.01	1.46
query23	16.99	0.96	0.94
query24	3.02	0.81	1.59
query25	0.23	0.12	0.12
query26	0.50	0.14	0.13
query27	0.05	0.04	0.04
query28	10.09	0.53	0.47
query29	12.58	3.29	3.26
query30	0.25	0.06	0.06
query31	2.86	0.39	0.40
query32	3.23	0.45	0.44
query33	2.97	3.02	3.04
query34	17.12	4.48	4.46
query35	4.52	4.54	4.47
query36	0.67	0.46	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 104.33 s
Total hot run time: 29.78 s

@mrhhsg
[fix](json) incorrect results of json_contains (apache#53291)
ad36a98 
Fix the incorrect results and remove unused code.

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-H: Total hot run time: 39515 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad36a98b4438f138bfcc66cde8309b995e11130b, data reload: false

------ Round 1 ----------------------------------
q1	17833	6930	6584	6584
q2	2080	158	156	156
q3	10698	1135	1172	1135
q4	10543	723	787	723
q5	7686	2913	2766	2766
q6	219	129	130	129
q7	963	610	595	595
q8	9337	1929	2028	1929
q9	6732	6393	6429	6393
q10	7002	2261	2283	2261
q11	466	252	264	252
q12	394	214	223	214
q13	17782	2984	2976	2976
q14	246	209	204	204
q15	502	471	479	471
q16	511	386	368	368
q17	978	612	587	587
q18	7371	6567	6574	6567
q19	1403	1034	1079	1034
q20	488	201	207	201
q21	3845	3238	3007	3007
q22	1101	983	963	963
Total cold run time: 108180 ms
Total hot run time: 39515 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6631	6533	6563	6533
q2	328	229	226	226
q3	2909	2927	2912	2912
q4	1981	1837	1854	1837
q5	5694	5722	5693	5693
q6	209	129	128	128
q7	2255	1796	1842	1796
q8	3344	3522	3536	3522
q9	8743	8934	8888	8888
q10	3554	3536	3553	3536
q11	599	501	510	501
q12	810	577	579	577
q13	7688	3158	3144	3144
q14	315	262	286	262
q15	515	453	454	453
q16	482	433	436	433
q17	1845	1643	1638	1638
q18	8289	7822	7790	7790
q19	1664	1612	1467	1467
q20	2050	1872	1843	1843
q21	5170	4937	4954	4937
q22	1128	1039	1003	1003
Total cold run time: 66203 ms
Total hot run time: 59119 ms

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

TPC-DS: Total hot run time: 196530 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad36a98b4438f138bfcc66cde8309b995e11130b, data reload: false

query1	1284	891	897	891
query2	6247	1872	1879	1872
query3	10933	4486	4400	4400
query4	32980	23470	23424	23424
query5	3490	456	465	456
query6	243	173	173	173
query7	3986	311	324	311
query8	274	219	216	216
query9	9425	2584	2568	2568
query10	477	261	253	253
query11	18287	15005	15558	15005
query12	155	101	98	98
query13	1548	430	426	426
query14	10292	7050	7182	7050
query15	255	189	183	183
query16	7915	485	550	485
query17	1661	612	607	607
query18	2165	339	322	322
query19	250	169	174	169
query20	127	114	117	114
query21	204	110	107	107
query22	4844	4393	4461	4393
query23	34542	34329	34111	34111
query24	11518	2940	2847	2847
query25	704	447	435	435
query26	1244	164	184	164
query27	2708	350	358	350
query28	7460	2206	2161	2161
query29	883	456	474	456
query30	270	164	162	162
query31	1157	836	804	804
query32	89	56	56	56
query33	751	290	288	288
query34	1036	524	530	524
query35	871	744	726	726
query36	1109	930	958	930
query37	127	66	65	65
query38	4033	3961	3876	3876
query39	1538	1468	1475	1468
query40	210	106	107	106
query41	53	52	53	52
query42	113	105	102	102
query43	526	477	485	477
query44	1265	825	819	819
query45	188	165	171	165
query46	1162	724	707	707
query47	2047	1954	1967	1954
query48	488	386	408	386
query49	988	392	389	389
query50	832	429	442	429
query51	7394	7249	7137	7137
query52	107	94	92	92
query53	256	187	187	187
query54	1151	465	481	465
query55	81	77	80	77
query56	256	249	251	249
query57	1326	1209	1193	1193
query58	238	217	223	217
query59	3163	2927	2979	2927
query60	303	257	252	252
query61	112	110	142	110
query62	877	682	684	682
query63	222	202	202	202
query64	4170	678	639	639
query65	3384	3362	3276	3276
query66	1315	292	301	292
query67	15851	15727	15569	15569
query68	4767	601	572	572
query69	450	265	268	265
query70	1159	1081	1088	1081
query71	354	253	250	250
query72	6260	4017	3802	3802
query73	749	342	343	342
query74	10414	9258	9197	9197
query75	3358	2642	2701	2642
query76	2670	1053	1023	1023
query77	388	259	258	258
query78	10501	9641	9592	9592
query79	2436	611	610	610
query80	1167	412	417	412
query81	540	217	223	217
query82	739	85	82	82
query83	229	139	137	137
query84	233	76	79	76
query85	1481	319	282	282
query86	449	302	297	297
query87	4330	4244	4242	4242
query88	4419	2392	2359	2359
query89	411	297	294	294
query90	1997	190	185	185
query91	183	147	143	143
query92	61	49	50	49
query93	2424	555	560	555
query94	797	301	298	298
query95	362	261	260	260
query96	615	281	276	276
query97	3346	3126	3145	3126
query98	222	201	191	191
query99	1525	1328	1317	1317
Total cold run time: 304196 ms
Total hot run time: 196530 ms

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

ClickBench: Total hot run time: 30.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad36a98b4438f138bfcc66cde8309b995e11130b, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.53	0.50	0.50
query6	1.15	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.49	0.50
query10	0.54	0.55	0.58
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.59
query14	0.77	0.79	0.79
query15	0.84	0.81	0.82
query16	0.40	0.39	0.37
query17	1.05	1.03	1.06
query18	0.23	0.22	0.20
query19	1.88	1.79	1.74
query20	0.01	0.01	0.01
query21	15.40	0.58	0.58
query22	2.72	1.79	1.78
query23	16.87	1.01	0.87
query24	3.33	1.14	1.61
query25	0.22	0.15	0.14
query26	0.47	0.14	0.14
query27	0.05	0.04	0.05
query28	9.44	0.52	0.47
query29	12.56	3.20	3.19
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.45	0.45
query33	2.99	2.98	2.98
query34	17.20	4.50	4.47
query35	4.53	4.53	4.60
query36	0.67	0.48	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.18 s
Total hot run time: 30.27 s

@doris-robot
Copy link

doris-robot commented Jul 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.21% (10947/26563)
Line Coverage 31.95% (93814/293607)
Region Coverage 31.10% (48369/155525)
Branch Coverage 27.55% (24781/89960)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.95% (19651/26218)
Line Coverage 68.24% (200093/293208)
Region Coverage 66.36% (119570/180184)
Branch Coverage 59.68% (60700/101714)

dataroaring
dataroaring approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d7cbe47 into apache:branch-3.0 Jul 17, 2025
22 of 25 checks passed
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Jul 17, 2025
@mrhhsg
[fix](json) incorrect results of json_contains (apache#53291) (apache…
12e2c76 
…#53364)

Fix the incorrect results and remove unused code.

Pick: apache#53291
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrhhsg @hello-stephen @doris-robot @dataroaring