Skip to content

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Jul 17, 2025

pick and refact from #53235

@airborne12 airborne12 requested a review from morrySnow as a code owner July 17, 2025 03:45
@Thearas
Copy link
Contributor

Thearas commented Jul 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 81.08% (90/111) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.24% (12539/27718)
Line Coverage 36.10% (111393/308603)
Region Coverage 35.17% (57613/163835)
Branch Coverage 32.36% (31325/96816)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 82.41% (89/108) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.10% (20839/27385)
Line Coverage 69.47% (214234/308365)
Region Coverage 67.48% (128094/189814)
Branch Coverage 61.05% (66651/109180)

@doris-robot
Copy link

TPC-H: Total hot run time: 39744 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cfe9ab5ca85456617bde23bf69d105c9261aab95, data reload: false

------ Round 1 ----------------------------------
q1	17572	6824	6609	6609
q2	2078	189	187	187
q3	10503	1167	1169	1167
q4	10220	770	735	735
q5	7746	2872	2731	2731
q6	225	133	133	133
q7	998	610	626	610
q8	9349	1968	1988	1968
q9	6756	6429	6459	6429
q10	7049	2350	2282	2282
q11	477	270	272	270
q12	400	210	214	210
q13	17800	3005	3005	3005
q14	229	206	212	206
q15	519	458	472	458
q16	478	379	378	378
q17	999	619	511	511
q18	7312	6808	6554	6554
q19	1326	998	936	936
q20	488	211	207	207
q21	3953	3165	3178	3165
q22	1120	993	1025	993
Total cold run time: 107597 ms
Total hot run time: 39744 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6599	6605	6603	6603
q2	328	235	231	231
q3	2888	2994	2942	2942
q4	2057	1778	1800	1778
q5	5709	5753	5766	5753
q6	229	133	133	133
q7	2223	1810	1846	1810
q8	3382	3502	3589	3502
q9	8709	8923	8906	8906
q10	3554	3571	3527	3527
q11	601	485	497	485
q12	809	621	585	585
q13	9252	3187	3143	3143
q14	320	288	282	282
q15	515	466	457	457
q16	494	452	449	449
q17	1887	1648	1625	1625
q18	8244	7856	7917	7856
q19	1681	1499	1457	1457
q20	2064	1900	1878	1878
q21	5208	5129	4996	4996
q22	1150	1087	1036	1036
Total cold run time: 67903 ms
Total hot run time: 59434 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197448 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cfe9ab5ca85456617bde23bf69d105c9261aab95, data reload: false

query1	1307	914	908	908
query2	6341	1930	1942	1930
query3	10941	4410	4681	4410
query4	33543	23947	23423	23423
query5	3649	470	453	453
query6	285	179	178	178
query7	4008	315	317	315
query8	296	234	226	226
query9	9500	2584	2571	2571
query10	474	271	272	271
query11	17846	15223	15597	15223
query12	167	111	103	103
query13	1561	411	413	411
query14	9110	6951	6992	6951
query15	241	180	201	180
query16	7752	515	476	476
query17	1630	633	606	606
query18	2040	320	320	320
query19	227	177	173	173
query20	125	116	123	116
query21	204	112	112	112
query22	4755	4525	4438	4438
query23	35160	34006	35009	34006
query24	12749	3068	2967	2967
query25	636	461	427	427
query26	1455	176	174	174
query27	3026	357	356	356
query28	7494	2174	2167	2167
query29	728	463	479	463
query30	279	161	173	161
query31	1050	826	867	826
query32	92	59	62	59
query33	770	299	295	295
query34	1026	507	519	507
query35	887	769	724	724
query36	1122	964	969	964
query37	196	71	68	68
query38	4150	4011	3979	3979
query39	1534	1482	1469	1469
query40	267	106	103	103
query41	48	47	51	47
query42	123	107	99	99
query43	535	497	492	492
query44	1351	823	815	815
query45	187	190	175	175
query46	1174	732	733	732
query47	2036	1923	1925	1923
query48	454	359	356	356
query49	1013	402	409	402
query50	845	431	430	430
query51	7486	7443	7327	7327
query52	106	92	97	92
query53	261	182	192	182
query54	1179	472	486	472
query55	82	81	82	81
query56	281	274	267	267
query57	1332	1219	1236	1219
query58	231	211	213	211
query59	3178	3109	3221	3109
query60	299	266	271	266
query61	115	111	109	109
query62	904	742	684	684
query63	234	201	196	196
query64	4864	689	647	647
query65	3362	3320	3295	3295
query66	1629	313	315	313
query67	16032	15507	15451	15451
query68	4968	575	564	564
query69	441	276	262	262
query70	1200	1133	1094	1094
query71	352	287	261	261
query72	5997	4002	4114	4002
query73	764	350	354	350
query74	10556	8952	9223	8952
query75	3364	2636	2667	2636
query76	2606	1120	1135	1120
query77	368	292	268	268
query78	10544	9713	9594	9594
query79	1665	604	590	590
query80	1143	435	420	420
query81	546	227	223	223
query82	975	91	88	88
query83	232	143	145	143
query84	238	80	82	80
query85	1405	301	302	301
query86	390	297	303	297
query87	4373	4265	4250	4250
query88	3813	2407	2377	2377
query89	424	294	293	293
query90	1968	192	188	188
query91	143	107	106	106
query92	64	52	53	52
query93	1958	544	547	544
query94	917	296	302	296
query95	376	270	264	264
query96	613	288	284	284
query97	3283	3145	3210	3145
query98	212	210	196	196
query99	1507	1307	1334	1307
Total cold run time: 305369 ms
Total hot run time: 197448 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.16 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cfe9ab5ca85456617bde23bf69d105c9261aab95, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.11	0.11
query5	0.60	0.51	0.52
query6	1.13	0.72	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.50	0.49
query10	0.54	0.55	0.56
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.60	0.60	0.60
query14	0.77	0.79	0.81
query15	0.85	0.84	0.82
query16	0.38	0.41	0.38
query17	1.02	0.98	1.05
query18	0.23	0.22	0.22
query19	1.89	1.83	1.85
query20	0.01	0.02	0.01
query21	15.38	0.58	0.58
query22	2.23	2.30	1.73
query23	16.86	0.85	0.87
query24	3.35	1.68	0.95
query25	0.24	0.18	0.14
query26	0.47	0.14	0.14
query27	0.04	0.05	0.04
query28	9.64	0.51	0.47
query29	12.58	3.16	3.19
query30	0.24	0.06	0.06
query31	2.85	0.39	0.39
query32	3.23	0.46	0.45
query33	3.02	2.99	3.01
query34	16.80	4.50	4.52
query35	4.59	4.54	4.58
query36	0.64	0.48	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.57 s
Total hot run time: 30.16 s

@airborne12 airborne12 changed the title [fix](inverted index) fix memory leak in inverted index procedure branch-3.1: [fix](inverted index) fix memory leak in inverted index procedure Jul 17, 2025
@morrySnow morrySnow merged commit cbdb8e2 into apache:branch-3.1 Jul 18, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants