Skip to content

branch-3.1: [Enhancement](Log) Missing rowset clone should not print stack log #53193 #53526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 19, 2025
Merged

branch-3.1: [Enhancement](Log) Missing rowset clone should not print stack log #53193 #53526

morrySnow merged 1 commit into from
Jul 19, 2025

Conversation

@Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Jul 18, 2025 •
edited by morrySnow
Loading

Pick #53193

@Yukang-Lian Yukang-Lian requested a review from morrySnow as a code owner July 18, 2025 07:12
@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Jul 18, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jul 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-H: Total hot run time: 40253 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7bb370a9931dec8ba8361701cc8de8efce4c3e5, data reload: false

------ Round 1 ----------------------------------
q1	17665	6958	6673	6673
q2	2091	185	180	180
q3	10720	1167	1141	1141
q4	10516	719	750	719
q5	7770	2987	2822	2822
q6	223	141	140	140
q7	979	627	613	613
q8	9592	1979	2032	1979
q9	7975	6413	6447	6413
q10	7022	2287	2308	2287
q11	458	264	264	264
q12	528	214	218	214
q13	17789	3053	2982	2982
q14	241	218	217	217
q15	521	469	468	468
q16	472	388	375	375
q17	999	635	629	629
q18	7116	6663	6681	6663
q19	1269	1060	1052	1052
q20	494	212	209	209
q21	4018	3261	3224	3224
q22	1123	999	989	989
Total cold run time: 109581 ms
Total hot run time: 40253 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6755	6681	6774	6681
q2	325	243	233	233
q3	3129	2990	2939	2939
q4	2124	1810	1815	1810
q5	5702	5781	5791	5781
q6	213	129	138	129
q7	2238	1808	1817	1808
q8	3381	3588	3447	3447
q9	8879	8936	8863	8863
q10	3607	3543	3580	3543
q11	589	495	502	495
q12	821	603	656	603
q13	3889	3215	3227	3215
q14	300	261	271	261
q15	520	473	475	473
q16	509	465	450	450
q17	1865	1656	1638	1638
q18	8413	7922	7703	7703
q19	1696	1589	1606	1589
q20	2123	1883	1885	1883
q21	5257	5170	5046	5046
q22	1187	1038	1066	1038
Total cold run time: 63522 ms
Total hot run time: 59628 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-DS: Total hot run time: 198808 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7bb370a9931dec8ba8361701cc8de8efce4c3e5, data reload: false

query1	1334	992	980	980
query2	6172	1966	1987	1966
query3	10980	4549	4565	4549
query4	32936	23763	24013	23763
query5	4243	483	472	472
query6	290	189	176	176
query7	3982	317	314	314
query8	289	238	237	237
query9	9496	2576	2583	2576
query10	498	276	271	271
query11	18253	15400	15338	15338
query12	173	112	109	109
query13	1564	429	423	423
query14	9725	7104	8222	7104
query15	265	199	207	199
query16	8173	502	534	502
query17	1661	624	612	612
query18	2158	354	322	322
query19	387	171	178	171
query20	127	118	122	118
query21	206	111	107	107
query22	4711	4391	4675	4391
query23	34840	34137	34296	34137
query24	11809	3034	2918	2918
query25	715	446	451	446
query26	1745	181	205	181
query27	2844	357	369	357
query28	7763	2202	2144	2144
query29	1072	470	487	470
query30	277	168	174	168
query31	1054	834	846	834
query32	122	58	66	58
query33	792	305	337	305
query34	1161	542	541	541
query35	898	745	739	739
query36	1124	961	964	961
query37	287	72	76	72
query38	4153	4003	4027	4003
query39	1538	1479	1488	1479
query40	278	110	108	108
query41	51	48	51	48
query42	120	108	106	106
query43	555	505	509	505
query44	1300	815	829	815
query45	197	182	181	181
query46	1186	746	739	739
query47	2003	1908	1955	1908
query48	437	352	350	350
query49	1121	405	397	397
query50	847	442	462	442
query51	7433	7198	7254	7198
query52	107	93	96	93
query53	263	186	186	186
query54	1193	482	481	481
query55	86	81	83	81
query56	283	258	257	257
query57	1338	1205	1191	1191
query58	267	217	224	217
query59	3377	3067	3071	3067
query60	296	267	259	259
query61	114	107	107	107
query62	846	708	670	670
query63	221	199	194	194
query64	4947	661	633	633
query65	3343	3252	3232	3232
query66	1397	308	308	308
query67	16127	15540	15602	15540
query68	4793	596	586	586
query69	431	272	275	272
query70	1156	1087	1106	1087
query71	356	279	297	279
query72	6273	4113	4118	4113
query73	757	360	376	360
query74	10410	9108	9282	9108
query75	3417	2686	2712	2686
query76	2751	1083	1137	1083
query77	462	281	289	281
query78	10635	9577	9635	9577
query79	1761	612	621	612
query80	1186	442	444	442
query81	533	230	227	227
query82	933	95	87	87
query83	235	155	151	151
query84	233	87	81	81
query85	1451	325	302	302
query86	388	300	301	300
query87	4429	4277	4336	4277
query88	3558	2439	2409	2409
query89	426	290	297	290
query90	2101	193	193	193
query91	140	109	111	109
query92	64	51	56	51
query93	1869	560	557	557
query94	1077	307	258	258
query95	377	262	275	262
query96	616	285	291	285
query97	3267	3156	3137	3137
query98	233	208	213	208
query99	1494	1312	1324	1312
Total cold run time: 307362 ms
Total hot run time: 198808 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

ClickBench: Total hot run time: 30.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d7bb370a9931dec8ba8361701cc8de8efce4c3e5, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.52	0.50	0.52
query6	1.13	0.74	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.54
query10	0.54	0.55	0.56
query11	0.14	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.59	0.60
query14	0.77	0.81	0.79
query15	0.86	0.83	0.82
query16	0.38	0.40	0.38
query17	1.05	1.10	1.05
query18	0.23	0.22	0.21
query19	1.86	1.71	1.76
query20	0.01	0.01	0.01
query21	15.39	0.61	0.60
query22	2.50	1.74	1.91
query23	16.86	1.09	0.81
query24	3.42	1.10	1.28
query25	0.34	0.20	0.09
query26	0.42	0.14	0.13
query27	0.05	0.04	0.04
query28	9.88	0.50	0.47
query29	12.55	3.20	3.19
query30	0.25	0.06	0.06
query31	2.86	0.40	0.38
query32	3.23	0.47	0.45
query33	2.96	3.00	3.00
query34	17.13	4.60	4.53
query35	4.60	4.54	4.53
query36	0.68	0.48	0.49
query37	0.08	0.06	0.05
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.42 s
Total hot run time: 30.2 s

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.23% (12542/27727)
Line Coverage 36.13% (111567/308807)
Region Coverage 35.21% (57707/163894)
Branch Coverage 32.40% (31376/96832)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 18, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20853/27394)
Line Coverage 69.51% (214485/308570)
Region Coverage 67.55% (128259/189882)
Branch Coverage 61.15% (66775/109206)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 18, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20853/27394)
Line Coverage 69.51% (214485/308570)
Region Coverage 67.55% (128259/189882)
Branch Coverage 61.15% (66775/109206)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 18, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20853/27394)
Line Coverage 69.51% (214472/308570)
Region Coverage 67.53% (128236/189882)
Branch Coverage 61.13% (66758/109206)

@morrySnow morrySnow changed the title [Cherry-Pick](branch-3.1) Pick "[Enhancement](Log) Missing rowset clone should not print stack log (#53193)" branch-3.1: [Enhancement](Log) Missing rowset clone should not print stack log #53193 Jul 19, 2025
@morrySnow morrySnow merged commit fb77c02 into apache:branch-3.1 Jul 19, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yukang-Lian @Thearas @doris-robot @hello-stephen @morrySnow